mirror of
https://github.com/NixOS/nixpkgs.git
synced 2024-11-26 00:43:20 +00:00
e0464e4788
In preparation for the deprecation of `stdenv.isX`. These shorthands are not conducive to cross-compilation because they hide the platforms. Darwin might get cross-compilation for which the continued usage of `stdenv.isDarwin` will get in the way One example of why this is bad and especially affects compiler packages https://www.github.com/NixOS/nixpkgs/pull/343059 There are too many files to go through manually but a treewide should get users thinking when they see a `hostPlatform.isX` in a place where it doesn't make sense. ``` fd --type f "\.nix" | xargs sd --fixed-strings "stdenv.is" "stdenv.hostPlatform.is" fd --type f "\.nix" | xargs sd --fixed-strings "stdenv'.is" "stdenv'.hostPlatform.is" fd --type f "\.nix" | xargs sd --fixed-strings "clangStdenv.is" "clangStdenv.hostPlatform.is" fd --type f "\.nix" | xargs sd --fixed-strings "gccStdenv.is" "gccStdenv.hostPlatform.is" fd --type f "\.nix" | xargs sd --fixed-strings "stdenvNoCC.is" "stdenvNoCC.hostPlatform.is" fd --type f "\.nix" | xargs sd --fixed-strings "inherit (stdenv) is" "inherit (stdenv.hostPlatform) is" fd --type f "\.nix" | xargs sd --fixed-strings "buildStdenv.is" "buildStdenv.hostPlatform.is" fd --type f "\.nix" | xargs sd --fixed-strings "effectiveStdenv.is" "effectiveStdenv.hostPlatform.is" fd --type f "\.nix" | xargs sd --fixed-strings "originalStdenv.is" "originalStdenv.hostPlatform.is" ```
122 lines
3.7 KiB
Nix
122 lines
3.7 KiB
Nix
{ lib
|
|
, stdenv
|
|
, fetchFromGitHub
|
|
, qtbase
|
|
, qtsvg
|
|
, qtwayland
|
|
, qtwebengine
|
|
, qtdeclarative
|
|
, extra-cmake-modules
|
|
, cpp-utilities
|
|
, qtutilities
|
|
, qtforkawesome
|
|
, boost
|
|
, wrapQtAppsHook
|
|
, cmake
|
|
, kio
|
|
, plasma-framework
|
|
, qttools
|
|
, iconv
|
|
, cppunit
|
|
, syncthing
|
|
, xdg-utils
|
|
, webviewSupport ? true
|
|
, jsSupport ? true
|
|
, kioPluginSupport ? stdenv.hostPlatform.isLinux
|
|
, plasmoidSupport ? stdenv.hostPlatform.isLinux
|
|
, systemdSupport ? stdenv.hostPlatform.isLinux
|
|
/* It is possible to set via this option an absolute exec path that will be
|
|
written to the `~/.config/autostart/syncthingtray.desktop` file generated
|
|
during runtime. Alternatively, one can edit the desktop file themselves after
|
|
it is generated See:
|
|
https://github.com/NixOS/nixpkgs/issues/199596#issuecomment-1310136382 */
|
|
, autostartExecPath ? "syncthingtray"
|
|
, versionCheckHook
|
|
}:
|
|
|
|
stdenv.mkDerivation (finalAttrs: {
|
|
version = "1.6.2";
|
|
pname = "syncthingtray";
|
|
|
|
src = fetchFromGitHub {
|
|
owner = "Martchus";
|
|
repo = "syncthingtray";
|
|
rev = "v${finalAttrs.version}";
|
|
hash = "sha256-L56aX5UFFodSR2YHWt6Y+s83q3YoAuYvyqXP/XVMp20=";
|
|
};
|
|
|
|
buildInputs = [
|
|
qtbase
|
|
qtsvg
|
|
cpp-utilities
|
|
qtutilities
|
|
boost
|
|
qtforkawesome
|
|
] ++ lib.optionals stdenv.hostPlatform.isDarwin [ iconv ]
|
|
++ lib.optionals stdenv.hostPlatform.isLinux [ qtwayland ]
|
|
++ lib.optionals webviewSupport [ qtwebengine ]
|
|
++ lib.optionals jsSupport [ qtdeclarative ]
|
|
++ lib.optionals kioPluginSupport [ kio ]
|
|
++ lib.optionals plasmoidSupport [ plasma-framework ]
|
|
;
|
|
|
|
nativeBuildInputs = [
|
|
wrapQtAppsHook
|
|
cmake
|
|
qttools
|
|
# Although these are test dependencies, we add them anyway so that we test
|
|
# whether the test units compile. On Darwin we don't run the tests but we
|
|
# still build them.
|
|
cppunit
|
|
syncthing
|
|
]
|
|
++ lib.optionals plasmoidSupport [ extra-cmake-modules ]
|
|
;
|
|
|
|
# syncthing server seems to hang on darwin, causing tests to fail.
|
|
doCheck = !stdenv.hostPlatform.isDarwin;
|
|
preCheck = ''
|
|
export QT_QPA_PLATFORM=offscreen
|
|
export QT_PLUGIN_PATH="${lib.getBin qtbase}/${qtbase.qtPluginPrefix}"
|
|
'';
|
|
postInstall = lib.optionalString stdenv.hostPlatform.isDarwin ''
|
|
# put the app bundle into the proper place /Applications instead of /bin
|
|
mkdir -p $out/Applications
|
|
mv $out/bin/syncthingtray.app $out/Applications
|
|
# Make binary available in PATH like on other platforms
|
|
ln -s $out/Applications/syncthingtray.app/Contents/MacOS/syncthingtray $out/bin/syncthingtray
|
|
'';
|
|
nativeInstallCheckInputs = [
|
|
versionCheckHook
|
|
];
|
|
doInstallCheck = true;
|
|
|
|
cmakeFlags = [
|
|
"-DQT_PACKAGE_PREFIX=Qt${lib.versions.major qtbase.version}"
|
|
"-DKF_PACKAGE_PREFIX=KF${lib.versions.major qtbase.version}"
|
|
"-DBUILD_TESTING=ON"
|
|
# See https://github.com/Martchus/syncthingtray/issues/208
|
|
"-DEXCLUDE_TESTS_FROM_ALL=OFF"
|
|
"-DAUTOSTART_EXEC_PATH=${autostartExecPath}"
|
|
# See https://github.com/Martchus/syncthingtray/issues/42
|
|
"-DQT_PLUGIN_DIR:STRING=${placeholder "out"}/${qtbase.qtPluginPrefix}"
|
|
"-DBUILD_SHARED_LIBS=ON"
|
|
] ++ lib.optionals (!plasmoidSupport) ["-DNO_PLASMOID=ON"]
|
|
++ lib.optionals (!kioPluginSupport) ["-DNO_FILE_ITEM_ACTION_PLUGIN=ON"]
|
|
++ lib.optionals systemdSupport ["-DSYSTEMD_SUPPORT=ON"]
|
|
++ lib.optionals (!webviewSupport) ["-DWEBVIEW_PROVIDER:STRING=none"]
|
|
;
|
|
|
|
qtWrapperArgs = [
|
|
"--prefix PATH : ${lib.makeBinPath [ xdg-utils ]}"
|
|
];
|
|
|
|
meta = with lib; {
|
|
homepage = "https://github.com/Martchus/syncthingtray";
|
|
description = "Tray application and Dolphin/Plasma integration for Syncthing";
|
|
license = licenses.gpl2Plus;
|
|
maintainers = with maintainers; [ doronbehar ];
|
|
platforms = platforms.linux ++ platforms.darwin;
|
|
};
|
|
})
|