mirror of
https://github.com/NixOS/nixpkgs.git
synced 2024-11-22 06:53:01 +00:00
e0464e4788
In preparation for the deprecation of `stdenv.isX`. These shorthands are not conducive to cross-compilation because they hide the platforms. Darwin might get cross-compilation for which the continued usage of `stdenv.isDarwin` will get in the way One example of why this is bad and especially affects compiler packages https://www.github.com/NixOS/nixpkgs/pull/343059 There are too many files to go through manually but a treewide should get users thinking when they see a `hostPlatform.isX` in a place where it doesn't make sense. ``` fd --type f "\.nix" | xargs sd --fixed-strings "stdenv.is" "stdenv.hostPlatform.is" fd --type f "\.nix" | xargs sd --fixed-strings "stdenv'.is" "stdenv'.hostPlatform.is" fd --type f "\.nix" | xargs sd --fixed-strings "clangStdenv.is" "clangStdenv.hostPlatform.is" fd --type f "\.nix" | xargs sd --fixed-strings "gccStdenv.is" "gccStdenv.hostPlatform.is" fd --type f "\.nix" | xargs sd --fixed-strings "stdenvNoCC.is" "stdenvNoCC.hostPlatform.is" fd --type f "\.nix" | xargs sd --fixed-strings "inherit (stdenv) is" "inherit (stdenv.hostPlatform) is" fd --type f "\.nix" | xargs sd --fixed-strings "buildStdenv.is" "buildStdenv.hostPlatform.is" fd --type f "\.nix" | xargs sd --fixed-strings "effectiveStdenv.is" "effectiveStdenv.hostPlatform.is" fd --type f "\.nix" | xargs sd --fixed-strings "originalStdenv.is" "originalStdenv.hostPlatform.is" ```
43 lines
769 B
Nix
43 lines
769 B
Nix
{
|
|
curl,
|
|
darwin,
|
|
lib,
|
|
netlify-cli,
|
|
runCommand,
|
|
stdenv,
|
|
}:
|
|
|
|
runCommand "netlify-cli-test" {
|
|
nativeBuildInputs = [
|
|
netlify-cli
|
|
curl
|
|
] ++ lib.optionals stdenv.hostPlatform.isDarwin [
|
|
darwin.ps
|
|
];
|
|
meta.timeout = 600;
|
|
} ''
|
|
mkdir home
|
|
export HOME=$PWD/home
|
|
|
|
# Create a simple site
|
|
echo '<h1>hi</h1>' >index.html
|
|
echo '/with-redirect /' >_redirects
|
|
|
|
# Start a local server and wait for it to respond
|
|
netlify dev --offline --port 8888 2>&1 | tee log &
|
|
sleep 0.1 || true
|
|
for (( i=0; i<300; i++ )); do
|
|
if grep --ignore-case 'Server now ready' <log; then
|
|
break
|
|
else
|
|
sleep 1
|
|
fi
|
|
done
|
|
|
|
# Test the local server
|
|
curl -L http://localhost:8888/with-redirect | grep '<h1>hi</h1>'
|
|
|
|
# Success
|
|
touch $out
|
|
''
|