mirror of
https://github.com/NixOS/nixpkgs.git
synced 2024-11-22 06:53:01 +00:00
e0464e4788
In preparation for the deprecation of `stdenv.isX`. These shorthands are not conducive to cross-compilation because they hide the platforms. Darwin might get cross-compilation for which the continued usage of `stdenv.isDarwin` will get in the way One example of why this is bad and especially affects compiler packages https://www.github.com/NixOS/nixpkgs/pull/343059 There are too many files to go through manually but a treewide should get users thinking when they see a `hostPlatform.isX` in a place where it doesn't make sense. ``` fd --type f "\.nix" | xargs sd --fixed-strings "stdenv.is" "stdenv.hostPlatform.is" fd --type f "\.nix" | xargs sd --fixed-strings "stdenv'.is" "stdenv'.hostPlatform.is" fd --type f "\.nix" | xargs sd --fixed-strings "clangStdenv.is" "clangStdenv.hostPlatform.is" fd --type f "\.nix" | xargs sd --fixed-strings "gccStdenv.is" "gccStdenv.hostPlatform.is" fd --type f "\.nix" | xargs sd --fixed-strings "stdenvNoCC.is" "stdenvNoCC.hostPlatform.is" fd --type f "\.nix" | xargs sd --fixed-strings "inherit (stdenv) is" "inherit (stdenv.hostPlatform) is" fd --type f "\.nix" | xargs sd --fixed-strings "buildStdenv.is" "buildStdenv.hostPlatform.is" fd --type f "\.nix" | xargs sd --fixed-strings "effectiveStdenv.is" "effectiveStdenv.hostPlatform.is" fd --type f "\.nix" | xargs sd --fixed-strings "originalStdenv.is" "originalStdenv.hostPlatform.is" ```
123 lines
4.2 KiB
Nix
123 lines
4.2 KiB
Nix
{ majorVersion, minorVersion, sourceSha256, patchesToFetch ? [] }:
|
|
{ stdenv, lib, fetchurl, cmake, libGLU, libGL, libX11, xorgproto, libXt, libpng, libtiff
|
|
, fetchpatch
|
|
, enableQt ? false, qtx11extras, qttools, qtdeclarative, qtEnv
|
|
, enablePython ? false, python ? throw "vtk: Python support requested, but no python interpreter was given."
|
|
, enableEgl ? false
|
|
# Darwin support
|
|
, AGL, Cocoa, CoreServices, DiskArbitration, IOKit, CFNetwork, Security, GLUT, OpenGL
|
|
, ApplicationServices, CoreText, IOSurface, ImageIO, xpc, libobjc
|
|
}:
|
|
|
|
let
|
|
inherit (lib) optionalString optionals optional;
|
|
|
|
version = "${majorVersion}.${minorVersion}";
|
|
pythonMajor = lib.substring 0 1 python.pythonVersion;
|
|
|
|
in stdenv.mkDerivation {
|
|
pname = "vtk"
|
|
+ optionalString enableEgl "-egl"
|
|
+ optionalString enableQt "-qvtk";
|
|
inherit version;
|
|
|
|
src = fetchurl {
|
|
url = "https://www.vtk.org/files/release/${majorVersion}/VTK-${version}.tar.gz";
|
|
sha256 = sourceSha256;
|
|
};
|
|
|
|
nativeBuildInputs = [ cmake ];
|
|
|
|
buildInputs = [ libpng libtiff ]
|
|
++ optionals enableQt [ (qtEnv "qvtk-qt-env" [ qtx11extras qttools qtdeclarative ]) ]
|
|
++ optionals stdenv.hostPlatform.isLinux [
|
|
libGLU
|
|
xorgproto
|
|
libXt
|
|
] ++ optionals stdenv.hostPlatform.isDarwin [
|
|
xpc
|
|
AGL
|
|
Cocoa
|
|
CoreServices
|
|
DiskArbitration
|
|
IOKit
|
|
CFNetwork
|
|
Security
|
|
ApplicationServices
|
|
CoreText
|
|
IOSurface
|
|
ImageIO
|
|
OpenGL
|
|
GLUT
|
|
] ++ optionals enablePython [
|
|
python
|
|
];
|
|
propagatedBuildInputs = optionals stdenv.hostPlatform.isDarwin [ libobjc ]
|
|
++ optionals stdenv.hostPlatform.isLinux [ libX11 libGL ];
|
|
# see https://github.com/NixOS/nixpkgs/pull/178367#issuecomment-1238827254
|
|
|
|
patches = map fetchpatch patchesToFetch;
|
|
|
|
# GCC 13: error: 'int64_t' in namespace 'std' does not name a type
|
|
postPatch = ''
|
|
sed '1i#include <cstdint>' \
|
|
-i ThirdParty/libproj/vtklibproj/src/proj_json_streaming_writer.hpp \
|
|
-i IO/Image/vtkSEPReader.h
|
|
''
|
|
+ optionalString stdenv.hostPlatform.isDarwin ''
|
|
sed -i 's|COMMAND vtkHashSource|COMMAND "DYLD_LIBRARY_PATH=''${VTK_BINARY_DIR}/lib" ''${VTK_BINARY_DIR}/bin/vtkHashSource-${majorVersion}|' ./Parallel/Core/CMakeLists.txt
|
|
sed -i 's/fprintf(output, shift)/fprintf(output, "%s", shift)/' ./ThirdParty/libxml2/vtklibxml2/xmlschemas.c
|
|
sed -i 's/fprintf(output, shift)/fprintf(output, "%s", shift)/g' ./ThirdParty/libxml2/vtklibxml2/xpath.c
|
|
'';
|
|
|
|
dontWrapQtApps = true;
|
|
|
|
# Shared libraries don't work, because of rpath troubles with the current
|
|
# nixpkgs cmake approach. It wants to call a binary at build time, just
|
|
# built and requiring one of the shared objects.
|
|
# At least, we use -fPIC for other packages to be able to use this in shared
|
|
# objects.
|
|
cmakeFlags = [
|
|
"-DCMAKE_C_FLAGS=-fPIC"
|
|
"-DCMAKE_CXX_FLAGS=-fPIC"
|
|
"-DVTK_MODULE_USE_EXTERNAL_vtkpng=ON"
|
|
"-DVTK_MODULE_USE_EXTERNAL_vtktiff=1"
|
|
"-DVTK_MODULE_ENABLE_VTK_RenderingExternal=YES"
|
|
] ++ lib.optionals (!stdenv.hostPlatform.isDarwin) [
|
|
"-DOPENGL_INCLUDE_DIR=${libGL}/include"
|
|
(lib.cmakeBool "VTK_OPENGL_HAS_EGL" enableEgl)
|
|
] ++ [
|
|
"-DCMAKE_INSTALL_LIBDIR=lib"
|
|
"-DCMAKE_INSTALL_INCLUDEDIR=include"
|
|
"-DCMAKE_INSTALL_BINDIR=bin"
|
|
"-DVTK_VERSIONED_INSTALL=OFF"
|
|
] ++ optionals enableQt [
|
|
"-DVTK_GROUP_ENABLE_Qt:STRING=YES"
|
|
]
|
|
++ optionals stdenv.hostPlatform.isDarwin [ "-DOPENGL_INCLUDE_DIR=${OpenGL}/Library/Frameworks" ]
|
|
++ optionals enablePython [
|
|
"-DVTK_WRAP_PYTHON:BOOL=ON"
|
|
"-DVTK_PYTHON_VERSION:STRING=${pythonMajor}"
|
|
];
|
|
|
|
env = lib.optionalAttrs stdenv.cc.isClang {
|
|
NIX_CFLAGS_COMPILE = "-Wno-error=incompatible-function-pointer-types";
|
|
};
|
|
|
|
postInstall = optionalString enablePython ''
|
|
substitute \
|
|
${./vtk.egg-info} \
|
|
$out/${python.sitePackages}/vtk-${version}.egg-info \
|
|
--subst-var-by VTK_VER "${version}"
|
|
'';
|
|
|
|
meta = with lib; {
|
|
description = "Open source libraries for 3D computer graphics, image processing and visualization";
|
|
homepage = "https://www.vtk.org/";
|
|
license = licenses.bsd3;
|
|
maintainers = with maintainers; [ knedlsepp tfmoraes ];
|
|
platforms = platforms.unix;
|
|
badPlatforms = optionals enableEgl platforms.darwin;
|
|
};
|
|
}
|