mirror of
https://github.com/NixOS/nixpkgs.git
synced 2024-11-22 06:53:01 +00:00
e0464e4788
In preparation for the deprecation of `stdenv.isX`. These shorthands are not conducive to cross-compilation because they hide the platforms. Darwin might get cross-compilation for which the continued usage of `stdenv.isDarwin` will get in the way One example of why this is bad and especially affects compiler packages https://www.github.com/NixOS/nixpkgs/pull/343059 There are too many files to go through manually but a treewide should get users thinking when they see a `hostPlatform.isX` in a place where it doesn't make sense. ``` fd --type f "\.nix" | xargs sd --fixed-strings "stdenv.is" "stdenv.hostPlatform.is" fd --type f "\.nix" | xargs sd --fixed-strings "stdenv'.is" "stdenv'.hostPlatform.is" fd --type f "\.nix" | xargs sd --fixed-strings "clangStdenv.is" "clangStdenv.hostPlatform.is" fd --type f "\.nix" | xargs sd --fixed-strings "gccStdenv.is" "gccStdenv.hostPlatform.is" fd --type f "\.nix" | xargs sd --fixed-strings "stdenvNoCC.is" "stdenvNoCC.hostPlatform.is" fd --type f "\.nix" | xargs sd --fixed-strings "inherit (stdenv) is" "inherit (stdenv.hostPlatform) is" fd --type f "\.nix" | xargs sd --fixed-strings "buildStdenv.is" "buildStdenv.hostPlatform.is" fd --type f "\.nix" | xargs sd --fixed-strings "effectiveStdenv.is" "effectiveStdenv.hostPlatform.is" fd --type f "\.nix" | xargs sd --fixed-strings "originalStdenv.is" "originalStdenv.hostPlatform.is" ```
201 lines
6.0 KiB
Nix
201 lines
6.0 KiB
Nix
{ lib
|
|
, stdenv
|
|
, python311Packages
|
|
, fetchFromGitHub
|
|
, fetchurl
|
|
, cargo
|
|
, curl
|
|
, pkg-config
|
|
, openssl
|
|
, rustPlatform
|
|
, rustc
|
|
, fetchYarnDeps
|
|
, yarn
|
|
, nodejs
|
|
, fixup-yarn-lock
|
|
, glibcLocales
|
|
, libiconv
|
|
, Cocoa
|
|
, CoreFoundation
|
|
, CoreGraphics
|
|
, CoreServices
|
|
, Security
|
|
, WebKit
|
|
|
|
, enableMinimal ? false
|
|
}:
|
|
|
|
let
|
|
inherit (lib.importJSON ./deps.json) links version versionHash;
|
|
# Sapling sets a Cargo config containing lines like so:
|
|
# [target.aarch64-apple-darwin]
|
|
# rustflags = ["-C", "link-args=-Wl,-undefined,dynamic_lookup"]
|
|
#
|
|
# The default cargo config that's set by the build hook will set
|
|
# unstable.host-config and unstable.target-applies-to-host which seems to
|
|
# result in the link arguments above being ignored and thus link failures.
|
|
# All it is there to do anyway is just to do stuff with musl and cross
|
|
# compilation, which doesn't work on macOS anyway so we can just stub it
|
|
# on macOS.
|
|
#
|
|
# See https://github.com/NixOS/nixpkgs/pull/198311#issuecomment-1326894295
|
|
myCargoSetupHook = rustPlatform.cargoSetupHook.overrideAttrs (old: {
|
|
cargoConfig = lib.optionalString (!stdenv.hostPlatform.isDarwin) old.cargoConfig;
|
|
});
|
|
|
|
src = fetchFromGitHub {
|
|
owner = "facebook";
|
|
repo = "sapling";
|
|
rev = version;
|
|
hash = "sha256-4pOpJ91esTSH90MvvMu74CnlLULLUawqxcniUeqnLwA=";
|
|
};
|
|
|
|
addonsSrc = "${src}/addons";
|
|
|
|
# Fetches the Yarn modules in Nix to to be used as an offline cache
|
|
yarnOfflineCache = fetchYarnDeps {
|
|
yarnLock = "${addonsSrc}/yarn.lock";
|
|
sha256 = "sha256-jCtrflwDrwql6rY1ff1eXLKdwmnXhg5bCJPlCczBCIk=";
|
|
};
|
|
|
|
# Builds the NodeJS server that runs with `sl web`
|
|
isl = stdenv.mkDerivation {
|
|
pname = "sapling-isl";
|
|
src = addonsSrc;
|
|
inherit version;
|
|
|
|
nativeBuildInputs = [
|
|
fixup-yarn-lock
|
|
nodejs
|
|
yarn
|
|
];
|
|
|
|
buildPhase = ''
|
|
runHook preBuild
|
|
|
|
export HOME=$(mktemp -d)
|
|
fixup-yarn-lock yarn.lock
|
|
yarn config --offline set yarn-offline-mirror ${yarnOfflineCache}
|
|
yarn install --offline --frozen-lockfile --ignore-engines --ignore-scripts --no-progress
|
|
patchShebangs node_modules
|
|
patchShebangs isl/node_modules
|
|
|
|
substituteInPlace build-tar.py \
|
|
--replace-fail 'run(yarn + ["--cwd", src_join(), "install", "--prefer-offline"])' 'pass'
|
|
|
|
${python311Packages.python}/bin/python3 build-tar.py \
|
|
--output isl-dist.tar.xz \
|
|
--yarn 'yarn --offline --frozen-lockfile --ignore-engines --ignore-scripts --no-progress'
|
|
|
|
runHook postBuild
|
|
'';
|
|
|
|
installPhase = ''
|
|
runHook preInstall
|
|
|
|
mkdir -p $out
|
|
install isl-dist.tar.xz $out/isl-dist.tar.xz
|
|
|
|
runHook postInstall
|
|
'';
|
|
};
|
|
in
|
|
# Builds the main `sl` binary and its Python extensions
|
|
python311Packages.buildPythonApplication {
|
|
pname = "sapling";
|
|
inherit src version;
|
|
|
|
sourceRoot = "${src.name}/eden/scm";
|
|
|
|
# Upstream does not commit Cargo.lock
|
|
cargoDeps = rustPlatform.importCargoLock {
|
|
lockFile = ./Cargo.lock;
|
|
outputHashes = {
|
|
"abomonation-0.7.3+smallvec1" = "sha256-AxEXR6GC8gHjycIPOfoViP7KceM29p2ZISIt4iwJzvM=";
|
|
"cloned-0.1.0" = "sha256-2BaNR/pQmR7pHtRf6VBQLcZgLHbj2JCxeX4auAB0efU=";
|
|
"fb303_core-0.0.0" = "sha256-PDGdKjR6KPv1uH1JSTeoG5Rs0ZkmNJLqqSXtvV3RWic=";
|
|
"fbthrift-0.0.1+unstable" = "sha256-J4REXGuLjHyN3SHilSWhMoqpRcn1QnEtsTsZF4Z3feU=";
|
|
"serde_bser-0.4.0" = "sha256-Su1IP3NzQu/87p/+uQaG8JcICL9hit3OV1O9oFiACsQ=";
|
|
};
|
|
};
|
|
postPatch = ''
|
|
cp ${./Cargo.lock} Cargo.lock
|
|
'' + lib.optionalString (!enableMinimal) ''
|
|
# If asked, we optionally patch in a hardcoded path to the
|
|
# 'nodejs' package, so that 'sl web' always works. Without the
|
|
# patch, 'sl web' will still work if 'nodejs' is in $PATH.
|
|
substituteInPlace lib/config/loader/src/builtin_static/core.rs \
|
|
--replace '"#);' $'[web]\nnode-path=${nodejs}/bin/node\n"#);'
|
|
'';
|
|
|
|
# Since the derivation builder doesn't have network access to remain pure,
|
|
# fetch the artifacts manually and link them. Then replace the hardcoded URLs
|
|
# with filesystem paths for the curl calls.
|
|
postUnpack = ''
|
|
mkdir $sourceRoot/hack_pydeps
|
|
${lib.concatStrings (map (li: "ln -s ${fetchurl li} $sourceRoot/hack_pydeps/${baseNameOf li.url}\n") links)}
|
|
sed -i "s|https://files.pythonhosted.org/packages/[[:alnum:]]*/[[:alnum:]]*/[[:alnum:]]*/|file://$NIX_BUILD_TOP/$sourceRoot/hack_pydeps/|g" $sourceRoot/setup.py
|
|
'';
|
|
|
|
postInstall = ''
|
|
install ${isl}/isl-dist.tar.xz $out/lib/isl-dist.tar.xz
|
|
'';
|
|
|
|
postFixup = lib.optionalString stdenv.hostPlatform.isLinux ''
|
|
wrapProgram $out/bin/sl \
|
|
--set LOCALE_ARCHIVE "${glibcLocales}/lib/locale/locale-archive"
|
|
'';
|
|
|
|
nativeBuildInputs = [
|
|
curl
|
|
pkg-config
|
|
myCargoSetupHook
|
|
cargo
|
|
rustc
|
|
];
|
|
|
|
buildInputs = [
|
|
openssl
|
|
] ++ lib.optionals stdenv.hostPlatform.isDarwin [
|
|
curl
|
|
libiconv
|
|
Cocoa
|
|
CoreFoundation
|
|
CoreGraphics
|
|
CoreServices
|
|
Security
|
|
WebKit
|
|
];
|
|
|
|
HGNAME = "sl";
|
|
SAPLING_OSS_BUILD = "true";
|
|
SAPLING_VERSION_HASH = versionHash;
|
|
|
|
# Python setuptools version 66 and newer does not support upstream Sapling's
|
|
# version numbers (e.g. "0.2.20230124-180750-hf8cd450a"). Change the version
|
|
# number to something supported by setuptools (e.g. "0.2.20230124").
|
|
# https://github.com/facebook/sapling/issues/571
|
|
SAPLING_VERSION = builtins.elemAt (builtins.split "-" version) 0;
|
|
|
|
# just a simple check phase, until we have a running test suite. this should
|
|
# help catch issues like lack of a LOCALE_ARCHIVE setting (see GH PR #202760)
|
|
doCheck = true;
|
|
installCheckPhase = ''
|
|
echo -n "testing sapling version; should be \"$SAPLING_VERSION\"... "
|
|
$out/bin/sl version | grep -qw "$SAPLING_VERSION"
|
|
echo "OK!"
|
|
'';
|
|
|
|
# Expose isl to nix repl as sapling.isl.
|
|
passthru.isl = isl;
|
|
|
|
meta = with lib; {
|
|
description = "Scalable, User-Friendly Source Control System";
|
|
homepage = "https://sapling-scm.com";
|
|
license = licenses.gpl2Only;
|
|
maintainers = with maintainers; [ pbar thoughtpolice ];
|
|
platforms = platforms.unix;
|
|
mainProgram = "sl";
|
|
};
|
|
}
|