mirror of
https://github.com/NixOS/nixpkgs.git
synced 2024-11-22 15:03:28 +00:00
e0464e4788
In preparation for the deprecation of `stdenv.isX`. These shorthands are not conducive to cross-compilation because they hide the platforms. Darwin might get cross-compilation for which the continued usage of `stdenv.isDarwin` will get in the way One example of why this is bad and especially affects compiler packages https://www.github.com/NixOS/nixpkgs/pull/343059 There are too many files to go through manually but a treewide should get users thinking when they see a `hostPlatform.isX` in a place where it doesn't make sense. ``` fd --type f "\.nix" | xargs sd --fixed-strings "stdenv.is" "stdenv.hostPlatform.is" fd --type f "\.nix" | xargs sd --fixed-strings "stdenv'.is" "stdenv'.hostPlatform.is" fd --type f "\.nix" | xargs sd --fixed-strings "clangStdenv.is" "clangStdenv.hostPlatform.is" fd --type f "\.nix" | xargs sd --fixed-strings "gccStdenv.is" "gccStdenv.hostPlatform.is" fd --type f "\.nix" | xargs sd --fixed-strings "stdenvNoCC.is" "stdenvNoCC.hostPlatform.is" fd --type f "\.nix" | xargs sd --fixed-strings "inherit (stdenv) is" "inherit (stdenv.hostPlatform) is" fd --type f "\.nix" | xargs sd --fixed-strings "buildStdenv.is" "buildStdenv.hostPlatform.is" fd --type f "\.nix" | xargs sd --fixed-strings "effectiveStdenv.is" "effectiveStdenv.hostPlatform.is" fd --type f "\.nix" | xargs sd --fixed-strings "originalStdenv.is" "originalStdenv.hostPlatform.is" ```
52 lines
1.2 KiB
Nix
52 lines
1.2 KiB
Nix
{ lib
|
|
, stdenv
|
|
, fetchFromGitHub
|
|
, buildPythonApplication
|
|
, pem
|
|
, pyside6
|
|
, twisted
|
|
, certifi
|
|
, qt6
|
|
, appnope
|
|
, enableGUI ? true
|
|
}:
|
|
|
|
buildPythonApplication rec {
|
|
pname = "syncplay";
|
|
version = "1.7.3";
|
|
|
|
format = "other";
|
|
|
|
src = fetchFromGitHub {
|
|
owner = "Syncplay";
|
|
repo = "syncplay";
|
|
rev = "refs/tags/v${version}";
|
|
sha256 = "sha256-ipo027XyN4BpMkxzXznbnaufsaG/YkHxFJYo+XWzbyE=";
|
|
};
|
|
|
|
patches = [
|
|
./trusted_certificates.patch
|
|
];
|
|
|
|
buildInputs = lib.optionals enableGUI [ (if stdenv.hostPlatform.isLinux then qt6.qtwayland else qt6.qtbase) ];
|
|
propagatedBuildInputs = [ certifi pem twisted ]
|
|
++ twisted.optional-dependencies.tls
|
|
++ lib.optional enableGUI pyside6
|
|
++ lib.optional (stdenv.hostPlatform.isDarwin && enableGUI) appnope;
|
|
nativeBuildInputs = lib.optionals enableGUI [ qt6.wrapQtAppsHook ];
|
|
|
|
makeFlags = [ "DESTDIR=" "PREFIX=$(out)" ];
|
|
|
|
postFixup = lib.optionalString enableGUI ''
|
|
wrapQtApp $out/bin/syncplay
|
|
'';
|
|
|
|
meta = with lib; {
|
|
homepage = "https://syncplay.pl/";
|
|
description = "Free software that synchronises media players";
|
|
license = licenses.asl20;
|
|
platforms = platforms.linux ++ platforms.darwin;
|
|
maintainers = with maintainers; [ assistant ];
|
|
};
|
|
}
|