These flags are not part of waf, they're custom flags that are not
widely implemented. More packages are broken because of these flags
being added than actually recognise them.
Of the packages in Nixpkgs that directly depend on wafHook that we can
attempt to cross compile (i.e. all their dependencies cross compile),
5 already successfully cross compile and recognise these flags, 2
already successfully cross compile because they have been opted out of
these flags, 3 don't cross compile successfully for reasons unrelated
to these flags, and for the remaining 7, the only thing stopping them
cross compiling successfully is that they are being passed these flags
that they don't recognise.
All of the five successfully cross-compiling packages that do
recognise these flags are samba projects: ldb, talloc, tdb, tevent,
and samba4. So this isn't a general waf convention, just a samba one.
It therefore doesn't make sense to set these flags by default. They
should just be included in the expressions for each samba project,
like all the other quirks common to samba build systems.
This change fixes cross compilation of the following packages:
blockhash ganv ndn-cxx mda_lv2 pflask raul saldl
c733f0bf8a switched JACK to using overlay-style
mkDerivation, but forgot to change a reference to `version` to `finalAttrs.version`.
This wasn't caught at eval time because `with lib` was used, making the
source derivation try to fetch (at the time of writing) tag "23.05pre-git",
which obviously doesn't exist :D
Thanks to V for catching this [0].
[0]: https://github.com/NixOS/nixpkgs/pull/216096#issuecomment-1437763295
*Flags implies a list
slightly relevant:
> stdenv: start deprecating non-list configureFlags https://github.com/NixOS/nixpkgs/pull/173172
the makeInstalledTests function in `nixos/tests/installed-tests/default.nix` isn't available outside of nixpkgs so
it's not a breaking change
This avoids the potential conflict between autoconf flags and the waf
flags. There is some overlap between the two but waf errors when it
doesn’t recognize the flag.
He prefers to contribute to his own nixpkgs fork triton.
Since he is still marked as maintainer in many packages
this leaves the wrong impression he still maintains those.
Semi-automatic update generated by https://github.com/ryantm/nix-update tools. These checks were done:
- built on NixOS
- ran `/nix/store/h64aj4vry98w3pmdqbd1bqkhxnghbvgb-jack1-0.125.0/bin/jackd -V` and found version 0.125.0
- ran `/nix/store/h64aj4vry98w3pmdqbd1bqkhxnghbvgb-jack1-0.125.0/bin/jackd --version` and found version 0.125.0
- ran `/nix/store/h64aj4vry98w3pmdqbd1bqkhxnghbvgb-jack1-0.125.0/bin/jack_server_control -h` got 0 exit code
- ran `/nix/store/h64aj4vry98w3pmdqbd1bqkhxnghbvgb-jack1-0.125.0/bin/jack_server_control -V` and found version 0.125.0
- ran `/nix/store/h64aj4vry98w3pmdqbd1bqkhxnghbvgb-jack1-0.125.0/bin/jack_server_control -v` and found version 0.125.0
- ran `/nix/store/h64aj4vry98w3pmdqbd1bqkhxnghbvgb-jack1-0.125.0/bin/jack_server_control -h` and found version 0.125.0
- ran `/nix/store/h64aj4vry98w3pmdqbd1bqkhxnghbvgb-jack1-0.125.0/bin/jack_midi_dump -h` got 0 exit code
- found 0.125.0 with grep in /nix/store/h64aj4vry98w3pmdqbd1bqkhxnghbvgb-jack1-0.125.0
- directory tree listing: https://gist.github.com/359dc1584108a662b645c49abe027c95
