Commit Graph

12 Commits

Author SHA1 Message Date
nicoo
09eb3c64e8 lib.fetchers.normalizeHash: more implementation comment and clearer variable names 2024-09-17 14:48:44 +00:00
nicoo
4c991b74d3 lib.fetchers.normalizeHash: replace "" with lib.fake* 2024-09-17 10:51:47 +00:00
nicoo
4e59b77c70 lib.fetchers: factor-out definitions common to normalizeHash and withNormalizedHash 2024-09-17 08:31:50 +00:00
nicoo
8376e18291 lib.fetchers: replace with-bindings with explicit let inherit 2024-09-17 08:31:50 +00:00
nicoo
f470dc703c lib.fetchers: optimize normalizeHash and withNormalizedHash via min-scoping 2024-09-17 08:31:42 +00:00
nicoo
39446161fc lib.fetchers.withNormalizedHash: handle fetchers whose hash parameter is optional 2024-09-17 08:31:28 +00:00
nicoo
ac177dff93 lib.fetchers: add normalizeHash and withNormalizedHash 2024-09-17 06:33:43 +00:00
Tim Cuthbertson
911aa1440f treewide: support NIX_SSL_CERT_FILE as an impureEnvVar
This envvar is also added to lib.proxyImpureEnvVars since it's
typically required for https proxies.

This change also updates fetchgit and go module fetching to use this
envvar. NIX_GIT_SSL_CAINFO is still supported for backwards
compatibility in fetchgit.
2024-08-23 21:34:22 +10:00
ramboman
3ce1079753 lib.fetchers: Add uppercase proxy environment variables
The [Nix installer](84e0c464f1/scripts/install-systemd-multi-user.sh (L38)) and the [documentation](84e0c464f1/doc/manual/src/installation/env-variables.md (L54-L56)) state that they support uppercase proxy environment variables. [lib/fetchers.nix](165090ed66/lib/fetchers.nix (L10)) only supports lowercase proxy environment variables.

Fix: [nix#10491](https://github.com/NixOS/nix/issues/10491)
2024-04-26 14:30:55 -04:00
Graham Christensen
152c63c9ff
Convert libs to a fixed-point
This does break the API of being able to import any lib file and get
its libs, however I'm not sure people did this.

I made this while exploring being able to swap out docFn with a stub
in #2305, to avoid functor performance problems. I don't know if that
is going to move forward (or if it is a problem or not,) but after
doing all this work figured I'd put it up anyway :)

Two notable advantages to this approach:

1. when a lib inherits another lib's functions, it doesn't
   automatically get put in to the scope of lib
2. when a lib implements a new obscure functions, it doesn't
   automatically get put in to the scope of lib

Using the test script (later in this commit) I got the following diff
on the API:

  + diff master fixed-lib
  11764a11765,11766
  > .types.defaultFunctor
  > .types.defaultTypeMerge
  11774a11777,11778
  > .types.isOptionType
  > .types.isType
  11781a11786
  > .types.mkOptionType
  11788a11794
  > .types.setType
  11795a11802
  > .types.types

This means that this commit _adds_ to the API, however I can't find a
way to fix these last remaining discrepancies. At least none are
_removed_.

Test script (run with nix-repl in the PATH):

  #!/bin/sh

  set -eux

  repl() {
      suff=${1:-}
      echo "(import ./lib)$suff" \
          | nix-repl 2>&1
  }

  attrs_to_check() {
      repl "${1:-}" \
          | tr ';'  $'\n' \
          | grep "\.\.\." \
          | cut -d' ' -f2 \
          | sed -e "s/^/${1:-}./" \
          | sort
  }

  summ() {
      repl "${1:-}" \
          | tr ' ' $'\n' \
          | sort \
          | uniq
  }

  deep_summ() {
      suff="${1:-}"
      depth="${2:-4}"
      depth=$((depth - 1))
      summ "$suff"

      for attr in $(attrs_to_check "$suff" | grep -v "types.types"); do
          if [ $depth -eq 0 ]; then
              summ "$attr" | sed -e "s/^/$attr./"
          else
              deep_summ "$attr" "$depth" | sed -e "s/^/$attr./"
          fi
      done
  }

  (
      cd nixpkgs

      #git add .
      #git commit -m "Auto-commit, sorry" || true
      git checkout fixed-lib
      deep_summ > ../fixed-lib
      git checkout master
      deep_summ > ../master
  )

  if diff master fixed-lib; then
      echo "SHALLOW MATCH!"
  fi

  (
      cd nixpkgs
      git checkout fixed-lib
      repl .types
  )
2017-09-16 21:36:43 -04:00
Tom Saeger
5989515b94 lib: trivial spelling fixes 2017-04-19 19:37:55 -05:00
Profpatsch
61462c94e6 lib/fetchers.nix: factor out impure proxy vars (#18702)
Apparently everyone just copied those variables, instead of creating a
library constant for them. Some even removed the comment. -.-
2016-09-17 21:50:01 +02:00