There is no need to fire up a whole VM just to run a two line test of
creating the extension. We can use postgresqlTestExtension for that.
This has the advantage that it runs with postgresqlTestHook, so without
a VM, making it more portable.
Manually importing postgresql packages from the /pkgs/ folder or
manually importing the test from /nixos/tests/ in generic.nix is not
only ugly, but also forbidden should we ever move to pkgs/by-name.
We can achieve almost the same with a slightly different setup. We allow
overriding the postgresql package for the test via passthru.override, to
make sure that each postgresql_xx.tests.postgresql-wal-receiver is
properly teted with the right version.
We are migrating packages that meet below requirements:
1. using `callPackage`
2. called path is a directory
3. overriding set is empty (`{ }`)
4. not containing path expressions other than relative path (to
makenixpkgs-vet happy)
5. not referenced by nix files outside of the directory, other
than`pkgs/top-level/all-packages.nix`
6. not referencing nix files outside of the directory
7. not referencing `default.nix` (since it's changed to `package.nix`)
8. `outPath` doesn't change after migration
The tool is here: https://github.com/Aleksanaa/by-name-migrate.
This fixes the following error:
error: comparison of integers of different signs: 'ssize_t' (aka 'long')
and 'const size_t' (aka 'const unsigned long') [-Werror,-Wsign-compare]
if (part < iov[i].iov_len)
~~~~ ^ ~~~~~~~~~~~~~~
The build was failing with:
darwin/io_analysis.c:71:21: error: variable length array used
[-Werror,-Wvla]
char device_name[kMaxDiskNameSize];
^~~~~~~~~~~~~~~~
When building with goolm support, libstdc++ must be linked, as
libsignal-ffi depends on it being linked.
When building with (deprecated) libolm, it's pulled in transitively, it
seems -- and it that case, this is effectively a no-op.
Signed-off-by: Christoph Heiss <christoph@c8h4.io>
Another year, another exhausting undermoderated thread full of people
arguing against being an inclusive community, tone policing and denying
that discriminatory behaviour even exists.
This clearly isn't getting any better and I'm embarrassed that I stayed
around for this long. I can't continue to lend my name to such a
project.
