Upstream `cvise` changed the way it encodes shebang from hardcoded value
to `/bin` + value:
d99d82ce8e
This broke `nixpkgs` substitute hack and broke the option.
I proposed upstream to use `/usr/bin/env bash` indirection instead. This
change pulls in this proposed change.
checkInputs used to be added to nativeBuildInputs. Now we have
nativeCheckInputs to do that instead. Doing this treewide change allows
to keep hashes identical to before the introduction of
nativeCheckInputs.
`-Werror` flag usually causes build failures due to minor changes in
compiler versions. They might be useful for developers themselves but
are rarely useful for distributions.
For example right now `cvise` fails to compile on `gcc-13` due to
a `gcc` infelicity: https://gcc.gnu.org/PR107488
While this concrete instance is a compiler bug generally `-Werror` makes
users' lives harder. Specific `-Werror=<foo>` are better way to prevent
certain classes of bugs.
The change removes blanket `-Werror` with a `substituteInPlace` call.
Noticed failures as an incorrect handling of `--command` param:
$ cvise --command="gcc -c bug.c |& fgrep 'during RTL pass: expand'" bug.c
C-Vise cannot run because the interestingness test does not return
zero.
This happens because temporary shell script has "#!/bin/bash" shebang.
The change replaces it to path from nix store.
