In preparation for the deprecation of `stdenv.isX`.
These shorthands are not conducive to cross-compilation because they
hide the platforms.
Darwin might get cross-compilation for which the continued usage of `stdenv.isDarwin` will get in the way
One example of why this is bad and especially affects compiler packages
https://www.github.com/NixOS/nixpkgs/pull/343059
There are too many files to go through manually but a treewide should
get users thinking when they see a `hostPlatform.isX` in a place where it
doesn't make sense.
```
fd --type f "\.nix" | xargs sd --fixed-strings "stdenv.is" "stdenv.hostPlatform.is"
fd --type f "\.nix" | xargs sd --fixed-strings "stdenv'.is" "stdenv'.hostPlatform.is"
fd --type f "\.nix" | xargs sd --fixed-strings "clangStdenv.is" "clangStdenv.hostPlatform.is"
fd --type f "\.nix" | xargs sd --fixed-strings "gccStdenv.is" "gccStdenv.hostPlatform.is"
fd --type f "\.nix" | xargs sd --fixed-strings "stdenvNoCC.is" "stdenvNoCC.hostPlatform.is"
fd --type f "\.nix" | xargs sd --fixed-strings "inherit (stdenv) is" "inherit (stdenv.hostPlatform) is"
fd --type f "\.nix" | xargs sd --fixed-strings "buildStdenv.is" "buildStdenv.hostPlatform.is"
fd --type f "\.nix" | xargs sd --fixed-strings "effectiveStdenv.is" "effectiveStdenv.hostPlatform.is"
fd --type f "\.nix" | xargs sd --fixed-strings "originalStdenv.is" "originalStdenv.hostPlatform.is"
```
This was added in 6832a42b7f, which
replaced an attrset with `qt4Support = config.avahi.qt4Support or false;`.
As qt4 support is now out of the tree, so should this be as well.
This applies the fix for avahi/avahi#212 where having a single invalid
service being published inside a network could DoS discovery for all
avahi clients.
For me this happened with a "SIEMENS HM676G0S6". AFAIK Bosch (from the
original GitHub issue) is a subsidiary of Siemens.
Fixes: avahi/avahi#212
Perl is only required for doxygen which we don't use here
and xmltoman which we don't even package. In any case if
it was used it should have been in nativeBuildInputs, not
buildInputs like now.
Building `pkgsCross.aarch64-multiplatform.avahi` would fail in the past with:
checking for pkg-config... no
configure: error: pkg-config is required to install this program
To fix that, two independent workarounds were applied, each sufficient:
- 34e4d0fd98
- 65a5313de5
These days, it is more common to just add `pkg-config` to `depsBuildBuild`.
- intltool was replaced by vanilla gettext 3d5a0c6805
- gtk2 and qt4 disabled by default f060abee28
- qt3 disabled by default 6ae71484f4
- howl-compat was disabled by default 17 years ago 16d9e30dd7
Avahi would segfault on a NULL pointer dereference when trying to
resolve .local addresses.
This patch fixes that quite annoying behaviour, but apparently wasn’t
worth a release yet.
continuation of #109595
pkgconfig was aliased in 2018, however, it remained in
all-packages.nix due to its wide usage. This cleans
up the remaining references to pkgs.pkgsconfig and
moves the entry to aliases.nix.
python3Packages.pkgconfig remained unchanged because
it's the canonical name of the upstream package
on pypi.
Bugfix release, backwards compatible:
https://github.com/lathiat/avahi/releases/tag/v0.6.32
* Update src URL to github (the latest release is only available there).
* Change "$(mkdir_p)" to "$(MKDIR_P)" in the patch to keep it working
(apply'able).
There are many more packages to fix, this is just a start.
Rules:
* Don't repeat the package name (not always that easy...)
* Start with capital letter
* Don't end with full stop
* Don't start with "The ..." or "A ..."
I've also added descriptions to some packages and rewritten others.
