Commit Graph

4 Commits

Author SHA1 Message Date
adisbladis
e0816431a2 treewide: Pass self when overriding Python
Otherwise references to the Python interpreter inside the set are wrong, as demonstrated by:
``` nix
with import <nixpkgs> { };
let
  python' = python3.override {
    packageOverrides = final: prev: { requests = prev.requests.overridePythonAttrs(old: { version = "1337";  }); };
  };
in python'.pkgs.python.pkgs.requests
```
which returns the _non_ overriden requests.

And the same with `self`:
```
with import <nixpkgs> { };
let
  python' = python3.override {
    self = python';
    packageOverrides = final: prev: { requests = prev.requests.overridePythonAttrs(old: { version = "1337";  }); };
  };
in python'.pkgs.python.pkgs.requests
```
which returns the overriden requests.

This can manifest itself as file collisions when constructing environments or as subtly incorrect dependency graphs.
2024-08-03 12:18:56 +12:00
Jeffrey Harmon
471f48a215
gdtoolkit_3: 3.3.1 -> 3.5.0 2024-06-07 15:40:59 -04:00
Jeffrey Harmon
c01927fc82
gdtoolkit: rename to gdtoolkit_3 2024-06-07 15:40:58 -04:00
Jeffrey Harmon
64494ffef1
gdtoolkit_4: init at 4.2.2 2024-06-07 15:40:37 -04:00