According to Nixpkgs manual[1] and NixOS 23.11 Release Note[2], the
`sourceRoot` attribute passed to `stdenv.mkDerivation` should be
specified as `"${src.name}"` or `"${src.name}/subdir"` when `src` is
produced using `fetchgit`-based fetchers.
`sourceRoot = "source"` or `sourceRoot = "source/subdir"` is based on
the assumption that the `name` attribute of these pre-unpacked fetchers
are always `"source"`, which is not the case. Expecting constant `name`
also makes the source FODs prone to irrelevent hashes during version
bumps.
[1]: https://nixos.org/manual/nixpkgs/unstable/#var-stdenv-sourceRoot
[2]: https://nixos.org/manual/nixos/stable/release-notes#sec-release-23.11
Reverts NixOS/nixpkgs#269620
- eab0837b68 caused a mass-rebuild on master
- self-merge on a critical package without review and not waiting for the active owner team
Below are the reverts of the commits from that PR
Revert "systemd: migrate to by-name"
This reverts commit 33d2a40d67.
Revert "systemd: add meta.longDescription"
This reverts commit 7c588d141d.
Revert "systemd: cosmetic rewording of code"
This reverts commit d91b8d9fcb.
Revert "systemd: cosmetic rewording of comments"
This reverts commit bc563998c0.
Revert "systemd: remove some redundancy on mesonFlags"
This reverts commit eab0837b68.
Revert "systemd: use lib.meson* functions"
This reverts commit 1129756b1a.
