Commit Graph

17 Commits

Author SHA1 Message Date
Artturin
e0464e4788 treewide: replace stdenv.is with stdenv.hostPlatform.is
In preparation for the deprecation of `stdenv.isX`.

These shorthands are not conducive to cross-compilation because they
hide the platforms.

Darwin might get cross-compilation for which the continued usage of `stdenv.isDarwin` will get in the way

One example of why this is bad and especially affects compiler packages
https://www.github.com/NixOS/nixpkgs/pull/343059

There are too many files to go through manually but a treewide should
get users thinking when they see a `hostPlatform.isX` in a place where it
doesn't make sense.

```
fd --type f "\.nix" | xargs sd --fixed-strings "stdenv.is" "stdenv.hostPlatform.is"
fd --type f "\.nix" | xargs sd --fixed-strings "stdenv'.is" "stdenv'.hostPlatform.is"
fd --type f "\.nix" | xargs sd --fixed-strings "clangStdenv.is" "clangStdenv.hostPlatform.is"
fd --type f "\.nix" | xargs sd --fixed-strings "gccStdenv.is" "gccStdenv.hostPlatform.is"
fd --type f "\.nix" | xargs sd --fixed-strings "stdenvNoCC.is" "stdenvNoCC.hostPlatform.is"
fd --type f "\.nix" | xargs sd --fixed-strings "inherit (stdenv) is" "inherit (stdenv.hostPlatform) is"
fd --type f "\.nix" | xargs sd --fixed-strings "buildStdenv.is" "buildStdenv.hostPlatform.is"
fd --type f "\.nix" | xargs sd --fixed-strings "effectiveStdenv.is" "effectiveStdenv.hostPlatform.is"
fd --type f "\.nix" | xargs sd --fixed-strings "originalStdenv.is" "originalStdenv.hostPlatform.is"
```
2024-09-25 00:04:37 +03:00
David McFarland
f1be43a54e ncftp: fix darwin build 2024-03-29 10:26:49 -03:00
Artturin
f9fdf2d402 treewide: move NIX_CFLAGS_COMPILE to the env attrset
with structuredAttrs lists will be bash arrays which cannot be exported
which will be a issue with some patches and some wrappers like cc-wrapper

this makes it clearer that NIX_CFLAGS_COMPILE must be a string as lists
in env cause a eval failure
2023-02-22 21:23:04 +02:00
Sergei Trofimovich
43b8ad27aa ncftp: add -fcommon workaround
Workaround build failure on -fno-common toolchains like upstream
gcc-10. Otherwise build fails as:

    ld: bookmark.o: (.bss+0x20): multiple definition of `gBm';
      gpshare.o:(.bss+0x0): first defined here
2022-05-24 07:31:20 +02:00
Profpatsch
4a7f99d55d treewide: with stdenv.lib; in meta -> with lib;
Part of: https://github.com/NixOS/nixpkgs/issues/108938

meta = with stdenv.lib;

is a widely used pattern. We want to slowly remove
the `stdenv.lib` indirection and encourage people
to use `lib` directly. Thus let’s start with the meta
field.

This used a rewriting script to mostly automatically
replace all occurances of this pattern, and add the
`lib` argument to the package header if it doesn’t
exist yet.

The script in its current form is available at
https://cs.tvl.fyi/depot@2f807d7f141068d2d60676a89213eaa5353ca6e0/-/blob/users/Profpatsch/nixpkgs-rewriter/default.nix
2021-01-11 10:38:22 +01:00
Gabriel Ebner
07999f480b ncftp: do not override $TMPDIR 2020-09-09 20:57:32 +02:00
Michael Reilly
84cf00f980
treewide: Per RFC45, remove all unquoted URLs 2020-04-10 17:54:53 +01:00
volth
46420bbaa3 treewide: name -> pname (easy cases) (#66585)
treewide replacement of

stdenv.mkDerivation rec {
  name = "*-${version}";
  version = "*";

to pname
2019-08-15 13:41:18 +01:00
Markus Kowalewski
4d24db6e0c
ncftp: add license 2018-09-10 22:16:20 +02:00
Peter Hoeg
dab9d404ce ncftp: man and doc files were missing 2018-03-27 15:10:17 +08:00
adisbladis
2645683796
ncftp: 3.2.5 -> 3.2.6 2018-01-04 16:34:30 +01:00
Mitch Tishmack
d66e4c71fc Ncftp manpage /usr/local workaround
ncftp appears to not properly honor PREFIX in its manpage target and
tries to install them to /usr/local

Work around this by adding --mandir to its configure flags.
2015-11-22 14:16:35 -06:00
Bjørn Forsman
4d6605e882 Whitespace fixes in package expressions I maintain 2014-01-02 17:58:08 +01:00
Bjørn Forsman
d65cea26dc ncftp: 3.2.4 -> 3.2.5
Also, add missing ncurses buildInput and add/update meta attributes. The
homepage is back up!
2013-08-21 20:58:14 +02:00
Ludovic Courtès
9feaed78d2 ncftp: Get the source from Debian.
svn path=/nixpkgs/branches/stdenv-updates/; revision=24664
2010-11-11 17:32:53 +00:00
Peter Simons
9be0b9fea6 Update version of ncftp.
The old version 3.2.3 seems to have disappeared from the hosting server.

svn path=/nixpkgs/trunk/; revision=23153
2010-08-12 14:57:15 +00:00
Rob Vermaas
c3fe985546 * added ncftp
svn path=/nixpkgs/trunk/; revision=17214
2009-09-17 07:31:34 +00:00