Every time I decide to commit additional time to contributing to nix,
quite a few "concerned" members come out, either to decry a ban on
bigotry and fascism in 2021, or to declare support for minority groups
in Nix discriminatory, or a number of other incidents that are not worth
recounting in this leaving message.
To avoid any ambiguity, my reasoning is similar to pr306702, pr307033, and
several others who felt actively made unwelcome or outright harassed out
of the Nix project.
Whenever we create scripts that are installed to $out, we must use runtimeShell
in order to get the shell that can be executed on the machine we create the
package for. This is relevant for cross-compiling. The only use case for
stdenv.shell are scripts that are executed as part of the build system.
Usages in checkPhase are borderline however to decrease the likelyhood
of people copying the wrong examples, I decided to use runtimeShell as well.
Many (less easily automatically converted) old-style strings
remain.
Where there was any possible ambiguity about the exact version or
variant intended, nothing was changed. IANAL, nor a search robot.
Use `with stdenv.lib` wherever it makes sense.
