Commit Graph

10 Commits

Author SHA1 Message Date
Artturin
e0464e4788 treewide: replace stdenv.is with stdenv.hostPlatform.is
In preparation for the deprecation of `stdenv.isX`.

These shorthands are not conducive to cross-compilation because they
hide the platforms.

Darwin might get cross-compilation for which the continued usage of `stdenv.isDarwin` will get in the way

One example of why this is bad and especially affects compiler packages
https://www.github.com/NixOS/nixpkgs/pull/343059

There are too many files to go through manually but a treewide should
get users thinking when they see a `hostPlatform.isX` in a place where it
doesn't make sense.

```
fd --type f "\.nix" | xargs sd --fixed-strings "stdenv.is" "stdenv.hostPlatform.is"
fd --type f "\.nix" | xargs sd --fixed-strings "stdenv'.is" "stdenv'.hostPlatform.is"
fd --type f "\.nix" | xargs sd --fixed-strings "clangStdenv.is" "clangStdenv.hostPlatform.is"
fd --type f "\.nix" | xargs sd --fixed-strings "gccStdenv.is" "gccStdenv.hostPlatform.is"
fd --type f "\.nix" | xargs sd --fixed-strings "stdenvNoCC.is" "stdenvNoCC.hostPlatform.is"
fd --type f "\.nix" | xargs sd --fixed-strings "inherit (stdenv) is" "inherit (stdenv.hostPlatform) is"
fd --type f "\.nix" | xargs sd --fixed-strings "buildStdenv.is" "buildStdenv.hostPlatform.is"
fd --type f "\.nix" | xargs sd --fixed-strings "effectiveStdenv.is" "effectiveStdenv.hostPlatform.is"
fd --type f "\.nix" | xargs sd --fixed-strings "originalStdenv.is" "originalStdenv.hostPlatform.is"
```
2024-09-25 00:04:37 +03:00
Sandro Jäckel
653837881e
treewide: replace lib/${python.libPrefix}/site-packages with its shorthand ${python.sitePackages}
which should be always preferred
2024-01-30 19:56:57 +01:00
Artturin
226e149145 treewide: env.NIX_CFLAGS_COMPILE use optionalString instead of optional
env values must be strings
2023-02-22 21:23:05 +02:00
Artturin
f9fdf2d402 treewide: move NIX_CFLAGS_COMPILE to the env attrset
with structuredAttrs lists will be bash arrays which cannot be exported
which will be a issue with some patches and some wrappers like cc-wrapper

this makes it clearer that NIX_CFLAGS_COMPILE must be a string as lists
in env cause a eval failure
2023-02-22 21:23:04 +02:00
Sandro
5ecf65eb6f
Merge pull request #193680 from wegank/gimp-aarch64-darwin 2022-10-04 15:12:33 +02:00
Weijia Wang
7994937ed2 pygtk: fix build on aarch64-darwin 2022-10-04 13:42:41 +02:00
Frederik Rietdijk
1d20d67783 python2Packages.pygtk: format should be other
because it doesn't use any of the hooks for building.
2022-09-16 19:36:05 +02:00
Ilya Fedin
4165ae5392 pygtk: set outputs to reduce runtime closure 2022-05-13 21:01:08 +04:00
piegames
724822a79d python2Packages.{pygtk,pyGtkGlade}: remove libglade support 2022-01-29 18:08:51 +01:00
Frederik Rietdijk
ae18d68b6b python2.pkgs: move expressions into python2-modules/ folder
Another step in further separating python2 from python3.
2022-01-16 10:00:16 +01:00