Commit Graph

3 Commits

Author SHA1 Message Date
Xandor Schiefer
92d4b33203
vscode-js-debug: darwin support 2024-06-28 00:08:53 +02:00
Xandor Schiefer
f4423979de
vscode-js-debug: fix missing jq in postPatch
Fixes #320507.

The `npmConfigHook` used by `buildNpmPackage` does not correctly
propagate the `nativeBuildInputs` into its `PATH`, which is why `jq` was
not available during the patch phase.

Since this `npmConfigHook` is run as part of a fixed-output
derivation (`fetchNpmDeps`), if it had already been realised, unless its
hash had changed, a missing `jq` would not be noticed, on a rebuild of
`vscode-js-debug`.

The `postPatch` hook is *also* run during `buildNpmPackage`, but there
the `nativeBuildInputs` were correctly added to the `PATH`, which is why
a rebuild of `vscode-js-debug` with the previous `postPatch` would
succeed (if its `npmDeps`'s hash hadn't changed).
2024-06-18 22:24:01 +02:00
Xandor Schiefer
2bd7c27874
vscode-js-debug: init at 1.90.0
Closes https://github.com/NixOS/nixpkgs/issues/281031.
2024-06-12 11:56:58 +02:00