We are migrating packages that meet below requirements:
1. using `callPackage`
2. called path is a directory
3. overriding set is empty (`{ }`)
4. not containing path expressions other than relative path (to
makenixpkgs-vet happy)
5. not referenced by nix files outside of the directory, other
than`pkgs/top-level/all-packages.nix`
6. not referencing nix files outside of the directory
7. not referencing `default.nix` (since it's changed to `package.nix`)
8. `outPath` doesn't change after migration
The tool is here: https://github.com/Aleksanaa/by-name-migrate.
Another year, another exhausting undermoderated thread full of people
arguing against being an inclusive community, tone policing and denying
that discriminatory behaviour even exists.
This clearly isn't getting any better and I'm embarrassed that I stayed
around for this long. I can't continue to lend my name to such a
project.
Without the change the build against `gcc-14` fails as:
$ nix build --impure --expr 'with import ./. {}; xcur2png.override { stdenv = gcc14Stdenv; }'
...
xcur2png.c: In function 'saveConfAndPNGs':
xcur2png.c:690:10: error: type defaults to 'int' in declaration of 'dry_run' [-Wimplicit-int-Wimplicit-int]
690 | extern dry_run;
| ^~~~~~~
The indentation stripping semantics of strings are fairly bad and have a
few gotchas where the resulting string has not the intended indentation.
This commit fixes most if not all such instances in Nixpkgs.
I tried to strive a balance between keeping the diff small and
reformatting/refactoring the code to look better. In general,
reformatting should be left to Nixfmt.
Note that this causes a lot of rebuilds by design. All changes need to
be thoroughly vetted and reviewed for correctness. There is no automatic
way to prove correctness.
List of files to fix generated by running
https://gerrit.lix.systems/c/lix/+/2092 on Nixpkgs and looking at the
warnings.
