Commit Graph

6 Commits

Author SHA1 Message Date
Silvan Mosberger
299a181477 ci/request-reviews: Fix for branches starting with "pr"
Turns out if :<something> is passed, a local branch is updated, which
can conflict if the PR branch starts with "pr". I tried to avoid that
with the original code but apparently that didn't work!

https://github.com/NixOS/nixpkgs/actions/runs/11284183639/job/31384967152?pr=347822

    Fetching the PR commit history
    From https://github.com/linj-fork/nixpkgs
     * [new branch]            pr/kanata-add-version-check -> fork/pr
    error: cannot lock ref 'refs/remotes/fork/pr/kanata-add-version-check': 'refs/remotes/fork/pr' exists; cannot create 'refs/remotes/fork/pr/kanata-add-version-check'
     ! [new branch]            pr/kanata-add-version-check -> fork/pr/kanata-add-version-check  (unable to update local ref)
    error: some local refs could not be updated; try running
2024-10-11 03:40:57 +02:00
Emily
27272c21af
Mass pings be gone, code owners for all (#347610) 2024-10-10 00:52:01 +01:00
Silvan Mosberger
c721e917ce ci/request-reviews: Make wrong base branch message hashes more transparent
Also, fix the description of the text
2024-10-10 01:40:11 +02:00
Silvan Mosberger
1ff83b2c96 ci/request-reviews: Request reviews for individual team members
This makes this codeowner mechanism behave differently than the native
one, but there's no other way to avoid rerequesting reviews from teams
when a member already reviewed the PR.
2024-10-09 23:49:14 +02:00
Silvan Mosberger
9a054bb9dd ci/request-reviews: Don't rerequest users that already reviewed
The automation should never rerequest reviews from users that already
reviewed the changes, which is what was happening before this change:

https://github.com/NixOS/nixpkgs/pull/347354#event-14570645380

Also reorder the arguments to make more sense
2024-10-09 23:49:01 +02:00
Silvan Mosberger
369cfa02da ci: Add review request scripts
Also post a comment in case base branch is wrong
  This guides newcomers in how to smoothly handle the potentially scary
  situation of having thousands of commits listed in a PR.

  While CI shows the same, people might not even look at CI if the PR
  looks botched.
2024-10-08 22:14:01 +02:00