After final improvements to the official formatter implementation,
this commit now performs the first treewide reformat of Nix files using it.
This is part of the implementation of RFC 166.
Only "inactive" files are reformatted, meaning only files that
aren't being touched by any PR with activity in the past 2 months.
This is to avoid conflicts for PRs that might soon be merged.
Later we can do a full treewide reformat to get the rest,
which should not cause as many conflicts.
A CI check has already been running for some time to ensure that new and
already-formatted files are formatted, so the files being reformatted here
should also stay formatted.
This commit was automatically created and can be verified using
nix-build a08b3a4d19.tar.gz \
--argstr baseRev b32a094368
result/bin/apply-formatting $NIXPKGS_PATH
We are migrating packages that meet below requirements:
1. using `callPackage`
2. called path is a directory
3. overriding set is empty (`{ }`)
4. not containing path expressions other than relative path (to
makenixpkgs-vet happy)
5. not referenced by nix files outside of the directory, other
than`pkgs/top-level/all-packages.nix`
6. not referencing nix files outside of the directory
7. not referencing `default.nix` (since it's changed to `package.nix`)
8. `outPath` doesn't change after migration
The tool is here: https://github.com/Aleksanaa/by-name-migrate.
Without the change the eval fails as:
$ nix build --no-link -f. pyamlboot.tests
error:
… while evaluating the attribute 'version'
at pkgs/by-name/py/pyamlboot/package.nix:29:3:
28|
29| passthru.tests.version = testers.testVersion {
| ^
30| package = "pyamlboot";
… while evaluating the 'name' attribute of a derivation
… while evaluating a branch condition
at lib/strings.nix:2627:3:
2626| # First detect the common case of already valid strings, to speed those up
2627| if stringLength string <= 207 && okRegex string != null
| ^
2628| then unsafeDiscardStringContext string
(stack trace truncated; use '--show-trace' to show the full, detailed trace)
error: expected a set but found a string: "pyamlboot"
After fixing the eval tests started failing as `--version` hardcodes 1.0.
Co-authored-by: Nick Cao <nickcao@nichi.co>
