After final improvements to the official formatter implementation,
this commit now performs the first treewide reformat of Nix files using it.
This is part of the implementation of RFC 166.
Only "inactive" files are reformatted, meaning only files that
aren't being touched by any PR with activity in the past 2 months.
This is to avoid conflicts for PRs that might soon be merged.
Later we can do a full treewide reformat to get the rest,
which should not cause as many conflicts.
A CI check has already been running for some time to ensure that new and
already-formatted files are formatted, so the files being reformatted here
should also stay formatted.
This commit was automatically created and can be verified using
nix-build a08b3a4d19.tar.gz \
--argstr baseRev b32a094368
result/bin/apply-formatting $NIXPKGS_PATH
In preparation for the deprecation of `stdenv.isX`.
These shorthands are not conducive to cross-compilation because they
hide the platforms.
Darwin might get cross-compilation for which the continued usage of `stdenv.isDarwin` will get in the way
One example of why this is bad and especially affects compiler packages
https://www.github.com/NixOS/nixpkgs/pull/343059
There are too many files to go through manually but a treewide should
get users thinking when they see a `hostPlatform.isX` in a place where it
doesn't make sense.
```
fd --type f "\.nix" | xargs sd --fixed-strings "stdenv.is" "stdenv.hostPlatform.is"
fd --type f "\.nix" | xargs sd --fixed-strings "stdenv'.is" "stdenv'.hostPlatform.is"
fd --type f "\.nix" | xargs sd --fixed-strings "clangStdenv.is" "clangStdenv.hostPlatform.is"
fd --type f "\.nix" | xargs sd --fixed-strings "gccStdenv.is" "gccStdenv.hostPlatform.is"
fd --type f "\.nix" | xargs sd --fixed-strings "stdenvNoCC.is" "stdenvNoCC.hostPlatform.is"
fd --type f "\.nix" | xargs sd --fixed-strings "inherit (stdenv) is" "inherit (stdenv.hostPlatform) is"
fd --type f "\.nix" | xargs sd --fixed-strings "buildStdenv.is" "buildStdenv.hostPlatform.is"
fd --type f "\.nix" | xargs sd --fixed-strings "effectiveStdenv.is" "effectiveStdenv.hostPlatform.is"
fd --type f "\.nix" | xargs sd --fixed-strings "originalStdenv.is" "originalStdenv.hostPlatform.is"
```
Fixes a bunch of CVEs (but not all of them apparently).
Changes:
https://forum.xpdfreader.com/viewtopic.php?t=43343
```
4.05 (2024-feb-08)
------------------
Added the '-overwrite' option to pdftohtml.
Added the 'ignoreWrongSizeToUnicode' xpdfrc setting.
Added the loadSession and saveSession commands, and the 'Load last
session' menu item.
Added code to automatically save and restore the xpdf session under
control of a session manager. This has not been thoroughly tested
yet.
Added the zoomScaleFactor xpdfrc setting.
Added the zoomValues xpdfrc setting.
Added a 'smart case' option for search in xpdf.
Added the '-custom' flag to pdfinfo.
Added a color/gray/mono switch to the 'save image' dialog.
Added the separateRotatedText xpdfrc setting.
Added the '-meta' flag to pdftohtml.
Added the allowLinksToChangeZoom xpdfrc setting.
Added the 'uses JavaScript' output to pdfinfo.
Implemented pattern stroking of text. Also fixed the various
combinations of filling/stroking with color/pattern + clipping, some
of which weren't being handled correctly.
Pdftops now (re)compresses any uncompressed or RLE-compressed images.
On an out-of-memory error, the command line tools now exit with an
"out of memory" message, rather than an exception message.
Add code to pdfimages to extract images from tiling patterns.
Pdftops can now embed external 8-bit OpenType CFF fonts.
Fixed a corner case in the text extractor related to characters drawn
at extremely large coordinates. [Thanks to elvadisas for the bug
report.]
Fixed an integer overflow in the transparency group code. [Thanks to
elvadisas for the bug report.]
Modify Annots::Annots() to skip annotations that have been turned into
AcroFormFields -- invalid Widget-type annots will now be rendered as
annots.
Added a missing integer overflow check in the JBIG2 decoder. [Thanks
to sangjun for the bug report.]
Added some sanity checks to the JBIG2 decoder. [Thanks to sangjun and
ycdxsb for the bug reports.]
Tiling patterns that use non-Normal blend modes can't be cached.
Fixed a bitmap size sanity check in the JBIG2 decoder. [Thanks to Han
Zheng (NCNIPC of China, Hexhive), for the bug report.]
Fixed a missing bounds check in FoFiType1C::convertToOpenType (used in
pdftohtml). [Thanks to cyth for the bug report.]
Fixed a use-after-free bug in pdftohtml. [Thanks to FeRDNYC for the
bug report.]
Merged aconf2.h into aconf.h; corrected the cmake config settings for
paths; added the BASE14_FONT_DIR config option. [Thanks to FeRDNYC
for the suggestions.]
Fixed a missing check for a zero-length index in the CFF (Type1C) font
parser. [Thanks to Yuhang Huang (NCNIPC of China), Han Zheng
(NCNIPC of China, Hexhive), Wanying Cao, Jiayu Zhao (NCNIPC of
China) for the bug report.]
Add an object loop check to Catalog::countPageTree().
The DCT decoder wasn't checking for an SOF before the first SOS.
[Thanks to cyth for the bug report.]
The inline image decoder was skipping to end-of-stream in the wrong
stream object. [Thanks to cyth for the bug report.]
Fixed a bug in the JPEG 2000 decoder when nLayers > 1 and the
'termination on each coding pass' flag is set.
Removed the #pragma interface/implementation stuff (which is outdated
and useless at this point).
Fixed a bug in the ICCBased color space parser that was allowing the
number of components to be zero. (CVE-2023-2662) [Thanks to
huckleberry for the bug report.]
Added checks for PDF object loops in AcroForm::scanField()
(CVE-2018-7453, CVE-2018-16369, CVE-2022-36561, CVE-2022-41844),
Catalog::readPageLabelTree2() (CVE-2023-2663), and
Catalog::readEmbeddedFileTree() (CVE-2023-2664).
The zero-width character problem can also happen if the page size is
very large -- that needs to be limited too, the same way as
character position coordinates. (CVE-2023-3044) [Thanks to jlinliu
for the bug report.]
Add some missing bounds check code in DCTStream. [Thanks to Jiahao
Liu for the bug report.]
Fix a deadlock when an object stream's length field is contained in
another object stream. (CVE-2023-3436) [Thanks to Jiahao Liu for
the bug report.]
Correctly handle tiling patterns with negative step values.
Ignore overprint in soft masks (to match Adobe's behavior).
```
The package already has some known vulnerabilities. I'm adding the new
ones mostly to save future me some time so I do not have to ask myself
if this long list on unpatched issues is expected or not.
Upstream expects to to fix all of that in xpdf 5.
* pkgs: refactor needless quoting of homepage meta attribute
A lot of packages are needlessly quoting the homepage meta attribute
(about 1400, 22%), this commit refactors all of those instances.
* pkgs: Fixing some links that were wrongfully unquoted in the previous
commit
* Fixed some instances
In line with the Nixpkgs manual.
A mechanical change, done with this command:
find pkgs -name "*.nix" | \
while read f; do \
sed -e 's/description\s*=\s*"\([a-z]\)/description = "\u\1/' -i "$f"; \
done
I manually skipped some:
* Descriptions starting with an abbreviation, a user name or package name
* Frequently generated expressions (haskell-packages.nix)
