Commit Graph

787 Commits

Author SHA1 Message Date
Silvan Mosberger
b246490d8c workflows: Rename after security fixes
In the previous two commits, security issues with these workflows were
fixed. In order for these to not be exploitable for PRs to branches that
don't have the fixes yet (including read-only branches like
nixos-unstable), these workflows are renamed, so that the old ones can
be turned off manually via GitHub interface.

Co-Authored-By: 13x1 <tori@disroot.org>
Co-Authored-By: basti564 <e3e@disroot.org>
(cherry picked from commit 5bbbc3a30b)
2024-10-26 16:54:44 +02:00
Silvan Mosberger
ccc38ebba1 workflows: Fix security issues
read-all permissions gives access to e.g. security-events, which these
don't need, and can easily lead to leaks

Co-Authored-By: 13x1 <tori@disroot.org>
Co-Authored-By: basti564 <e3e@disroot.org>
(cherry picked from commit 6b8ce4aedf)
2024-10-26 16:54:36 +02:00
Silvan Mosberger
5691625565 workflows/codeowners: Fix security issue
Co-Authored-By: 13x1 <tori@disroot.org>
Co-Authored-By: basti564 <e3e@disroot.org>
(cherry picked from commit 59aee1ca5d)
2024-10-26 16:54:23 +02:00
Silvan Mosberger
01f9bc543f workflows/codeowners: Cache codeowner validator build
The codeowner-validator build declared in ci/codeowners-validator was
not cached before and needed to be built for every PR, which is slow and
wasteful: https://github.com/NixOS/nixpkgs/actions/runs/11280533037/job/31373720922

(cherry picked from commit f9b28d5678)
2024-10-15 00:44:59 +02:00
Silvan Mosberger
b2bfec90cd CODEOWNERS: Switch to alternate mechanism
This effectively disables the native GitHub codeowners feature
and enables the new alternate codeowners mechanism introduced in
https://github.com/NixOS/nixpkgs/pull/336261

This means that:
- We can now declare users without write access as code owners!
- Targeting the wrong branch won't trigger mass pings anymore!

(cherry-picked from commit b01ca00aed)
2024-10-15 00:44:04 +02:00
Silvan Mosberger
bbd64b4b69 workflows/codeowners: Dry mode for now
Apparently it started requesting reviews from code owners already
because the DRY_MODE from the global env was overridden in the local job
declaration: https://github.com/NixOS/nixpkgs/pull/347354#event-14570645380

(cherry picked from commit c1710f234c)
2024-10-15 00:35:14 +02:00
Silvan Mosberger
2e923fb2f6 CODEOWNERS: Fix non-matching patterns
Since https://github.com/NixOS/nixpkgs/pull/336261 we have CI that
checks that the codeowners file is valid:

https://github.com/NixOS/nixpkgs/actions/runs/11243668280/job/31260095472#step:7:34

Which files are correct (or whether they were removed) was determined
using the Git history and some grepping

(cherry picked from commit dd2808213c)
2024-10-15 00:35:05 +02:00
Silvan Mosberger
2211c1011f OWNERS: placeholder init
(cherry picked from commit 93dcd42f2b)
2024-10-15 00:34:52 +02:00
Silvan Mosberger
5de26baf9f workflows/codeowners: init
(cherry picked from commit 87a2986c1a)
2024-10-15 00:33:55 +02:00
Jörg Thalheim
0eca7472c5 nix: add nix-team to CODEOWNERS
Update .github/CODEOWNERS

Co-authored-by: Robert Hensing <roberth@users.noreply.github.com>
(cherry picked from commit b6c51f7884)
2024-08-23 11:09:34 +02:00
Raito Bezarius
5c8373ea95 nix: remove myself from "code ownership" and 2.3 maintenance
I have no further plan to review CppNix code anymore as I will dedicate
myself to Lix development.

Co-authored-by: aleksana <me@aleksana.moe>
(cherry picked from commit bf7ddf86e4)
2024-08-23 11:09:29 +02:00
Maximilian Bosch
0ddd6ce4a9 nix: remove myself (ma27) from maintainer team
Using Lix now 🍦

(cherry picked from commit 7baa302736)
2024-08-23 11:09:26 +02:00
Silvan Mosberger
ebfc5f8b60 CODEOWNERS: set myself as code owner of workflows/check-nix-format
(cherry picked from commit 58f98e4b1b)
2024-07-15 17:49:04 +02:00
Silvan Mosberger
f8be62913c workflows/check-nix-format: strip newline from file listings
Otherwise it prints the command to run with an empty entry:

  nixfmt '<stuff>' ''

Thanks to https://yaml-multiline.info/ for the great help with this

(cherry picked from commit d0bebb7d6b)
2024-07-15 17:49:04 +02:00
Silvan Mosberger
34c5271739 workflows/check-nix-format: show command to fix
When some files are not formatted properly, this shows how people can
fix the problem.

This notably uses the shell.nix introduced in the parent commit to
ensure that the nixfmt version matches what CI expects.

(cherry picked from commit 53b517c685)
2024-07-15 17:49:04 +02:00
Silvan Mosberger
7d5716c800 root: shell.nix for nixfmt
This uses the reusable pinned Nixpkgs from the parent commit to create a
shell.nix file for an environment with a pinned nixfmt version.

(cherry picked from commit a70ab58960)
2024-07-15 17:49:04 +02:00
Silvan Mosberger
e9bd2f3c25 ci: reusable Nix format Nixpkgs pin
This is needed such that in the next commit, we can re-use the same
version from a shell.nix, allowing people to have a guaranteed matching
nixfmt version.

(cherry picked from commit b33ac05d04)
2024-07-15 17:49:04 +02:00
Silvan Mosberger
5f1fbdaff6 ci: init directory
This creates a new directory for all CI support files, will be populated
in future commits.

(cherry picked from commit 13599930cb)
2024-07-15 17:49:03 +02:00
superherointj
9bac7823ef github/workflows/check-nix-format: add maintainers files 2024-07-08 10:49:40 -03:00
Weijia Wang
d6285bd3f0
Merge pull request #324886 from eclairevoyant/backport-322386-to-release-24.05
[24.05] treewide: remove jonringer as package maintainer and code owner
2024-07-06 02:35:55 +02:00
Weijia Wang
2985e583e0
Merge pull request #324885 from eclairevoyant/backport-322266-to-release-24.05
[24.05] maintainers: remove ivar; CODEOWNERS: add corngood to dotnet paths
2024-07-06 02:34:26 +02:00
éclairevoyant
8ca5160be8 CODEOWNERS: remove samueldr
(cherry picked from commit 831527daf0)
2024-07-05 19:56:12 +00:00
Paul Meyer
2346b3aa26
CODEOWNERS: remove jonringer
Signed-off-by: Paul Meyer <49727155+katexochen@users.noreply.github.com>
(cherry picked from commit 56661d09f2)
2024-07-05 15:51:16 -04:00
éclairevoyant
d9b04d6669
CODEOWNERS: add corngood to dotnet paths
(cherry picked from commit a90e61f9c5)
2024-07-05 15:44:38 -04:00
éclairevoyant
65b7ebd2c5
maintainers: remove ivar
(cherry picked from commit 71e728d3b8)
2024-07-05 15:44:35 -04:00
github-actions[bot]
0c2f84330e
CODEOWNERS: Limit amount of notifications (#322225)
(cherry picked from commit df41f40ff9)

Co-authored-by: Janne Heß <janne@hess.ooo>
2024-06-24 20:01:21 +02:00
emilylange
25959fddfe CODEOWNERS: add adamcstephens to forgejo
(cherry picked from commit 8279d13a62)
2024-05-23 14:11:01 +00:00
emilylange
cc8d3f8be3 CODEOWNERS: fix forgejo package path
This slipped through the pkgs/by-name move in
3b4dad9b00.

(cherry picked from commit b8d9848dcb)
2024-05-23 14:11:01 +00:00
Silvan Mosberger
6fc3ccd95a workflows/check-by-name: Skip instead of canceling on conflicts
This avoids sending emails when there's merge conflicts.
The check will appear to be green,
but it doesn't matter since the PR can't be merged anyways.

Unfortunately there's no better way to do this right now: https://github.com/actions/runner/issues/662
2024-05-14 17:41:26 +02:00
dependabot[bot]
9f4ea63603
build(deps): bump actions/checkout from 4.1.4 to 4.1.5
Bumps [actions/checkout](https://github.com/actions/checkout) from 4.1.4 to 4.1.5.
- [Release notes](https://github.com/actions/checkout/releases)
- [Changelog](https://github.com/actions/checkout/blob/main/CHANGELOG.md)
- [Commits](0ad4b8fada...44c2b7a8a4)

---
updated-dependencies:
- dependency-name: actions/checkout
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <support@github.com>
2024-05-13 11:43:41 +00:00
superherointj
01f3bdb248 github/workflows: add k3s to check-nix-format 2024-05-10 18:55:58 -03:00
Marcus Ramberg
e6be02704b CODEOWNERS: Add marcusramberg to Perl 2024-05-10 18:32:20 +02:00
Martin Weinelt
622af635bb
pretalx: adopt and set up code ownership 2024-05-09 18:20:14 +02:00
superherointj
cdc46168b4 github: add k3s label 2024-05-07 13:16:46 -03:00
John Ericson
f571081899
Merge pull request #309577 from obsidiansystems/bsd-reformat
bsd treewide: Run RFC formatter
2024-05-06 15:08:43 -04:00
John Ericson
d516971246 workflows: Add pkgs/os-specific/bsd to formatter whitelist 2024-05-06 15:04:41 -04:00
Pol Dellaiera
75ae762133
workflows/check-nix-format: enforce for build-support/php 2024-05-04 23:06:24 +02:00
Pol Dellaiera
c759efa5e7
workflows/check-nix-format: enforce for php-packages 2024-05-04 23:04:36 +02:00
nicoo
294953ddb3 workflows: enforce RFC166 formatting for mpvScripts 2024-05-03 19:13:32 +00:00
piegames
e0c850e97f CODEOWNERS: Drop piegames 2024-05-03 13:36:23 +02:00
éclairevoyant
4818b00263
workflows/check-nix-format: enforce for vscode extensions 2024-05-01 06:00:27 -04:00
Artturin
96c80b33b5 labeler.yml: add 8.has: maintainer-list (update)
For things like tracking new contributors who also add themselves to maintainers.
2024-04-29 22:49:43 +02:00
dependabot[bot]
c3ce4079d7
build(deps): bump actions/checkout from 4.1.3 to 4.1.4
Bumps [actions/checkout](https://github.com/actions/checkout) from 4.1.3 to 4.1.4.
- [Release notes](https://github.com/actions/checkout/releases)
- [Changelog](https://github.com/actions/checkout/blob/main/CHANGELOG.md)
- [Commits](1d96c772d1...0ad4b8fada)

---
updated-dependencies:
- dependency-name: actions/checkout
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <support@github.com>
2024-04-29 11:45:13 +00:00
Frederik Rietdijk
5772ac5a75 Removing FRidh as active maintainer of packages
In the past I was very active with Python packaging.
For several years now I was hardly around as maintainer,
so it does not make sense I am listed as a maintainer for
these makes. Looking back, I should have removed myself
as maintainer already much longer ago. Anyway, better late
than never.

It's been a fun ride, and  I do intend to occasionally contribute
to Nixpkgs, but not in the same way it once was.
2024-04-28 12:20:07 +02:00
Silvan Mosberger
873871ed91
Merge pull request #306719 from willbush/workflows/by-name-concurrency-group
workflows: add concurrency group to check-by-name workflow (again)
2024-04-27 02:08:31 +02:00
Will Bush
16121d4dc6
workflows: add concurrency group to check-by-name workflow (again)
This is the second attempt to add a concurrency group to the check-by-name in
hopes that it will reduce unnecessary load on the CI system (wasted electricity)
despite free cost.

first attempt: https://github.com/NixOS/nixpkgs/pull/306072
revert: https://github.com/NixOS/nixpkgs/pull/306430
2024-04-25 02:03:11 -05:00
Peder Bergebakken Sundt
d2b73a52cf workflows/check-by-name.yml: Increase timeout for resolving merge commit 2024-04-24 14:15:18 +02:00
Mario Rodas
2becf6e837 maintainers: drop marsam 2024-04-24 04:20:00 +00:00
Will Bush
d28fa76260
Revert "workflows: add concurrency group to check-by-name workflow"
This reverts commit 75600cde6b.
2024-04-23 20:31:57 -05:00
Silvan Mosberger
b219715cd0
Merge pull request #306072 from willbush/workflow/check-by-name/concurrency-group
workflows: add concurrency group to check-by-name workflow
2024-04-24 01:59:44 +02:00