In preparation for the deprecation of `stdenv.isX`.
These shorthands are not conducive to cross-compilation because they
hide the platforms.
Darwin might get cross-compilation for which the continued usage of `stdenv.isDarwin` will get in the way
One example of why this is bad and especially affects compiler packages
https://www.github.com/NixOS/nixpkgs/pull/343059
There are too many files to go through manually but a treewide should
get users thinking when they see a `hostPlatform.isX` in a place where it
doesn't make sense.
```
fd --type f "\.nix" | xargs sd --fixed-strings "stdenv.is" "stdenv.hostPlatform.is"
fd --type f "\.nix" | xargs sd --fixed-strings "stdenv'.is" "stdenv'.hostPlatform.is"
fd --type f "\.nix" | xargs sd --fixed-strings "clangStdenv.is" "clangStdenv.hostPlatform.is"
fd --type f "\.nix" | xargs sd --fixed-strings "gccStdenv.is" "gccStdenv.hostPlatform.is"
fd --type f "\.nix" | xargs sd --fixed-strings "stdenvNoCC.is" "stdenvNoCC.hostPlatform.is"
fd --type f "\.nix" | xargs sd --fixed-strings "inherit (stdenv) is" "inherit (stdenv.hostPlatform) is"
fd --type f "\.nix" | xargs sd --fixed-strings "buildStdenv.is" "buildStdenv.hostPlatform.is"
fd --type f "\.nix" | xargs sd --fixed-strings "effectiveStdenv.is" "effectiveStdenv.hostPlatform.is"
fd --type f "\.nix" | xargs sd --fixed-strings "originalStdenv.is" "originalStdenv.hostPlatform.is"
```
Without the change `wesnoth` fails to build against `gcc-13` as:
$ nix build --impure --expr 'with import <nixpkgs> {}; wesnoth.override { stdenv = gcc13Stdenv; }' -L
In file included from /build/source/src/serialization/base64.cpp:16:
/build/source/src/serialization/base64.hpp:23:49: error: 'uint8_t' was not declared in this scope
23 | using byte_string_view = std::basic_string_view<uint8_t>;
| ^~~~~~~
/build/source/src/serialization/base64.hpp:20:1: note: 'uint8_t' is defined in header '<cstdint>'; did you forget to '#include <cstdint>'?
19 | #include <vector>
+++ |+#include <cstdint>
20 |
Semi-automatic update generated by https://github.com/ryantm/nixpkgs-update tools.
This update was made based on information from https://repology.org/metapackage/wesnoth/versions.
These checks were done:
- built on NixOS
- ran ‘/nix/store/rzsmm117p5z6094z5k1ndc1v9pzms2gn-wesnoth-1.14.1/bin/wesnoth -h’ got 0 exit code
- ran ‘/nix/store/rzsmm117p5z6094z5k1ndc1v9pzms2gn-wesnoth-1.14.1/bin/wesnoth --help’ got 0 exit code
- ran ‘/nix/store/rzsmm117p5z6094z5k1ndc1v9pzms2gn-wesnoth-1.14.1/bin/wesnothd -h’ got 0 exit code
- ran ‘/nix/store/rzsmm117p5z6094z5k1ndc1v9pzms2gn-wesnoth-1.14.1/bin/wesnothd --help’ got 0 exit code
- ran ‘/nix/store/rzsmm117p5z6094z5k1ndc1v9pzms2gn-wesnoth-1.14.1/bin/wesnothd -V’ and found version 1.14.1
- ran ‘/nix/store/rzsmm117p5z6094z5k1ndc1v9pzms2gn-wesnoth-1.14.1/bin/wesnothd --version’ and found version 1.14.1
- found 1.14.1 with grep in /nix/store/rzsmm117p5z6094z5k1ndc1v9pzms2gn-wesnoth-1.14.1
- directory tree listing: https://gist.github.com/8868591a076d925d789cd1cfb562344c
Semi-automatic update generated by https://github.com/ryantm/nixpkgs-update tools.
This update was made based on information from https://repology.org/metapackage/wesnoth/versions.
These checks were done:
- built on NixOS
- ran ‘/nix/store/kk2lcjayzj584gczvzmqbna8gc59g92j-wesnoth-1.14.0/bin/wesnoth -h’ got 0 exit code
- ran ‘/nix/store/kk2lcjayzj584gczvzmqbna8gc59g92j-wesnoth-1.14.0/bin/wesnoth --help’ got 0 exit code
- ran ‘/nix/store/kk2lcjayzj584gczvzmqbna8gc59g92j-wesnoth-1.14.0/bin/wesnothd -h’ got 0 exit code
- ran ‘/nix/store/kk2lcjayzj584gczvzmqbna8gc59g92j-wesnoth-1.14.0/bin/wesnothd --help’ got 0 exit code
- ran ‘/nix/store/kk2lcjayzj584gczvzmqbna8gc59g92j-wesnoth-1.14.0/bin/wesnothd -V’ and found version 1.14.0
- ran ‘/nix/store/kk2lcjayzj584gczvzmqbna8gc59g92j-wesnoth-1.14.0/bin/wesnothd --version’ and found version 1.14.0
- found 1.14.0 with grep in /nix/store/kk2lcjayzj584gczvzmqbna8gc59g92j-wesnoth-1.14.0
- directory tree listing: https://gist.github.com/faf1d8fe4a47781eb51e8a411a546099
* pkgs: refactor needless quoting of homepage meta attribute
A lot of packages are needlessly quoting the homepage meta attribute
(about 1400, 22%), this commit refactors all of those instances.
* pkgs: Fixing some links that were wrongfully unquoted in the previous
commit
* Fixed some instances
