From 2f76d065e1692ff1563c1c21c81ab9b400edd6b6 Mon Sep 17 00:00:00 2001 From: Austin Seipp Date: Sat, 16 Nov 2024 16:20:13 -0600 Subject: [PATCH] jujutsu: skip a flaky test A user reported that there was nothing available in the binary cache for `aarch64-linux` for the latest release, and some investigation turned up that the runners ran into a flaky test that was fixed recently. For simplicity (and so that we don't have to backport the upstream patch), skip this test. The feature works perfectly fine, it is only the test itself that is buggy. This should be removed next month after the 0.24.0 release. Signed-off-by: Austin Seipp (cherry picked from commit 9799fcd3ed58ee33f3be7385ed22d7009034a4a3) --- pkgs/by-name/ju/jujutsu/package.nix | 8 ++++++++ 1 file changed, 8 insertions(+) diff --git a/pkgs/by-name/ju/jujutsu/package.nix b/pkgs/by-name/ju/jujutsu/package.nix index 6e9a9f534e26..7c9d024cecd3 100644 --- a/pkgs/by-name/ju/jujutsu/package.nix +++ b/pkgs/by-name/ju/jujutsu/package.nix @@ -77,6 +77,14 @@ rustPlatform.buildRustPackage { "jj-cli" ]; + checkFlags = [ + # flaky test fixed upstream in 0.24+; the actual feature works reliably, + # it's just a false caching issue inside the test. skip it to allow the + # binary cache to be populated. https://github.com/martinvonz/jj/issues/4784 + "--skip" + "test_shallow_commits_lack_parents" + ]; + env = { # Disable vendored libraries. ZSTD_SYS_USE_PKG_CONFIG = "1";