From f28cc72d5d3d2d82f0fcd343910dfd852d203093 Mon Sep 17 00:00:00 2001 From: Emily Date: Mon, 28 Oct 2024 15:47:57 +0000 Subject: [PATCH] release-lib: build packages without `meta.platforms` on all platforms MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit This was added in to ensure that packages that previously weren’t building at all would get at least one platform’s worth of coverage. However, since most `runCommand` calls don’t explicitly set any `meta` information, this meant that things like `tests.makeWrapper` were only being run for `x86_64-linux`. Since most trivial builder calls should work on all platforms, it doesn’t make much sense for them to be restricted in this way, and we shouldn’t unnecessarily penalize other platforms by treating an empty `meta.platforms` inconsistently with `check-meta`’s maximally‐permissive interpretation. Actual packages that only work on a subset of platforms should, of course, set `meta.platforms` explicitly. --- pkgs/top-level/release-lib.nix | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/pkgs/top-level/release-lib.nix b/pkgs/top-level/release-lib.nix index e27b65dbd49a..41221f8b89f3 100644 --- a/pkgs/top-level/release-lib.nix +++ b/pkgs/top-level/release-lib.nix @@ -169,7 +169,7 @@ let if isDerivation value then value.meta.hydraPlatforms or (subtractLists (value.meta.badPlatforms or []) - (value.meta.platforms or [ "x86_64-linux" ])) + (value.meta.platforms or supportedSystems)) else if value.recurseForDerivations or false || value.recurseForRelease or false then packagePlatforms value else