nordic-dev.net/nixpkgs
nordic-dev.net/nixpkgs
2
0
Fork 0
mirror of https://github.com/NixOS/nixpkgs.git synced 2024-11-22 15:03:28 +00:00
Code Issues Packages Projects Releases Wiki Activity

check-by-name: remove concurrency group

Browse Source 
Due to the trigger on PR edit, every change to the PR body will trigger
a re-run of the check-by-name workflow. This is needed to catch of the
base branch. However, an action like ticking the checkbox of a PR will
also trigger a re-run. Furthermore, due to the concurrency group, any
already running check-by-name workflow will be canceled, leading to
a notification sent to the PR author.

To reduce the noise, remove the concurrency group. As a consequence,
multiple runs will run to completion on the same PR/commit. While
concurrent runs are often canceled after a few seconds, the workflow
will take about a minute to complete.

Signed-off-by: Paul Meyer <49727155+katexochen@users.noreply.github.com>
This commit is contained in:
Paul Meyer 2024-05-21 10:38:47 +02:00
parent 718b237d0b
commit d87803b742
1 changed files with 6 additions and 6 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

12
.github/workflows/check-by-name.yml vendored
View File

@ -14,16 +14,16 @@ on:
# While `edited` is also triggered when the PR title/body is changed, # While `edited` is also triggered when the PR title/body is changed,
# this PR action is fairly quick, and PR's don't get edited that often, # this PR action is fairly quick, and PR's don't get edited that often,
# so it shouldn't be a problem # so it shouldn't be a problem
# There is a feature request for adding a `base_changed` event:
# https://github.com/orgs/community/discussions/35058
types: [opened, synchronize, reopened, edited] types: [opened, synchronize, reopened, edited]
permissions: {} permissions: {}
# Create a check-by-name concurrency group based on the pull request number. if # We don't use a concurrency group here, because the action is triggered quite often (due to the PR edit
# an event triggers a run on the same PR while a previous run is still in # trigger), and contributers would get notified on any canceled run.
# progress, the previous run will be canceled and the new one will start. # There is a feature request for supressing notifications on concurrency-canceled runs:
concurrency: # https://github.com/orgs/community/discussions/13015
group: check-by-name-${{ github.event.pull_request.number }}
cancel-in-progress: true
jobs: jobs:
check: check: