From cf4c0f090fe55e3018164a15d81dd0a374dfd43c Mon Sep 17 00:00:00 2001 From: natsukium Date: Thu, 3 Aug 2023 22:46:46 +0900 Subject: [PATCH] python310Packages.laszip: refactor - remove unused inputs - move pybind11 to nativeBuildInputs - set dontUseCmakeConfigure - add meta.changelog --- .../python-modules/laszip/default.nix | 24 +++++++------------ 1 file changed, 9 insertions(+), 15 deletions(-) diff --git a/pkgs/development/python-modules/laszip/default.nix b/pkgs/development/python-modules/laszip/default.nix index cefd2d5f6e1a..94c1dad59145 100644 --- a/pkgs/development/python-modules/laszip/default.nix +++ b/pkgs/development/python-modules/laszip/default.nix @@ -2,13 +2,10 @@ , buildPythonPackage , fetchFromGitHub , scikit-build-core -, distlib -, pytestCheckHook -, pyproject-metadata -, pathspec , pybind11 , cmake , LASzip +, pythonOlder }: buildPythonPackage rec { @@ -17,32 +14,28 @@ buildPythonPackage rec { format = "pyproject"; + disabled = pythonOlder "3.7"; + src = fetchFromGitHub { owner = "tmontaigu"; repo = pname; rev = version; - sha256 = "sha256-ujKoUm2Btu25T7ZrSGqjRc3NR1qqsQU8OwHQDSx8grY="; + hash = "sha256-ujKoUm2Btu25T7ZrSGqjRc3NR1qqsQU8OwHQDSx8grY="; }; nativeBuildInputs = [ + cmake + pybind11 scikit-build-core scikit-build-core.optional-dependencies.pyproject - cmake ]; + dontUseCmakeConfigure = true; + buildInputs = [ - pybind11 LASzip ]; - checkInputs = [ - pytestCheckHook - ]; - - preBuild = '' - cd .. - ''; - # There are no tests doCheck = false; @@ -51,6 +44,7 @@ buildPythonPackage rec { meta = with lib; { description = "Unofficial bindings between Python and LASzip made using pybind11"; homepage = "https://github.com/tmontaigu/laszip-python"; + changelog = "https://github.com/tmontaigu/laszip-python/blob/${src.rev}/Changelog.md"; license = licenses.mit; maintainers = with maintainers; [ matthewcroughan ]; };