mirror of
https://github.com/NixOS/nixpkgs.git
synced 2024-11-21 22:43:01 +00:00
nixos/README.md: add guideline to link to nixos tests from packages
This commit is contained in:
parent
8f8f1702ef
commit
c7f9378f34
@ -80,6 +80,7 @@ Reviewing process:
|
||||
|
||||
- Ensure that all file paths [fit the guidelines](../CONTRIBUTING.md#file-naming-and-organisation).
|
||||
- Ensure that the module tests, if any, are succeeding.
|
||||
- Ensure that new module tests are added to the package `passthru.tests`.
|
||||
- Ensure that the introduced options are correct.
|
||||
- Type should be appropriate (string related types differs in their merging capabilities, `loaOf` and `string` types are deprecated).
|
||||
- Description, default and example should be provided.
|
||||
@ -95,7 +96,8 @@ Sample template for a new module review is provided below.
|
||||
##### Reviewed points
|
||||
|
||||
- [ ] module path fits the guidelines
|
||||
- [ ] module tests succeed on ARCHITECTURE
|
||||
- [ ] module tests, if any, succeed on ARCHITECTURE
|
||||
- [ ] module tests, if any, are added to package `passthru.tests`
|
||||
- [ ] options have appropriate types
|
||||
- [ ] options have default
|
||||
- [ ] options have example
|
||||
|
Loading…
Reference in New Issue
Block a user