From c483f199f73d46ae697923a77fd01551774ca004 Mon Sep 17 00:00:00 2001 From: Anderson Torres Date: Sat, 19 Aug 2023 00:28:58 -0300 Subject: [PATCH] CONTRIBUTING: remove suggestion about the order of arguments Particularities about style should be enforced at the tooling level (linters, code beautifiers etc.). Otherwise, it adds more weight on the PR reviewing, distracting both authors and reviewers from the substance of the changes. --- CONTRIBUTING.md | 2 -- 1 file changed, 2 deletions(-) diff --git a/CONTRIBUTING.md b/CONTRIBUTING.md index bb666850ae8b..2d3f274847de 100644 --- a/CONTRIBUTING.md +++ b/CONTRIBUTING.md @@ -749,5 +749,3 @@ Names of files and directories should be in lowercase, with dashes between words As an exception, an explicit conditional expression with null can be used when fixing a important bug without triggering a mass rebuild. If this is done a follow up pull request _should_ be created to change the code to `lib.optional(s)`. - -- Arguments should be listed in the order they are used, with the exception of `lib`, which always goes first.