From c2fb4222a84352226dcf796fe487aff5f6ccfc4f Mon Sep 17 00:00:00 2001 From: Zhaofeng Li Date: Tue, 19 Oct 2021 17:57:07 -0700 Subject: [PATCH] pythonPackages.construct: Remove pytest-benchmark check dependency No need to pull it in at all when the benchmarks are skipped anyways. --- pkgs/development/python-modules/construct/2.10.54.nix | 5 ++--- pkgs/development/python-modules/construct/default.nix | 6 ++---- 2 files changed, 4 insertions(+), 7 deletions(-) diff --git a/pkgs/development/python-modules/construct/2.10.54.nix b/pkgs/development/python-modules/construct/2.10.54.nix index 6cfca7260512..5bbbd1501453 100644 --- a/pkgs/development/python-modules/construct/2.10.54.nix +++ b/pkgs/development/python-modules/construct/2.10.54.nix @@ -14,7 +14,7 @@ buildPythonPackage rec { sha256 = "1mqspsn6bf3ibvih1zna2glkg8iw7vy5zg9gzg0d1m8zcndk2c48"; }; - checkInputs = [ pytestCheckHook pytest-benchmark enum34 numpy ]; + checkInputs = [ pytestCheckHook enum34 numpy ]; # these have dependencies that are broken on Python 2 disabledTestPaths = [ @@ -24,13 +24,12 @@ buildPythonPackage rec { ]; disabledTests = [ + "test_benchmarks" "test_timestamp" ] ++ lib.optionals stdenv.isDarwin [ "test_multiprocessing" ]; - pytestFlagsArray = [ "--benchmark-disable" ]; - meta = with lib; { description = "Powerful declarative parser (and builder) for binary data"; homepage = "https://construct.readthedocs.org/"; diff --git a/pkgs/development/python-modules/construct/default.nix b/pkgs/development/python-modules/construct/default.nix index b2783fa09346..8ae44476eff4 100644 --- a/pkgs/development/python-modules/construct/default.nix +++ b/pkgs/development/python-modules/construct/default.nix @@ -22,11 +22,9 @@ buildPythonPackage rec { lz4 ]; - checkInputs = [ pytestCheckHook pytest-benchmark numpy arrow ruamel-yaml cloudpickle ]; + checkInputs = [ pytestCheckHook numpy arrow ruamel-yaml cloudpickle ]; - disabledTests = lib.optionals stdenv.isDarwin [ "test_multiprocessing" ]; - - pytestFlagsArray = [ "--benchmark-disable" ]; + disabledTests = [ "test_benchmarks" ] ++ lib.optionals stdenv.isDarwin [ "test_multiprocessing" ]; meta = with lib; { description = "Powerful declarative parser (and builder) for binary data";