From f7393d13fe676bc74cc015838a248493439a9041 Mon Sep 17 00:00:00 2001 From: Sarah Brofeldt Date: Mon, 3 Jun 2024 09:51:19 +0200 Subject: [PATCH] nixos/garage: fix replication 1.0 assertion Use the `cfg.package.version` (string) instead of the entire package so users don't see `error: value is a set while a string was expected` instead of the intended assertion message. --- nixos/modules/services/web-servers/garage.nix | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/nixos/modules/services/web-servers/garage.nix b/nixos/modules/services/web-servers/garage.nix index 8d1966aee091..7cf71ff6ff06 100644 --- a/nixos/modules/services/web-servers/garage.nix +++ b/nixos/modules/services/web-servers/garage.nix @@ -83,7 +83,7 @@ in # These assertions can be removed in NixOS 24.11, when all users have been # warned once. { - assertion = (cfg.settings ? replication_factor || cfg.settings ? replication_mode) || lib.versionOlder cfg.package "1.0.0"; + assertion = (cfg.settings ? replication_factor || cfg.settings ? replication_mode) || lib.versionOlder cfg.package.version "1.0.0"; message = '' Garage 1.0.0 requires an explicit replication factor to be set. Please set replication_factor to 1 explicitly to preserve the previous behavior.