From c133b42520052b01e622af669fb2bdb8457a9570 Mon Sep 17 00:00:00 2001
From: Gaetan Lepage <gaetan@glepage.com>
Date: Tue, 3 Sep 2024 08:42:48 +0200
Subject: [PATCH] python312Packages.qtconsole: 5.5.2 -> 5.6.0

Changelog:
https://qtconsole.readthedocs.io/en/stable/changelog.html#changes-in-jupyter-qt-console
---
 .../python-modules/qtconsole/default.nix      | 34 +++++++++++--------
 1 file changed, 19 insertions(+), 15 deletions(-)

diff --git a/pkgs/development/python-modules/qtconsole/default.nix b/pkgs/development/python-modules/qtconsole/default.nix
index b8e1280ceb3d..aa92c94c7476 100644
--- a/pkgs/development/python-modules/qtconsole/default.nix
+++ b/pkgs/development/python-modules/qtconsole/default.nix
@@ -1,30 +1,34 @@
 {
   lib,
   buildPythonPackage,
-  fetchPypi,
+  fetchFromGitHub,
+
+  # build-system
+  setuptools,
+
+  # dependencies
   ipykernel,
   jupyter-core,
   jupyter-client,
   pygments,
   pyqt5,
-  pytestCheckHook,
-  pythonOlder,
-  pyzmq,
   qtpy,
-  setuptools,
   traitlets,
+
+  # tests
+  pytestCheckHook,
 }:
 
 buildPythonPackage rec {
   pname = "qtconsole";
-  version = "5.5.2";
+  version = "5.6.0";
   pyproject = true;
 
-  disabled = pythonOlder "3.7";
-
-  src = fetchPypi {
-    inherit pname version;
-    hash = "sha256-a1+xEnSyl0Y3Bq+E3LvVySJzsfYZ5tJdCIdLCohRaYk=";
+  src = fetchFromGitHub {
+    owner = "jupyter";
+    repo = "qtconsole";
+    rev = "refs/tags/${version}";
+    hash = "sha256-V82tGAmpvfGeUoewtJXXsBBXx2HNcV9/IMJxJg3bJL8=";
   };
 
   build-system = [ setuptools ];
@@ -35,7 +39,6 @@ buildPythonPackage rec {
     jupyter-client
     pygments
     pyqt5
-    pyzmq
     qtpy
     traitlets
   ];
@@ -47,11 +50,12 @@ buildPythonPackage rec {
 
   pythonImportsCheck = [ "qtconsole" ];
 
-  meta = with lib; {
+  meta = {
     description = "Jupyter Qt console";
     mainProgram = "jupyter-qtconsole";
     homepage = "https://qtconsole.readthedocs.io/";
-    license = licenses.bsd3;
-    platforms = platforms.unix;
+    changelog = "https://qtconsole.readthedocs.io/en/stable/changelog.html#changes-in-jupyter-qt-console";
+    license = lib.licenses.bsd3;
+    platforms = lib.platforms.unix;
   };
 }