From a599c197613822a76b6272fb30593a9b74a24fbe Mon Sep 17 00:00:00 2001 From: Daniel Silverstone Date: Wed, 28 Apr 2021 20:41:30 +0100 Subject: [PATCH 1/3] vscode-extensions.ms-python.python: 2020.9.114305 -> 2021.4.765268190 This splits off part of the Python extension into Microsoft's jupyter extension, so this is necessary but not sufficient. Signed-off-by: Daniel Silverstone --- pkgs/misc/vscode-extensions/python/default.nix | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/pkgs/misc/vscode-extensions/python/default.nix b/pkgs/misc/vscode-extensions/python/default.nix index 1d86f82d278f..e9e4b9f0cfc3 100644 --- a/pkgs/misc/vscode-extensions/python/default.nix +++ b/pkgs/misc/vscode-extensions/python/default.nix @@ -41,13 +41,13 @@ in vscode-utils.buildVscodeMarketplaceExtension rec { mktplcRef = { name = "python"; publisher = "ms-python"; - version = "2020.9.114305"; + version = "2021.4.765268190"; }; vsix = fetchurl { name = "${mktplcRef.publisher}-${mktplcRef.name}.zip"; url = "https://github.com/microsoft/vscode-python/releases/download/${mktplcRef.version}/ms-python-release.vsix"; - sha256 = "1vh0wvfvzszc58lw7dbl60knpm5l6rrsghfchhn5dvwyadx4a33h"; + sha256 = "0x7dn3vc83mph2gaxgx26bn7g71hqdpp1mpizmd4jqcrknc4d7ci"; }; buildInputs = [ From 5903b963f40aa1079385ce12337db8355bdb1f9f Mon Sep 17 00:00:00 2001 From: Daniel Silverstone Date: Wed, 28 Apr 2021 20:42:44 +0100 Subject: [PATCH 2/3] vscode-extensions.ms-toolsai.jupyter: init at 2021.5.745244803 This is a necessary dependency of the new Python extension for VSCode. Signed-off-by: Daniel Silverstone --- pkgs/misc/vscode-extensions/default.nix | 12 ++++++++++++ 1 file changed, 12 insertions(+) diff --git a/pkgs/misc/vscode-extensions/default.nix b/pkgs/misc/vscode-extensions/default.nix index 15d280c07501..a3a2e8dbd068 100644 --- a/pkgs/misc/vscode-extensions/default.nix +++ b/pkgs/misc/vscode-extensions/default.nix @@ -718,6 +718,18 @@ let }; }; + ms-toolsai.jupyter = buildVscodeMarketplaceExtension { + mktplcRef = { + name = "jupyter"; + publisher = "ms-toolsai"; + version = "2021.5.745244803"; + sha256 = "0gjpsp61l8daqa87mpmxcrvsvb0pc2vwg7xbkvwn0f13c1739w9p"; + }; + meta = { + license = lib.licenses.unfree; + }; + }; + naumovs.color-highlight = buildVscodeMarketplaceExtension { mktplcRef = { name = "color-highlight"; From b71773ee0762dd3b4b6a946d670c7d72cfd0e3cd Mon Sep 17 00:00:00 2001 From: Daniel Silverstone Date: Wed, 28 Apr 2021 20:53:53 +0100 Subject: [PATCH 3/3] vscode-extensions.ms-python.python: refactor In order for the ms-python.python extension to work these days, we also need the ms-toolsai.jupyter extension. To permit easy upgrades and to honour the principle of least surprise, we wrapper the Python extension to include the Jupyter one. The reverse is not true, you *can* have the Jupyter extension without the Python one, so the reverse is not also done. Signed-off-by: Daniel Silverstone --- pkgs/misc/vscode-extensions/default.nix | 14 ++++++++++---- 1 file changed, 10 insertions(+), 4 deletions(-) diff --git a/pkgs/misc/vscode-extensions/default.nix b/pkgs/misc/vscode-extensions/default.nix index a3a2e8dbd068..204da6563109 100644 --- a/pkgs/misc/vscode-extensions/default.nix +++ b/pkgs/misc/vscode-extensions/default.nix @@ -1,4 +1,4 @@ -{ config, lib, callPackage, vscode-utils, nodePackages, jdk, llvmPackages_8 }: +{ config, lib, buildEnv, callPackage, vscode-utils, nodePackages, jdk, llvmPackages_8 }: let inherit (vscode-utils) buildVscodeMarketplaceExtension; @@ -702,9 +702,15 @@ let ms-vscode-remote.remote-ssh = callPackage ./remote-ssh {}; - ms-python.python = callPackage ./python { - extractNuGet = callPackage ./python/extract-nuget.nix { }; - }; + ms-python.python = let + raw-package = callPackage ./python { + extractNuGet = callPackage ./python/extract-nuget.nix { }; + }; + in + buildEnv { + name = "vscode-extension-ms-python-python-full"; + paths = [ raw-package self.ms-toolsai.jupyter ]; + }; msjsdiag.debugger-for-chrome = buildVscodeMarketplaceExtension { mktplcRef = {