From 290ec4fd63387278fd2adfca9be8c4058da9ec7b Mon Sep 17 00:00:00 2001 From: natsukium Date: Wed, 15 Nov 2023 01:26:29 +0900 Subject: [PATCH 1/2] python311Packages.python-fedora: rename from python_fedora --- .../python-modules/{python_fedora => python-fedora}/default.nix | 0 pkgs/top-level/python-aliases.nix | 1 + pkgs/top-level/python-packages.nix | 2 +- 3 files changed, 2 insertions(+), 1 deletion(-) rename pkgs/development/python-modules/{python_fedora => python-fedora}/default.nix (100%) diff --git a/pkgs/development/python-modules/python_fedora/default.nix b/pkgs/development/python-modules/python-fedora/default.nix similarity index 100% rename from pkgs/development/python-modules/python_fedora/default.nix rename to pkgs/development/python-modules/python-fedora/default.nix diff --git a/pkgs/top-level/python-aliases.nix b/pkgs/top-level/python-aliases.nix index 24ffa5b35136..59a48d189d9d 100644 --- a/pkgs/top-level/python-aliases.nix +++ b/pkgs/top-level/python-aliases.nix @@ -349,6 +349,7 @@ mapAliases ({ python-forecastio = throw "python-forecastio has been removed, as the Dark Sky service was shut down."; # added 2023-04-05 python-igraph = igraph; # added 2021-11-11 python_docs_theme = python-docs-theme; # added 2023-11-04 + python_fedora = python-fedora; # added 2023-11-15 python_keyczar = throw "python_keyczar has been removed because it's been archived upstream and deprecated"; # added 2023-05-16 python-lz4 = lz4; # added 2018-06-01 python_magic = python-magic; # added 2022-05-07 diff --git a/pkgs/top-level/python-packages.nix b/pkgs/top-level/python-packages.nix index 922e5a1b792e..df65b98e2bb5 100644 --- a/pkgs/top-level/python-packages.nix +++ b/pkgs/top-level/python-packages.nix @@ -11424,7 +11424,7 @@ self: super: with self; { python-ev3dev2 = callPackage ../development/python-modules/python-ev3dev2 { }; - python_fedora = callPackage ../development/python-modules/python_fedora { }; + python-fedora = callPackage ../development/python-modules/python-fedora { }; python-fontconfig = callPackage ../development/python-modules/python-fontconfig { }; From 2cca81b2adcc1541410e7e56756186fcb6a0c4e4 Mon Sep 17 00:00:00 2001 From: natsukium Date: Wed, 15 Nov 2023 01:38:05 +0900 Subject: [PATCH 2/2] python311Packages.python-fedora: refactor - adopt pypa build - remove unnecessary inputs - enable tests - fix meta.changelog --- .../python-modules/python-fedora/default.nix | 25 +++++++++++++------ 1 file changed, 18 insertions(+), 7 deletions(-) diff --git a/pkgs/development/python-modules/python-fedora/default.nix b/pkgs/development/python-modules/python-fedora/default.nix index 7f4e6e2a4fd5..01c79c39ea1c 100644 --- a/pkgs/development/python-modules/python-fedora/default.nix +++ b/pkgs/development/python-modules/python-fedora/default.nix @@ -1,15 +1,16 @@ { lib , beautifulsoup4 , buildPythonPackage -, bunch , fetchPypi , kitchen , lockfile , munch +, nose , openidc-client -, paver +, pytestCheckHook , pythonOlder , requests +, setuptools , six , urllib3 }: @@ -17,7 +18,7 @@ buildPythonPackage rec { pname = "python-fedora"; version = "1.1.1"; - format = "setuptools"; + pyproject = true; disabled = pythonOlder "3.7"; @@ -26,20 +27,30 @@ buildPythonPackage rec { hash = "sha256-VrnYQaObQDDjiOkMe3fazUefHOXi/5sYw5VNl9Vwmhk="; }; + nativeBuildInputs = [ + setuptools + ]; + propagatedBuildInputs = [ beautifulsoup4 - bunch kitchen lockfile munch openidc-client - paver requests six urllib3 ]; - doCheck = false; + nativeCheckInputs = [ + pytestCheckHook + nose + ]; + + disabledTestPaths = [ + # requires network access + "tests/functional/test_openidbaseclient.py" + ]; pythonImportsCheck = [ "fedora" @@ -48,7 +59,7 @@ buildPythonPackage rec { meta = with lib; { description = "Module to interact with the infrastructure of the Fedora Project"; homepage = "https://github.com/fedora-infra/python-fedora"; - changelog = "https://github.com/fedora-infra/python-fedora/releases/tag/1.1.1"; + changelog = "https://github.com/fedora-infra/python-fedora/releases/tag/${version}"; license = licenses.lgpl21Plus; maintainers = with maintainers; [ ]; };