From 4bfca03fcb785eec4863a74da7bdd9c7c296cd5c Mon Sep 17 00:00:00 2001 From: seth Date: Mon, 15 Jul 2024 14:04:45 -0400 Subject: [PATCH 1/4] shellcheck-sarif: 0.4.2 -> 0.5.0 Diff: https://github.com/psastras/sarif-rs/compare/shellcheck-sarif-v0.4.2...shellcheck-sarif-v0.5.0 --- pkgs/by-name/sh/shellcheck-sarif/package.nix | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/pkgs/by-name/sh/shellcheck-sarif/package.nix b/pkgs/by-name/sh/shellcheck-sarif/package.nix index f5614143bd8f..63f9ca933c59 100644 --- a/pkgs/by-name/sh/shellcheck-sarif/package.nix +++ b/pkgs/by-name/sh/shellcheck-sarif/package.nix @@ -7,16 +7,16 @@ }: rustPlatform.buildRustPackage rec { pname = "shellcheck-sarif"; - version = "0.4.2"; + version = "0.5.0"; src = fetchFromGitHub { owner = "psastras"; repo = "sarif-rs"; rev = "shellcheck-sarif-v${version}"; - hash = "sha256-EzWzDeIeSJ11CVcVyAhMjYQJcKHnieRrFkULc5eXAno="; + hash = "sha256-RnoJfmkrqdhOioGkB7rTzHQ3kx9vIRfWDJN30/8JAvM="; }; - cargoHash = "sha256-JuE/Z0qrS/3BRlb0jTGDfV0TYk74Q75X1wv/IERxqeQ="; + cargoHash = "sha256-HiZt3AxFMqIpRkg0TFpm8GDFCX6zYWTllO+xtVj7fjY="; cargoBuildFlags = [ "--package" "shellcheck-sarif" From 6dc9daef05be0d5e98f56aee01400da92e581c05 Mon Sep 17 00:00:00 2001 From: seth Date: Mon, 15 Jul 2024 14:20:34 -0400 Subject: [PATCH 2/4] shellcheck-sarif: fetchFromGitHub -> fetchCrate this makes things much easier to build as we don't need to account for the monorepo --- pkgs/by-name/sh/shellcheck-sarif/package.nix | 17 +++++------------ 1 file changed, 5 insertions(+), 12 deletions(-) diff --git a/pkgs/by-name/sh/shellcheck-sarif/package.nix b/pkgs/by-name/sh/shellcheck-sarif/package.nix index 63f9ca933c59..245c1c7b9efe 100644 --- a/pkgs/by-name/sh/shellcheck-sarif/package.nix +++ b/pkgs/by-name/sh/shellcheck-sarif/package.nix @@ -1,6 +1,6 @@ { lib, - fetchFromGitHub, + fetchCrate, rustPlatform, shellcheck-sarif, testers, @@ -9,19 +9,12 @@ rustPlatform.buildRustPackage rec { pname = "shellcheck-sarif"; version = "0.5.0"; - src = fetchFromGitHub { - owner = "psastras"; - repo = "sarif-rs"; - rev = "shellcheck-sarif-v${version}"; - hash = "sha256-RnoJfmkrqdhOioGkB7rTzHQ3kx9vIRfWDJN30/8JAvM="; + src = fetchCrate { + inherit pname version; + hash = "sha256-PFMakiV9vXzMqVh1WeVTDwGpN7RVfFQlVWKkaD6ef+Q="; }; - cargoHash = "sha256-HiZt3AxFMqIpRkg0TFpm8GDFCX6zYWTllO+xtVj7fjY="; - cargoBuildFlags = [ - "--package" - "shellcheck-sarif" - ]; - cargoTestFlags = cargoBuildFlags; + cargoHash = "sha256-kkSTRoouuIh4Bsh+zqhtTwIGLxDE+3u8SuP+8i+lw5Q="; passthru = { tests.version = testers.testVersion { package = shellcheck-sarif; }; From e52dcd90a446082c63b2df97e2986cebb625871a Mon Sep 17 00:00:00 2001 From: seth Date: Mon, 15 Jul 2024 14:22:23 -0400 Subject: [PATCH 3/4] shellcheck-sarif: testers.testVersion -> versionCheckHook this results in less ugly recursion --- pkgs/by-name/sh/shellcheck-sarif/package.nix | 8 +++----- 1 file changed, 3 insertions(+), 5 deletions(-) diff --git a/pkgs/by-name/sh/shellcheck-sarif/package.nix b/pkgs/by-name/sh/shellcheck-sarif/package.nix index 245c1c7b9efe..1a3e8ef4a358 100644 --- a/pkgs/by-name/sh/shellcheck-sarif/package.nix +++ b/pkgs/by-name/sh/shellcheck-sarif/package.nix @@ -2,8 +2,7 @@ lib, fetchCrate, rustPlatform, - shellcheck-sarif, - testers, + versionCheckHook, }: rustPlatform.buildRustPackage rec { pname = "shellcheck-sarif"; @@ -16,9 +15,8 @@ rustPlatform.buildRustPackage rec { cargoHash = "sha256-kkSTRoouuIh4Bsh+zqhtTwIGLxDE+3u8SuP+8i+lw5Q="; - passthru = { - tests.version = testers.testVersion { package = shellcheck-sarif; }; - }; + nativeInstallCheckInputs = [ versionCheckHook ]; + doInstallCheck = true; meta = { description = "CLI tool to convert shellcheck diagnostics into SARIF"; From 0734b8fa1c5aadfe78b0762d0cc61e2e8f486922 Mon Sep 17 00:00:00 2001 From: seth Date: Mon, 15 Jul 2024 14:23:56 -0400 Subject: [PATCH 4/4] shellcheck-sarif: add updateScript --- pkgs/by-name/sh/shellcheck-sarif/package.nix | 9 +++++++-- 1 file changed, 7 insertions(+), 2 deletions(-) diff --git a/pkgs/by-name/sh/shellcheck-sarif/package.nix b/pkgs/by-name/sh/shellcheck-sarif/package.nix index 1a3e8ef4a358..20d157f7efe7 100644 --- a/pkgs/by-name/sh/shellcheck-sarif/package.nix +++ b/pkgs/by-name/sh/shellcheck-sarif/package.nix @@ -2,6 +2,7 @@ lib, fetchCrate, rustPlatform, + nix-update-script, versionCheckHook, }: rustPlatform.buildRustPackage rec { @@ -18,11 +19,15 @@ rustPlatform.buildRustPackage rec { nativeInstallCheckInputs = [ versionCheckHook ]; doInstallCheck = true; + passthru = { + updateScript = nix-update-script { }; + }; + meta = { description = "CLI tool to convert shellcheck diagnostics into SARIF"; homepage = "https://psastras.github.io/sarif-rs"; - mainProgram = "shellcheck-sarif"; - maintainers = with lib.maintainers; [ getchoo ]; license = lib.licenses.mit; + maintainers = with lib.maintainers; [ getchoo ]; + mainProgram = "shellcheck-sarif"; }; }