mirror of
https://github.com/NixOS/nixpkgs.git
synced 2024-11-24 16:03:23 +00:00
chromiumDev: Fix two build errors
Python 3 is now required (hard-coded in some scripts, but other scripts still require Python 2) and a patch is required for [0]. [0]: https://bugs.chromium.org/p/chromium/issues/detail?id=1192875
This commit is contained in:
parent
650553aa9b
commit
8c60448e26
@ -7,7 +7,7 @@
|
|||||||
, xdg-utils, yasm, nasm, minizip, libwebp
|
, xdg-utils, yasm, nasm, minizip, libwebp
|
||||||
, libusb1, pciutils, nss, re2
|
, libusb1, pciutils, nss, re2
|
||||||
|
|
||||||
, python2Packages, perl, pkg-config
|
, python2Packages, python3Packages, perl, pkg-config
|
||||||
, nspr, systemd, libkrb5
|
, nspr, systemd, libkrb5
|
||||||
, util-linux, alsaLib
|
, util-linux, alsaLib
|
||||||
, bison, gperf
|
, bison, gperf
|
||||||
@ -130,6 +130,8 @@ let
|
|||||||
ninja which python2Packages.python perl pkg-config
|
ninja which python2Packages.python perl pkg-config
|
||||||
python2Packages.ply python2Packages.jinja2 nodejs
|
python2Packages.ply python2Packages.jinja2 nodejs
|
||||||
gnutar python2Packages.setuptools
|
gnutar python2Packages.setuptools
|
||||||
|
] ++ optionals (chromiumVersionAtLeast "91") [
|
||||||
|
python3Packages.python
|
||||||
];
|
];
|
||||||
|
|
||||||
buildInputs = defaultDependencies ++ [
|
buildInputs = defaultDependencies ++ [
|
||||||
@ -160,7 +162,9 @@ let
|
|||||||
url = "https://raw.githubusercontent.com/archlinux/svntogit-packages/61b0ab526d2aa3c62fa20bb756461ca9a482f6c6/trunk/chromium-fix-libva-redef.patch";
|
url = "https://raw.githubusercontent.com/archlinux/svntogit-packages/61b0ab526d2aa3c62fa20bb756461ca9a482f6c6/trunk/chromium-fix-libva-redef.patch";
|
||||||
sha256 = "1qj4sn1ngz0p1l1w3346kanr1sqlr3xdzk1f1i86lqa45mhv77ny";
|
sha256 = "1qj4sn1ngz0p1l1w3346kanr1sqlr3xdzk1f1i86lqa45mhv77ny";
|
||||||
}) ++ optional (chromiumVersionAtLeast "90")
|
}) ++ optional (chromiumVersionAtLeast "90")
|
||||||
./fix-missing-atspi2-dependency.patch
|
./patches/fix-missing-atspi2-dependency.patch
|
||||||
|
++ optional (chromiumVersionAtLeast "91")
|
||||||
|
./patches/closure_compiler-Use-the-Java-binary-from-the-system.patch
|
||||||
;
|
;
|
||||||
|
|
||||||
postPatch = ''
|
postPatch = ''
|
||||||
|
@ -0,0 +1,31 @@
|
|||||||
|
From e031b8be0fb2a22f953c034cdf08ca9befe130d2 Mon Sep 17 00:00:00 2001
|
||||||
|
From: Michael Weiss <dev.primeos@gmail.com>
|
||||||
|
Date: Sun, 11 Apr 2021 18:05:12 +0200
|
||||||
|
Subject: [PATCH] closure_compiler: Use the Java binary from the system
|
||||||
|
|
||||||
|
The bundled Java binary (third_party/jdk/current/bin/java) is missing in
|
||||||
|
the tarball and we want to use the one from the system anyway.
|
||||||
|
This reverts part of [0].
|
||||||
|
|
||||||
|
[0]: https://chromium-review.googlesource.com/c/chromium/src/+/2778794
|
||||||
|
---
|
||||||
|
third_party/closure_compiler/compiler.py | 3 +--
|
||||||
|
1 file changed, 1 insertion(+), 2 deletions(-)
|
||||||
|
|
||||||
|
diff --git a/third_party/closure_compiler/compiler.py b/third_party/closure_compiler/compiler.py
|
||||||
|
index 75690ceb9749..7b9c76f74290 100755
|
||||||
|
--- a/third_party/closure_compiler/compiler.py
|
||||||
|
+++ b/third_party/closure_compiler/compiler.py
|
||||||
|
@@ -13,8 +13,7 @@ import subprocess
|
||||||
|
|
||||||
|
|
||||||
|
_CURRENT_DIR = os.path.join(os.path.dirname(__file__))
|
||||||
|
-_JAVA_PATH = os.path.join(_CURRENT_DIR, "..", "jdk", "current", "bin", "java")
|
||||||
|
-assert os.path.isfile(_JAVA_PATH), "java only allowed in android builds"
|
||||||
|
+_JAVA_PATH = "java"
|
||||||
|
|
||||||
|
class Compiler(object):
|
||||||
|
"""Runs the Closure compiler on given source files to typecheck them
|
||||||
|
--
|
||||||
|
2.20.1
|
||||||
|
|
Loading…
Reference in New Issue
Block a user