From 57e3a0d06ccfae37b8c775a5ee31c0bbafc5225e Mon Sep 17 00:00:00 2001 From: aleksana Date: Wed, 10 May 2023 17:27:46 +0800 Subject: [PATCH 1/3] adbfs-rootless: 2016-10-02 -> unstable-2023-03-21 --- .../mobile/adbfs-rootless/default.nix | 33 ++++++++++--------- 1 file changed, 17 insertions(+), 16 deletions(-) diff --git a/pkgs/development/mobile/adbfs-rootless/default.nix b/pkgs/development/mobile/adbfs-rootless/default.nix index 85bf2fb44906..e2712517ee55 100644 --- a/pkgs/development/mobile/adbfs-rootless/default.nix +++ b/pkgs/development/mobile/adbfs-rootless/default.nix @@ -1,35 +1,36 @@ -{ lib, stdenv, fetchFromGitHub, fetchpatch, pkg-config, fuse, adb }: +{ lib +, stdenv +, fetchFromGitHub +, pkg-config +, fuse +, android-tools +}: stdenv.mkDerivation rec { pname = "adbfs-rootless"; - version = "2016-10-02"; + version = "unstable-2023-03-21"; src = fetchFromGitHub { owner = "spion"; - repo = "adbfs-rootless"; - rev = "b58963430e40c9246710a16cec58e7ffc88baa48"; - sha256 = "1kjibl86k6pf7vciwaaxwv5m4q28zdpd2g7yhp71av32jq6j3wm8"; + repo = pname; + rev = "fd56381af4dc9ae2f09b904c295686871a46ed0f"; + sha256 = "atiVjRfqvhTlm8Q+3iTNNPQiNkLIaHDLg5HZDJvpl2Q="; }; - patches = [ - (fetchpatch { - # https://github.com/spion/adbfs-rootless/issues/14 - url = "https://github.com/kronenpj/adbfs-rootless/commit/35f87ce0a7aeddaaad118daed3022e01453b838d.patch"; - sha256 = "1iigla74n3hphnyx9ffli9wqk7v71ylvsxama868czlg7851jqj9"; - }) - ]; - nativeBuildInputs = [ pkg-config ]; + buildInputs = [ fuse ]; postPatch = '' # very ugly way of replacing the adb calls - sed -e 's|"adb |"${adb}/bin/adb |g' \ - -i adbfs.cpp + substituteInPlace adbfs.cpp \ + --replace '"adb ' '"${android-tools}/bin/adb ' ''; installPhase = '' + runHook preInstall install -D adbfs $out/bin/adbfs + runHook postInstall ''; meta = with lib; { @@ -37,6 +38,6 @@ stdenv.mkDerivation rec { inherit (src.meta) homepage; license = licenses.bsd3; maintainers = with maintainers; [ Profpatsch ]; - platforms = platforms.linux; + platforms = platforms.unix; }; } From 80a1a58c2e48b2f611be60439004f4168d1b1522 Mon Sep 17 00:00:00 2001 From: aleksana Date: Wed, 10 May 2023 18:25:31 +0800 Subject: [PATCH 2/3] adbfs-rootless: add aleksana as maintainer --- pkgs/development/mobile/adbfs-rootless/default.nix | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/pkgs/development/mobile/adbfs-rootless/default.nix b/pkgs/development/mobile/adbfs-rootless/default.nix index e2712517ee55..cba73e23fd9c 100644 --- a/pkgs/development/mobile/adbfs-rootless/default.nix +++ b/pkgs/development/mobile/adbfs-rootless/default.nix @@ -37,7 +37,7 @@ stdenv.mkDerivation rec { description = "Mount Android phones on Linux with adb, no root required"; inherit (src.meta) homepage; license = licenses.bsd3; - maintainers = with maintainers; [ Profpatsch ]; + maintainers = with maintainers; [ Profpatsch aleksana ]; platforms = platforms.unix; }; } From ce10c265e5ca31edcf6b570099e317325572e2e9 Mon Sep 17 00:00:00 2001 From: aleksana Date: Wed, 10 May 2023 18:26:35 +0800 Subject: [PATCH 3/3] adbfs-rootless: remove unused adb alias --- pkgs/top-level/all-packages.nix | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/pkgs/top-level/all-packages.nix b/pkgs/top-level/all-packages.nix index 013f7bda2c86..b4f797f2f76e 100644 --- a/pkgs/top-level/all-packages.nix +++ b/pkgs/top-level/all-packages.nix @@ -3650,9 +3650,7 @@ with pkgs; abootimg = callPackage ../development/mobile/abootimg { }; - adbfs-rootless = callPackage ../development/mobile/adbfs-rootless { - adb = androidenv.androidPkgs_9_0.platform-tools; - }; + adbfs-rootless = callPackage ../development/mobile/adbfs-rootless { }; adb-sync = callPackage ../development/mobile/adb-sync { inherit (androidenv.androidPkgs_9_0) platform-tools;