mirror of
https://github.com/NixOS/nixpkgs.git
synced 2024-11-29 18:33:00 +00:00
Merge #215050: protobuf3_21: don't build tests on 32-bit platforms
This commit is contained in:
commit
674e3f033c
@ -79,7 +79,12 @@ let
|
|||||||
"-Dprotobuf_ABSL_PROVIDER=package"
|
"-Dprotobuf_ABSL_PROVIDER=package"
|
||||||
] ++ lib.optionals (!stdenv.targetPlatform.isStatic) [
|
] ++ lib.optionals (!stdenv.targetPlatform.isStatic) [
|
||||||
"-Dprotobuf_BUILD_SHARED_LIBS=ON"
|
"-Dprotobuf_BUILD_SHARED_LIBS=ON"
|
||||||
];
|
]
|
||||||
|
# Tests fail to build on 32-bit platforms; fixed in 3.22
|
||||||
|
# https://github.com/protocolbuffers/protobuf/issues/10418
|
||||||
|
++ lib.optional
|
||||||
|
(stdenv.targetPlatform.is32bit && lib.versionOlder version "3.22")
|
||||||
|
"-Dprotobuf_BUILD_TESTS=OFF";
|
||||||
|
|
||||||
# unfortunately the shared libraries have yet to been patched by nix, thus tests will fail
|
# unfortunately the shared libraries have yet to been patched by nix, thus tests will fail
|
||||||
doCheck = false;
|
doCheck = false;
|
||||||
|
@ -22725,13 +22725,7 @@ with pkgs;
|
|||||||
|
|
||||||
prospector = callPackage ../development/tools/prospector { };
|
prospector = callPackage ../development/tools/prospector { };
|
||||||
|
|
||||||
# https://github.com/protocolbuffers/protobuf/issues/10418
|
protobuf = protobuf3_21;
|
||||||
# protobuf versions have to match between build-time and run-time
|
|
||||||
# Using "targetPlatform" in the check makes sure that the version of
|
|
||||||
# pkgsCross.armv7l-hf-multiplatform.buildPackages.protobuf matches the
|
|
||||||
# version of pkgsCross.armv7l-hf-multiplatform.protobuf
|
|
||||||
protobuf = if stdenv.targetPlatform.is32bit then protobuf3_20 else
|
|
||||||
protobuf3_21;
|
|
||||||
|
|
||||||
protobuf3_21 = callPackage ../development/libraries/protobuf/3.21.nix { };
|
protobuf3_21 = callPackage ../development/libraries/protobuf/3.21.nix { };
|
||||||
protobuf3_20 = callPackage ../development/libraries/protobuf/3.20.nix { };
|
protobuf3_20 = callPackage ../development/libraries/protobuf/3.20.nix { };
|
||||||
|
Loading…
Reference in New Issue
Block a user