From 82801809d954771aee8e3a136ca8610bb28c12e1 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Oliv=C3=A9r=20Falvai?= Date: Fri, 15 Nov 2024 19:55:49 +0100 Subject: [PATCH 1/2] rnote: unbreak darwin (cherry picked from commit a76c14685b3273eb78ee1c466e00123513100b2c) --- pkgs/by-name/rn/rnote/package.nix | 9 ++++----- 1 file changed, 4 insertions(+), 5 deletions(-) diff --git a/pkgs/by-name/rn/rnote/package.nix b/pkgs/by-name/rn/rnote/package.nix index e2c569131ee2..531ff2066156 100644 --- a/pkgs/by-name/rn/rnote/package.nix +++ b/pkgs/by-name/rn/rnote/package.nix @@ -22,7 +22,6 @@ , rustc , shared-mime-info , wrapGAppsHook4 -, darwin }: stdenv.mkDerivation rec { @@ -77,8 +76,6 @@ stdenv.mkDerivation rec { poppler ] ++ lib.optionals stdenv.hostPlatform.isLinux [ alsa-lib - ] ++ lib.optionals stdenv.hostPlatform.isDarwin [ - darwin.apple_sdk.frameworks.AudioUnit ]; postPatch = '' @@ -86,6 +83,10 @@ stdenv.mkDerivation rec { patchShebangs build-aux ''; + env = lib.optionalAttrs stdenv.cc.isClang { + NIX_CFLAGS_COMPILE = "-Wno-error=incompatible-function-pointer-types"; + }; + meta = with lib; { homepage = "https://github.com/flxzt/rnote"; changelog = "https://github.com/flxzt/rnote/releases/tag/${src.rev}"; @@ -93,7 +94,5 @@ stdenv.mkDerivation rec { license = licenses.gpl3Plus; maintainers = with maintainers; [ dotlambda gepbird yrd ]; platforms = platforms.unix; - # compiler error since 2023-11-17 - broken = stdenv.hostPlatform.isDarwin; }; } From d0810c6a686761cf062efa85314c8a3fc00aba4d Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Oliv=C3=A9r=20Falvai?= Date: Fri, 15 Nov 2024 19:56:18 +0100 Subject: [PATCH 2/2] rnote: format with nixfmt-rfc-style (cherry picked from commit 01d50342b81aaf44e69edc6ec8913a1b13348d9a) --- pkgs/by-name/rn/rnote/package.nix | 79 +++++++++++++++++-------------- 1 file changed, 43 insertions(+), 36 deletions(-) diff --git a/pkgs/by-name/rn/rnote/package.nix b/pkgs/by-name/rn/rnote/package.nix index 531ff2066156..e4ce87daf0e0 100644 --- a/pkgs/by-name/rn/rnote/package.nix +++ b/pkgs/by-name/rn/rnote/package.nix @@ -1,27 +1,28 @@ -{ lib -, stdenv -, fetchFromGitHub -, alsa-lib -, appstream -, appstream-glib -, cargo -, cmake -, desktop-file-utils -, dos2unix -, glib -, gst_all_1 -, gtk4 -, libadwaita -, libxml2 -, meson -, ninja -, pkg-config -, poppler -, python3 -, rustPlatform -, rustc -, shared-mime-info -, wrapGAppsHook4 +{ + lib, + stdenv, + fetchFromGitHub, + alsa-lib, + appstream, + appstream-glib, + cargo, + cmake, + desktop-file-utils, + dos2unix, + glib, + gst_all_1, + gtk4, + libadwaita, + libxml2, + meson, + ninja, + pkg-config, + poppler, + python3, + rustPlatform, + rustc, + shared-mime-info, + wrapGAppsHook4, }: stdenv.mkDerivation rec { @@ -66,17 +67,19 @@ stdenv.mkDerivation rec { (lib.mesonBool "cli" true) ]; - buildInputs = [ - appstream - glib - gst_all_1.gstreamer - gtk4 - libadwaita - libxml2 - poppler - ] ++ lib.optionals stdenv.hostPlatform.isLinux [ - alsa-lib - ]; + buildInputs = + [ + appstream + glib + gst_all_1.gstreamer + gtk4 + libadwaita + libxml2 + poppler + ] + ++ lib.optionals stdenv.hostPlatform.isLinux [ + alsa-lib + ]; postPatch = '' chmod +x build-aux/*.py @@ -92,7 +95,11 @@ stdenv.mkDerivation rec { changelog = "https://github.com/flxzt/rnote/releases/tag/${src.rev}"; description = "Simple drawing application to create handwritten notes"; license = licenses.gpl3Plus; - maintainers = with maintainers; [ dotlambda gepbird yrd ]; + maintainers = with maintainers; [ + dotlambda + gepbird + yrd + ]; platforms = platforms.unix; }; }