nordic-dev.net/nixpkgs
nordic-dev.net/nixpkgs
2
0
Fork 0
mirror of https://github.com/NixOS/nixpkgs.git synced 2024-11-22 15:03:28 +00:00
Code Issues Packages Projects Releases Wiki Activity

virtualisation/qemu-vm: disallow nullable diskSize

Browse Source 
Because `virtualisation.diskSize = null` does result in a broken vm runner,
see https://github.com/NixOS/nixpkgs/issues/292901.

diskSize was declared to be nullable when it first got types in a
tree-wide commit:
30f0faac22

But it seemingly never actually supported it, as "${cfg.diskSize}M" is
passed to qemu-img create, which doesn't allow an empty size parameter.

closes: https://github.com/NixOS/nixpkgs/issues/292901
This commit is contained in:
phaer 2024-09-02 10:55:54 +02:00
parent 8899e78e6c
commit 53df1e4ece
1 changed files with 1 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
nixos/modules/virtualisation/qemu-vm.nix
View File

@ -329,7 +329,7 @@ in
virtualisation.diskSize =
mkOption {
type = types.nullOr types.ints.positive;
type = types.ints.positive;
default = 1024;
description = ''
The disk size in megabytes of the virtual machine.