From 501b85f3d5e271c6fbfd2770f65804749729ac12 Mon Sep 17 00:00:00 2001
From: Felix Singer <felixsinger@posteo.net>
Date: Thu, 10 Oct 2024 04:44:59 +0000
Subject: [PATCH] nixos/tests/gerrit: Drop dead hook to LFS plugin

The URL scheme for downloading plugins has changed a long time ago and
the used URL is dead. Gerrit only throws an error since it can't load
the plugin but it continues to boot. However, instead of maintaining
URLs to 3rdparty plugins, which end up dead anyway, just drop it. The
test should cover Gerrit and not 3rd party plugins.

Also, while on it, drop the setting `plugins.allowRemoteAdmin = true`
since it's not needed.

Signed-off-by: Felix Singer <felixsinger@posteo.net>
---
 nixos/tests/gerrit.nix | 11 +----------
 1 file changed, 1 insertion(+), 10 deletions(-)

diff --git a/nixos/tests/gerrit.nix b/nixos/tests/gerrit.nix
index 8ae9e89cf6b0..4630f9412948 100644
--- a/nixos/tests/gerrit.nix
+++ b/nixos/tests/gerrit.nix
@@ -1,12 +1,6 @@
 import ./make-test-python.nix ({ pkgs, ... }:
 
-let
-  lfs = pkgs.fetchurl {
-    url = "https://gerrit-ci.gerritforge.com/job/plugin-lfs-bazel-master/90/artifact/bazel-bin/plugins/lfs/lfs.jar";
-    sha256 = "023b0kd8djm3cn1lf1xl67yv3j12yl8bxccn42lkfmwxjwjfqw6h";
-  };
-
-in {
+{
   name = "gerrit";
 
   meta = with pkgs.lib.maintainers; {
@@ -25,12 +19,9 @@ in {
           listenAddress = "[::]:80";
           jvmHeapLimit = "1g";
 
-          plugins = [ lfs ];
           builtinPlugins = [ "hooks" "webhooks" ];
           settings = {
             gerrit.canonicalWebUrl = "http://server";
-            lfs.plugin = "lfs";
-            plugins.allowRemoteAdmin = true;
             sshd.listenAddress = "[::]:2222";
             sshd.advertisedAddress = "[::]:2222";
           };