From 0b74f9829fe845b815601d4799282f3123383534 Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Alper=20=C3=87elik?= <dev.alpercelik@gmail.com>
Date: Thu, 9 Feb 2023 13:37:26 +0300
Subject: [PATCH] nixos/plasma5: use vlc phonon backend by default

---
 .../doc/manual/from_md/release-notes/rl-2305.section.xml  | 8 ++++++++
 nixos/doc/manual/release-notes/rl-2305.section.md         | 2 ++
 nixos/modules/services/x11/desktop-managers/plasma5.nix   | 4 ++--
 3 files changed, 12 insertions(+), 2 deletions(-)

diff --git a/nixos/doc/manual/from_md/release-notes/rl-2305.section.xml b/nixos/doc/manual/from_md/release-notes/rl-2305.section.xml
index 6936fdd2605f..b5220fbb9964 100644
--- a/nixos/doc/manual/from_md/release-notes/rl-2305.section.xml
+++ b/nixos/doc/manual/from_md/release-notes/rl-2305.section.xml
@@ -914,6 +914,14 @@
           (<link linkend="opt-services.fwupd.daemonSettings"><literal>services.fwupd.daemonSettings</literal></link>).
         </para>
       </listitem>
+      <listitem>
+        <para>
+          <literal>services.xserver.desktopManager.plasma5.phononBackend</literal>
+          now defaults to vlc according to
+          <link xlink:href="https://community.kde.org/Distributions/Packaging_Recommendations#Non-Plasma_packages">upstrean
+          recommendation</link>
+        </para>
+      </listitem>
       <listitem>
         <para>
           The <literal>zramSwap</literal> is now implemented with
diff --git a/nixos/doc/manual/release-notes/rl-2305.section.md b/nixos/doc/manual/release-notes/rl-2305.section.md
index b7614c0788cf..c81cbc69f94e 100644
--- a/nixos/doc/manual/release-notes/rl-2305.section.md
+++ b/nixos/doc/manual/release-notes/rl-2305.section.md
@@ -223,6 +223,8 @@ In addition to numerous new and upgraded packages, this release has the followin
 
 - The `services.fwupd` module now allows arbitrary daemon settings to be configured in a structured manner ([`services.fwupd.daemonSettings`](#opt-services.fwupd.daemonSettings)).
 
+- `services.xserver.desktopManager.plasma5.phononBackend` now defaults to vlc according to [upstrean recommendation](https://community.kde.org/Distributions/Packaging_Recommendations#Non-Plasma_packages)
+
 - The `zramSwap` is now implemented with `zram-generator`, and the option `zramSwap.numDevices` for using ZRAM devices as general purpose ephemeral block devices has been removed.
 
 - As Singularity has renamed to [Apptainer](https://apptainer.org/news/community-announcement-20211130)
diff --git a/nixos/modules/services/x11/desktop-managers/plasma5.nix b/nixos/modules/services/x11/desktop-managers/plasma5.nix
index 181db01ad88e..c150adcac26b 100644
--- a/nixos/modules/services/x11/desktop-managers/plasma5.nix
+++ b/nixos/modules/services/x11/desktop-managers/plasma5.nix
@@ -90,8 +90,8 @@ in
 
     phononBackend = mkOption {
       type = types.enum [ "gstreamer" "vlc" ];
-      default = "gstreamer";
-      example = "vlc";
+      default = "vlc";
+      example = "gstreamer";
       description = lib.mdDoc "Phonon audio backend to install.";
     };