halide: 16.0.0 -> 18.0.0 (#349237)

This commit is contained in:
kirillrdy 2024-10-21 20:44:53 +11:00 committed by GitHub
commit 4223f416ef
No known key found for this signature in database
GPG Key ID: B5690EEEBB952194
3 changed files with 106 additions and 61 deletions

View File

@ -1,59 +1,64 @@
{ stdenv
, llvmPackages
, lib
, fetchFromGitHub
, cmake
, libffi
, libpng
, libjpeg
, mesa
, libGL
, eigen
, openblas
, blas
, lapack
{
stdenv,
llvmPackages,
lib,
fetchFromGitHub,
cmake,
flatbuffers,
libffi,
libpng,
libjpeg,
mesa,
libGL,
eigen,
openblas,
blas,
lapack,
pythonSupport ? false,
python3Packages ? null,
}:
assert blas.implementation == "openblas" && lapack.implementation == "openblas";
stdenv.mkDerivation rec {
pname = "halide";
version = "16.0.0";
version = "18.0.0";
src = fetchFromGitHub {
owner = "halide";
repo = "Halide";
rev = "v${version}";
sha256 = "sha256-lJQrXkJgBmGb/QMSxwuPkkHOSgEDowLWzIolp1km2Y8=";
hash = "sha256-BPalUh9EgdCqVaWC1HoreyyRcPQc4QMIYnLrRoNDDCI=";
};
postPatch = ''
# See https://github.com/halide/Halide/issues/7785
substituteInPlace 'src/runtime/HalideRuntime.h' \
--replace '#if defined(__x86_64__) || defined(__i386__) || defined(__arm__) || defined(__aarch64__)
#define HALIDE_CPP_COMPILER_HAS_FLOAT16' \
'#if defined(__x86_64__) || defined(__i386__)
#define HALIDE_CPP_COMPILER_HAS_FLOAT16'
''
# Note: on x86_64-darwin, clang fails to find AvailabilityVersions.h, so we remove it.
# Halide uses AvailabilityVersions.h and TargetConditionals.h to determine whether
# ::aligned_alloc is available. For us, it isn't.
+ lib.optionalString (stdenv.hostPlatform.isDarwin && stdenv.hostPlatform.isx86_64) ''
substituteInPlace 'src/runtime/HalideBuffer.h' \
--replace '#ifdef __APPLE__
#include <AvailabilityVersions.h>
#include <TargetConditionals.h>
#endif' \
' ' \
--replace 'TARGET_OS_OSX && (__MAC_OS_X_VERSION_MIN_REQUIRED < __MAC_10_15)' \
'1' \
--replace 'TARGET_OS_IPHONE && (__IPHONE_OS_VERSION_MIN_REQUIRED < __IPHONE_14_0)' \
'0'
'';
postPatch =
''
# See https://github.com/halide/Halide/issues/7785
substituteInPlace 'src/runtime/HalideRuntime.h' \
--replace '#if defined(__x86_64__) || defined(__i386__) || defined(__arm__) || defined(__aarch64__)
#define HALIDE_CPP_COMPILER_HAS_FLOAT16' \
'#if defined(__x86_64__) || defined(__i386__)
#define HALIDE_CPP_COMPILER_HAS_FLOAT16'
''
# Note: on x86_64-darwin, clang fails to find AvailabilityVersions.h, so we remove it.
# Halide uses AvailabilityVersions.h and TargetConditionals.h to determine whether
# ::aligned_alloc is available. For us, it isn't.
+ lib.optionalString (stdenv.hostPlatform.isDarwin && stdenv.hostPlatform.isx86_64) ''
substituteInPlace 'src/runtime/HalideBuffer.h' \
--replace '#ifdef __APPLE__
#include <AvailabilityVersions.h>
#include <TargetConditionals.h>
#endif' \
' ' \
--replace 'TARGET_OS_OSX && (__MAC_OS_X_VERSION_MIN_REQUIRED < __MAC_10_15)' \
'1' \
--replace 'TARGET_OS_IPHONE && (__IPHONE_OS_VERSION_MIN_REQUIRED < __IPHONE_14_0)' \
'0'
'';
cmakeFlags = [
"-DWARNINGS_AS_ERRORS=OFF"
"-DWITH_PYTHON_BINDINGS=OFF"
"-DWITH_PYTHON_BINDINGS=${if pythonSupport then "ON" else "OFF"}"
"-DTARGET_WEBASSEMBLY=OFF"
# Disable performance tests since they may fail on busy machines
"-DWITH_TEST_PERFORMANCE=OFF"
@ -61,41 +66,79 @@ stdenv.mkDerivation rec {
# v16 release (See https://github.com/halide/Halide/commit/09c5d1d19ec8e6280ccbc01a8a12decfb27226ba)
# These tests also fail to compile on Darwin because of some missing command line options...
"-DWITH_TEST_FUZZ=OFF"
# Disable FetchContent for flatbuffers and use the version from nixpkgs instead
"-DFLATBUFFERS_USE_FETCHCONTENT=OFF"
"-DPYBIND11_USE_FETCHCONTENT=OFF"
];
doCheck = true;
# Note: disable mullapudi2016_fibonacci because it requires too much
# parallelism for remote builders
preCheck = ''
checkFlagsArray+=("ARGS=-E 'mullapudi2016_fibonacci'")
preCheck =
let
disabledTests = lib.strings.concatStringsSep "|" [
# Requires too much parallelism for remote builders.
"mullapudi2016_fibonacci"
# Take too long---we don't want to run these in CI.
"adams2019_test_apps_autoscheduler"
"anderson2021_test_apps_autoscheduler"
"correctness_cross_compilation"
"correctness_simd_op_check_hvx"
];
in
''
checkFlagsArray+=("ARGS=-E '${disabledTests}'")
'';
postInstall = lib.optionalString pythonSupport ''
mkdir -p $out/${builtins.dirOf python3Packages.python.sitePackages}
mv -v $out/lib/python3/site-packages $out/${python3Packages.python.sitePackages}
rmdir $out/lib/python3/
'';
# Note: only openblas and not atlas part of this Nix expression
# see pkgs/development/libraries/science/math/liblapack/3.5.0.nix
# to get a hint howto setup atlas instead of openblas
buildInputs = [
llvmPackages.llvm
llvmPackages.lld
llvmPackages.openmp
llvmPackages.libclang
libffi
libpng
libjpeg
eigen
openblas
] ++ lib.optionals (!stdenv.hostPlatform.isDarwin) [
mesa
libGL
];
buildInputs =
[
llvmPackages.llvm
llvmPackages.lld
llvmPackages.openmp
llvmPackages.libclang
libffi
libpng
libjpeg
eigen
openblas
]
++ lib.optionals (!stdenv.hostPlatform.isDarwin) [
mesa
libGL
];
nativeBuildInputs = [ cmake ];
nativeBuildInputs =
[
cmake
flatbuffers
]
++ lib.optionals pythonSupport [
python3Packages.python
python3Packages.pybind11
];
propagatedBuildInputs = lib.optionals pythonSupport [
python3Packages.numpy
python3Packages.imageio
];
meta = with lib; {
description = "C++ based language for image processing and computational photography";
homepage = "https://halide-lang.org";
license = licenses.mit;
platforms = platforms.all;
maintainers = with maintainers; [ ck3d atila twesterhout ];
maintainers = with maintainers; [
ck3d
atila
twesterhout
];
};
}

View File

@ -8360,7 +8360,7 @@ with pkgs;
halibut = callPackage ../tools/typesetting/halibut { };
halide = callPackage ../development/compilers/halide {
llvmPackages = llvmPackages_16;
llvmPackages = llvmPackages_18;
};
hareThirdParty = recurseIntoAttrs (callPackage ./hare-third-party.nix { });

View File

@ -5578,6 +5578,8 @@ self: super: with self; {
hakuin = callPackage ../development/python-modules/hakuin { };
halide = toPythonModule (pkgs.halide.override { pythonSupport = true; python3Packages = self; });
halo = callPackage ../development/python-modules/halo { };
halohome = callPackage ../development/python-modules/halohome { };