From 9cd5107391a7b34ba7e1c2e46e1c45b04cf92c0d Mon Sep 17 00:00:00 2001 From: Ivan Babrou Date: Wed, 24 Feb 2021 19:37:19 -0800 Subject: [PATCH 1/3] cargo-deb: run tests in release profile The `checkType` attribute does not apply after #113193, and since we're changing tests anyway, let's run them in the release mode to avoid the need for `checkType`. This fixes the otherwise broken build. --- pkgs/tools/package-management/cargo-deb/default.nix | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/pkgs/tools/package-management/cargo-deb/default.nix b/pkgs/tools/package-management/cargo-deb/default.nix index 668a623ee2a5..0b59a1cfc467 100644 --- a/pkgs/tools/package-management/cargo-deb/default.nix +++ b/pkgs/tools/package-management/cargo-deb/default.nix @@ -21,11 +21,9 @@ rustPlatform.buildRustPackage rec { cargoSha256 = "1vqnnqn6rzkdi239bh3lk7gaxr7w6v3c4ws4ya1ah04g6v9hkzlw"; - checkType = "debug"; - preCheck = '' substituteInPlace tests/command.rs \ - --replace 'target/debug' "target/${rust.toRustTarget stdenv.buildPlatform}/debug" + --replace 'target/debug' "target/${rust.toRustTarget stdenv.buildPlatform}/release" ''; meta = with lib; { From 0ae422a4f23d423d1a0b1071f9df146537917706 Mon Sep 17 00:00:00 2001 From: Ivan Babrou Date: Wed, 24 Feb 2021 19:41:24 -0800 Subject: [PATCH 2/3] cargo-deb: 1.24.0 -> 1.29.1 --- pkgs/tools/package-management/cargo-deb/default.nix | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/pkgs/tools/package-management/cargo-deb/default.nix b/pkgs/tools/package-management/cargo-deb/default.nix index 0b59a1cfc467..430c29a45f03 100644 --- a/pkgs/tools/package-management/cargo-deb/default.nix +++ b/pkgs/tools/package-management/cargo-deb/default.nix @@ -8,18 +8,18 @@ rustPlatform.buildRustPackage rec { pname = "cargo-deb"; - version = "1.24.0"; + version = "1.29.1"; src = fetchFromGitHub { owner = "mmstick"; repo = pname; - rev = "b49351f6770aa7aeb053dd1d4a02d6b086caad2a"; - sha256 = "1hs96yv0awgi7ggpxp7k3n21jpv642sm0529b21hs9ib6kp4vs8s"; + rev = "86d02f9cacaf4a4f9b576e2dbd9dad65baa61a0d"; + sha256 = "sha256-oWivGy2azF9zpeZ0UAi7Bxm4iXFWAjcBG0pN7qtkSU8="; }; buildInputs = lib.optionals stdenv.isDarwin [ Security ]; - cargoSha256 = "1vqnnqn6rzkdi239bh3lk7gaxr7w6v3c4ws4ya1ah04g6v9hkzlw"; + cargoSha256 = "sha256-HgGl1JWNkPEBODzWa6mfXuAtF8jOgT0Obx4mX9nOLkk="; preCheck = '' substituteInPlace tests/command.rs \ From a422684c87c3f199e13a931ec8f5d7bd061859a7 Mon Sep 17 00:00:00 2001 From: Ivan Babrou Date: Wed, 24 Feb 2021 21:13:28 -0800 Subject: [PATCH 3/3] cargo-deb: do not expect glibc dependency to be added The test was introduced in v1.25.0: * https://github.com/mmstick/cargo-deb/commit/3597cf28e --- pkgs/tools/package-management/cargo-deb/default.nix | 8 ++++++-- 1 file changed, 6 insertions(+), 2 deletions(-) diff --git a/pkgs/tools/package-management/cargo-deb/default.nix b/pkgs/tools/package-management/cargo-deb/default.nix index 430c29a45f03..f171a1500454 100644 --- a/pkgs/tools/package-management/cargo-deb/default.nix +++ b/pkgs/tools/package-management/cargo-deb/default.nix @@ -13,17 +13,21 @@ rustPlatform.buildRustPackage rec { src = fetchFromGitHub { owner = "mmstick"; repo = pname; - rev = "86d02f9cacaf4a4f9b576e2dbd9dad65baa61a0d"; + rev = "v${version}"; sha256 = "sha256-oWivGy2azF9zpeZ0UAi7Bxm4iXFWAjcBG0pN7qtkSU8="; }; buildInputs = lib.optionals stdenv.isDarwin [ Security ]; - cargoSha256 = "sha256-HgGl1JWNkPEBODzWa6mfXuAtF8jOgT0Obx4mX9nOLkk="; + cargoSha256 = "0j9frvcmy9hydw73v0ffr0bjvq2ykylnpmiw700z344djpaaa08y"; preCheck = '' substituteInPlace tests/command.rs \ --replace 'target/debug' "target/${rust.toRustTarget stdenv.buildPlatform}/release" + + # This is an FHS specific assert depending on glibc location + substituteInPlace src/dependencies.rs \ + --replace 'assert!(deps.iter().any(|d| d.starts_with("libc")));' '// no libc assert here' ''; meta = with lib; {