root: 6.32.06 -> 6.32.08, fix on darwin, move to pkgs/by-name (#355981)

This commit is contained in:
Dmitry Kalinkin 2024-11-18 08:19:14 -05:00 committed by GitHub
commit 294fb30959
No known key found for this signature in database
GPG Key ID: B5690EEEBB952194
14 changed files with 396 additions and 330 deletions

View File

@ -1,253 +0,0 @@
{ stdenv
, lib
, callPackage
, fetchgit
, fetchurl
, makeWrapper
, writeText
, cmake
, coreutils
, git
, davix
, ftgl
, gl2ps
, glew
, gnugrep
, gnused
, gsl
, gtest
, lapack
, libX11
, libXpm
, libXft
, libXext
, libGLU
, libGL
, libxcrypt
, libxml2
, llvm_16
, lsof
, lz4
, xz
, man
, openblas
, openssl
, pcre
, nlohmann_json
, pkg-config
, procps
, python
, which
, xxHash
, zlib
, zstd
, giflib
, libjpeg
, libtiff
, libpng
, patchRcPathCsh
, patchRcPathFish
, patchRcPathPosix
, tbb
, xrootd
, Cocoa
, CoreSymbolication
, OpenGL
}:
stdenv.mkDerivation rec {
pname = "root";
version = "6.32.06";
passthru = {
tests = import ./tests { inherit callPackage; };
};
src = fetchurl {
url = "https://root.cern.ch/download/root_v${version}.source.tar.gz";
hash = "sha256-P8Ay2T/oSN6lrbG0fY8KhieVIyk/7gqis81Sof+rckc=";
};
clad_src = fetchgit {
url = "https://github.com/vgvassilev/clad";
# Make sure that this is the same tag as in the ROOT build files!
# https://github.com/root-project/root/blob/master/interpreter/cling/tools/plugins/clad/CMakeLists.txt#L76
rev = "refs/tags/v1.7";
hash = "sha256-iKrZsuUerrlrjXBrxcTsFu/t0Pb0sa4UlfSwd1yhg3g=";
};
nativeBuildInputs = [ makeWrapper cmake pkg-config git ];
propagatedBuildInputs = [
nlohmann_json
];
buildInputs = [
davix
ftgl
gl2ps
glew
pcre
zlib
zstd
lapack
libxcrypt
libxml2
llvm_16
lz4
xz
gsl
gtest
openblas
openssl
xxHash
giflib
libjpeg
libtiff
libpng
patchRcPathCsh
patchRcPathFish
patchRcPathPosix
python.pkgs.numpy
tbb
xrootd
]
++ lib.optionals (!stdenv.hostPlatform.isDarwin) [ libX11 libXpm libXft libXext libGLU libGL ]
++ lib.optionals (stdenv.hostPlatform.isDarwin) [ Cocoa CoreSymbolication OpenGL ]
;
patches = [
./sw_vers.patch
];
preConfigure = ''
for path in builtins/*; do
if [[ "$path" != "builtins/openui5" ]] && [[ "$path" != "builtins/rendercore" ]]; then
rm -rf "$path"
fi
done
substituteInPlace cmake/modules/SearchInstalledSoftware.cmake \
--replace-fail 'set(lcgpackages ' '#set(lcgpackages '
# We have to bypass the connection check, because it would disable clad.
# This should probably be fixed upstream with a flag to disable the
# connectivity check!
substituteInPlace CMakeLists.txt \
--replace-fail 'if(clad AND NO_CONNECTION)' 'if(FALSE)'
# Make sure that clad is not downloaded when building
substituteInPlace interpreter/cling/tools/plugins/clad/CMakeLists.txt \
--replace-fail 'UPDATE_COMMAND ""' 'SOURCE_DIR ${clad_src} DOWNLOAD_COMMAND "" UPDATE_COMMAND ""'
# Make sure that clad is finding the right llvm version
substituteInPlace interpreter/cling/tools/plugins/clad/CMakeLists.txt \
--replace-fail '-DLLVM_DIR=''${LLVM_BINARY_DIR}' '-DLLVM_DIR=${llvm_16.dev}/lib/cmake/llvm'
substituteInPlace interpreter/llvm-project/clang/tools/driver/CMakeLists.txt \
--replace-fail 'add_clang_symlink(''${link} clang)' ""
# Don't require textutil on macOS
: > cmake/modules/RootCPack.cmake
# Hardcode path to fix use with cmake
sed -i cmake/scripts/ROOTConfig.cmake.in \
-e '1iset(nlohmann_json_DIR "${nlohmann_json}/lib/cmake/nlohmann_json/")'
patchShebangs build/unix/
'' + lib.optionalString stdenv.hostPlatform.isDarwin ''
# Eliminate impure reference to /System/Library/PrivateFrameworks
substituteInPlace core/macosx/CMakeLists.txt \
--replace-fail "-F/System/Library/PrivateFrameworks " ""
'' + lib.optionalString (stdenv.hostPlatform.isDarwin && lib.versionAtLeast stdenv.hostPlatform.darwinMinVersion "11") ''
MACOSX_DEPLOYMENT_TARGET=10.16
'';
cmakeFlags = [
"-DCMAKE_INSTALL_BINDIR=bin"
"-DCMAKE_INSTALL_LIBDIR=lib"
"-DCMAKE_INSTALL_INCLUDEDIR=include"
"-Dbuiltin_llvm=OFF"
"-Dfail-on-missing=ON"
"-Dfitsio=OFF"
"-Dgnuinstall=ON"
"-Dmathmore=ON"
"-Dmysql=OFF"
"-Dpgsql=OFF"
"-Dsqlite=OFF"
"-Dvdt=OFF"
]
++ lib.optional (stdenv.cc.libc != null) "-DC_INCLUDE_DIRS=${lib.getDev stdenv.cc.libc}/include"
++ lib.optionals stdenv.hostPlatform.isDarwin [
"-DOPENGL_INCLUDE_DIR=${OpenGL}/Library/Frameworks"
# fatal error: module map file '/nix/store/<hash>-Libsystem-osx-10.12.6/include/module.modulemap' not found
# fatal error: could not build module '_Builtin_intrinsics'
"-Druntime_cxxmodules=OFF"
];
postInstall = ''
for prog in rootbrowse rootcp rooteventselector rootls rootmkdir rootmv rootprint rootrm rootslimtree; do
wrapProgram "$out/bin/$prog" \
--set PYTHONPATH "$out/lib"
done
# Make ldd and sed available to the ROOT executable by prefixing PATH.
wrapProgram "$out/bin/root" \
--prefix PATH : "${lib.makeBinPath [
gnused # sed
stdenv.cc # c++ ld etc.
stdenv.cc.libc # ldd
]}"
# Patch thisroot.{sh,csh,fish}
# The main target of `thisroot.sh` is "bash-like shells",
# but it also need to support Bash-less POSIX shell like dash,
# as they are mentioned in `thisroot.sh`.
patchRcPathPosix "$out/bin/thisroot.sh" "${lib.makeBinPath [
coreutils # dirname tail
gnugrep # grep
gnused # sed
lsof # lsof
man # manpath
procps # ps
which # which
]}"
patchRcPathCsh "$out/bin/thisroot.csh" "${lib.makeBinPath [
coreutils
gnugrep
gnused
lsof # lsof
man
which
]}"
patchRcPathFish "$out/bin/thisroot.fish" "${lib.makeBinPath [
coreutils
man
which
]}"
'';
# error: aligned allocation function of type 'void *(std::size_t, std::align_val_t)' is only available on macOS 10.13 or newer
env.CXXFLAGS = lib.optionalString (stdenv.hostPlatform.system == "x86_64-darwin") "-faligned-allocation";
# workaround for
# https://github.com/root-project/root/issues/14778
env.NIX_LDFLAGS = lib.optionalString (!stdenv.hostPlatform.isDarwin) "--version-script,${writeText "version.map" "ROOT { global: *; };"}";
# To use the debug information on the fly (without installation)
# add the outPath of root.debug into NIX_DEBUG_INFO_DIRS (in PATH-like format)
# and make sure that gdb from Nixpkgs can be found in PATH.
#
# Darwin currently fails to support it (#203380)
# we set it to true hoping to benefit from the future fix.
# Before that, please make sure if root.debug exists before using it.
separateDebugInfo = true;
setupHook = ./setup-hook.sh;
meta = with lib; {
homepage = "https://root.cern/";
description = "Data analysis framework";
platforms = platforms.unix;
maintainers = [ maintainers.guitargeek maintainers.veprbl ];
license = licenses.lgpl21;
};
}

View File

@ -0,0 +1,282 @@
{
stdenv,
lib,
callPackage,
fetchgit,
fetchurl,
makeWrapper,
writeText,
apple-sdk,
cmake,
coreutils,
git,
davix,
ftgl,
gl2ps,
glew,
gnugrep,
gnused,
gsl,
gtest,
lapack,
libX11,
libXpm,
libXft,
libXext,
libGLU,
libGL,
libxcrypt,
libxml2,
llvm_16,
lsof,
lz4,
xz,
man,
openblas,
openssl,
pcre,
nlohmann_json,
pkg-config,
procps,
python3,
which,
xxHash,
zlib,
zstd,
giflib,
libjpeg,
libtiff,
libpng,
patchRcPathCsh,
patchRcPathFish,
patchRcPathPosix,
tbb,
xrootd,
}:
stdenv.mkDerivation rec {
pname = "root";
version = "6.32.08";
passthru = {
tests = import ./tests { inherit callPackage; };
};
src = fetchurl {
url = "https://root.cern.ch/download/root_v${version}.source.tar.gz";
hash = "sha256-Ka1JRact/xoAnDJqZbb6XuJHhJiCMlHTzvhqLL63eyc=";
};
clad_src = fetchgit {
url = "https://github.com/vgvassilev/clad";
# Make sure that this is the same tag as in the ROOT build files!
# https://github.com/root-project/root/blob/master/interpreter/cling/tools/plugins/clad/CMakeLists.txt#L76
rev = "refs/tags/v1.7";
hash = "sha256-iKrZsuUerrlrjXBrxcTsFu/t0Pb0sa4UlfSwd1yhg3g=";
};
nativeBuildInputs = [
makeWrapper
cmake
pkg-config
git
];
propagatedBuildInputs = [ nlohmann_json ];
buildInputs =
[
davix
ftgl
gl2ps
glew
pcre
zlib
zstd
lapack
libxcrypt
libxml2
llvm_16
lz4
xz
gsl
gtest
openblas
openssl
xxHash
giflib
libjpeg
libtiff
libpng
patchRcPathCsh
patchRcPathFish
patchRcPathPosix
python3.pkgs.numpy
tbb
xrootd
]
++ lib.optionals stdenv.hostPlatform.isDarwin [ apple-sdk.privateFrameworksHook ]
++ lib.optionals (!stdenv.hostPlatform.isDarwin) [
libX11
libXpm
libXft
libXext
libGLU
libGL
];
patches = [ ./sw_vers.patch ];
preConfigure =
''
for path in builtins/*; do
if [[ "$path" != "builtins/openui5" ]] && [[ "$path" != "builtins/rendercore" ]]; then
rm -rf "$path"
fi
done
substituteInPlace cmake/modules/SearchInstalledSoftware.cmake \
--replace-fail 'set(lcgpackages ' '#set(lcgpackages '
# We have to bypass the connection check, because it would disable clad.
# This should probably be fixed upstream with a flag to disable the
# connectivity check!
substituteInPlace CMakeLists.txt \
--replace-fail 'if(clad AND NO_CONNECTION)' 'if(FALSE)'
# Make sure that clad is not downloaded when building
substituteInPlace interpreter/cling/tools/plugins/clad/CMakeLists.txt \
--replace-fail 'UPDATE_COMMAND ""' 'SOURCE_DIR ${clad_src} DOWNLOAD_COMMAND "" UPDATE_COMMAND ""'
# Make sure that clad is finding the right llvm version
substituteInPlace interpreter/cling/tools/plugins/clad/CMakeLists.txt \
--replace-fail '-DLLVM_DIR=''${LLVM_BINARY_DIR}' '-DLLVM_DIR=${llvm_16.dev}/lib/cmake/llvm'
substituteInPlace interpreter/llvm-project/clang/tools/driver/CMakeLists.txt \
--replace-fail 'add_clang_symlink(''${link} clang)' ""
# Don't require textutil on macOS
: > cmake/modules/RootCPack.cmake
# Hardcode path to fix use with cmake
sed -i cmake/scripts/ROOTConfig.cmake.in \
-e '1iset(nlohmann_json_DIR "${nlohmann_json}/lib/cmake/nlohmann_json/")'
patchShebangs build/unix/
''
+ lib.optionalString stdenv.hostPlatform.isDarwin ''
# Eliminate impure reference to /System/Library/PrivateFrameworks
substituteInPlace core/macosx/CMakeLists.txt \
--replace-fail "-F/System/Library/PrivateFrameworks " ""
''
+
lib.optionalString
(stdenv.hostPlatform.isDarwin && lib.versionAtLeast stdenv.hostPlatform.darwinMinVersion "11")
''
MACOSX_DEPLOYMENT_TARGET=10.16
'';
cmakeFlags =
[
"-DCMAKE_INSTALL_BINDIR=bin"
"-DCMAKE_INSTALL_LIBDIR=lib"
"-DCMAKE_INSTALL_INCLUDEDIR=include"
"-Dbuiltin_llvm=OFF"
"-Dfail-on-missing=ON"
"-Dfitsio=OFF"
"-Dgnuinstall=ON"
"-Dmathmore=ON"
"-Dmysql=OFF"
"-Dpgsql=OFF"
"-Dsqlite=OFF"
"-Dvdt=OFF"
]
++ lib.optional (
(!stdenv.hostPlatform.isDarwin) && (stdenv.cc.libc != null)
) "-DC_INCLUDE_DIRS=${lib.getDev stdenv.cc.libc}/include"
++ lib.optionals stdenv.hostPlatform.isDarwin [
# fatal error: module map file '/nix/store/<hash>-Libsystem-osx-10.12.6/include/module.modulemap' not found
# fatal error: could not build module '_Builtin_intrinsics'
"-Druntime_cxxmodules=OFF"
];
postInstall = ''
for prog in rootbrowse rootcp rooteventselector rootls rootmkdir rootmv rootprint rootrm rootslimtree; do
wrapProgram "$out/bin/$prog" \
--set PYTHONPATH "$out/lib"
done
# Make ldd and sed available to the ROOT executable by prefixing PATH.
wrapProgram "$out/bin/root" \
--prefix PATH : "${
lib.makeBinPath [
gnused # sed
stdenv.cc # c++ ld etc.
stdenv.cc.libc # ldd
]
}"
# Patch thisroot.{sh,csh,fish}
# The main target of `thisroot.sh` is "bash-like shells",
# but it also need to support Bash-less POSIX shell like dash,
# as they are mentioned in `thisroot.sh`.
patchRcPathPosix "$out/bin/thisroot.sh" "${
lib.makeBinPath [
coreutils # dirname tail
gnugrep # grep
gnused # sed
lsof # lsof
man # manpath
procps # ps
which # which
]
}"
patchRcPathCsh "$out/bin/thisroot.csh" "${
lib.makeBinPath [
coreutils
gnugrep
gnused
lsof # lsof
man
which
]
}"
patchRcPathFish "$out/bin/thisroot.fish" "${
lib.makeBinPath [
coreutils
man
which
]
}"
'';
# error: aligned allocation function of type 'void *(std::size_t, std::align_val_t)' is only available on macOS 10.13 or newer
env.CXXFLAGS = lib.optionalString (
stdenv.hostPlatform.system == "x86_64-darwin"
) "-faligned-allocation";
# workaround for
# https://github.com/root-project/root/issues/14778
env.NIX_LDFLAGS = lib.optionalString (
!stdenv.hostPlatform.isDarwin
) "--version-script,${writeText "version.map" "ROOT { global: *; };"}";
# To use the debug information on the fly (without installation)
# add the outPath of root.debug into NIX_DEBUG_INFO_DIRS (in PATH-like format)
# and make sure that gdb from Nixpkgs can be found in PATH.
#
# Darwin currently fails to support it (#203380)
# we set it to true hoping to benefit from the future fix.
# Before that, please make sure if root.debug exists before using it.
separateDebugInfo = true;
setupHook = ./setup-hook.sh;
meta = with lib; {
homepage = "https://root.cern/";
description = "Data analysis framework";
platforms = platforms.unix;
maintainers = [
maintainers.guitargeek
maintainers.veprbl
];
license = licenses.lgpl21;
};
}

View File

@ -1,27 +1,26 @@
{ lib {
, stdenv lib,
, fetchurl stdenv,
, fetchpatch fetchurl,
, cmake fetchpatch,
, pcre cmake,
, pkg-config pcre,
, python3 pkg-config,
, libX11 python3,
, libXpm libX11,
, libXft libXpm,
, libXext libXft,
, libGLU libXext,
, libGL libGLU,
, zlib libGL,
, libxml2 zlib,
, libxcrypt libxml2,
, lz4 libxcrypt,
, xz lz4,
, gsl xz,
, xxHash gsl,
, Cocoa xxHash,
, OpenGL noSplash ? false,
, noSplash ? false
}: }:
stdenv.mkDerivation rec { stdenv.mkDerivation rec {
@ -33,11 +32,30 @@ stdenv.mkDerivation rec {
sha256 = "1ln448lszw4d6jmbdphkr2plwxxlhmjkla48vmmq750xc1lxlfrc"; sha256 = "1ln448lszw4d6jmbdphkr2plwxxlhmjkla48vmmq750xc1lxlfrc";
}; };
nativeBuildInputs = [ cmake pkg-config ]; nativeBuildInputs = [
buildInputs = [ pcre python3 zlib libxml2 lz4 xz gsl xxHash libxcrypt ] cmake
++ lib.optionals (!stdenv.hostPlatform.isDarwin) [ libX11 libXpm libXft libXext libGLU libGL ] pkg-config
++ lib.optionals (stdenv.hostPlatform.isDarwin) [ Cocoa OpenGL ] ];
; buildInputs =
[
pcre
python3
zlib
libxml2
lz4
xz
gsl
xxHash
libxcrypt
]
++ lib.optionals (!stdenv.hostPlatform.isDarwin) [
libX11
libXpm
libXft
libXext
libGLU
libGL
];
patches = [ patches = [
./sw_vers_root5.patch ./sw_vers_root5.patch
@ -72,45 +90,52 @@ stdenv.mkDerivation rec {
# https://github.com/root-project/root/issues/13216 # https://github.com/root-project/root/issues/13216
hardeningDisable = [ "fortify3" ]; hardeningDisable = [ "fortify3" ];
preConfigure = '' preConfigure =
# binutils 2.37 fixes ''
fixupList=( # binutils 2.37 fixes
cint/demo/gl/make0 fixupList=(
cint/demo/exception/Makefile cint/demo/gl/make0
cint/demo/makecint/KRcc/Makefile cint/demo/exception/Makefile
cint/demo/makecint/Stub2/Make2 cint/demo/makecint/KRcc/Makefile
cint/demo/makecint/Array/Makefile cint/demo/makecint/Stub2/Make2
cint/demo/makecint/DArray/Makefile cint/demo/makecint/Array/Makefile
cint/demo/makecint/ReadFile/Makefile cint/demo/makecint/DArray/Makefile
cint/demo/makecint/stl/Makefile cint/demo/makecint/ReadFile/Makefile
cint/demo/makecint/Stub2/Make1 cint/demo/makecint/stl/Makefile
cint/cint/include/makemat cint/demo/makecint/Stub2/Make1
cint/cint/lib/WildCard/Makefile cint/cint/include/makemat
cint/cint/include/make.arc cint/cint/lib/WildCard/Makefile
cint/cint/lib/qt/Makefile cint/cint/include/make.arc
cint/cint/lib/pthread/Makefile cint/cint/lib/qt/Makefile
graf2d/asimage/src/libAfterImage/Makefile.in cint/cint/lib/pthread/Makefile
) graf2d/asimage/src/libAfterImage/Makefile.in
for toFix in "''${fixupList[@]}"; do )
substituteInPlace "$toFix" --replace "clq" "cq" for toFix in "''${fixupList[@]}"; do
done substituteInPlace "$toFix" --replace "clq" "cq"
done
patchShebangs build/unix/ patchShebangs build/unix/
ln -s ${lib.getDev stdenv.cc.libc}/include/AvailabilityMacros.h cint/cint/include/ ln -s ${lib.getDev stdenv.cc.libc}/include/AvailabilityMacros.h cint/cint/include/
# __malloc_hook is deprecated # __malloc_hook is deprecated
substituteInPlace misc/memstat/src/TMemStatHook.cxx \ substituteInPlace misc/memstat/src/TMemStatHook.cxx \
--replace "defined(R__GNU) && (defined(R__LINUX) || defined(__APPLE__))" \ --replace "defined(R__GNU) && (defined(R__LINUX) || defined(__APPLE__))" \
"defined(R__GNU) && (defined(__APPLE__))" "defined(R__GNU) && (defined(__APPLE__))"
''
# Fix CINTSYSDIR for "build" version of rootcint # python 3.12
# This is probably a bug that breaks out-of-source builds substituteInPlace bindings/pyroot/src/PyROOT.h \
+ '' --replace " PyUnicode_GET_SIZE" " PyUnicode_GetLength" \
substituteInPlace cint/cint/src/loadfile.cxx\ --replace " PyUnicode_GetSize" " PyUnicode_GetLength"
--replace 'env = "cint";' 'env = "'`pwd`'/cint";' ''
'' + lib.optionalString noSplash '' # Fix CINTSYSDIR for "build" version of rootcint
substituteInPlace rootx/src/rootx.cxx --replace "gNoLogo = false" "gNoLogo = true" # This is probably a bug that breaks out-of-source builds
''; + ''
substituteInPlace cint/cint/src/loadfile.cxx\
--replace 'env = "cint";' 'env = "'`pwd`'/cint";'
''
+ lib.optionalString noSplash ''
substituteInPlace rootx/src/rootx.cxx --replace "gNoLogo = false" "gNoLogo = true"
'';
cmakeFlags = [ cmakeFlags = [
"-Drpath=ON" "-Drpath=ON"
@ -147,7 +172,9 @@ stdenv.mkDerivation rec {
"-Dxml=ON" "-Dxml=ON"
"-Dxrootd=OFF" "-Dxrootd=OFF"
] ]
++ lib.optional stdenv.hostPlatform.isDarwin "-DOPENGL_INCLUDE_DIR=${OpenGL}/Library/Frameworks"; ++ lib.optional ((!stdenv.hostPlatform.isDarwin) && (stdenv.cc.libc != null)) "-DC_INCLUDE_DIRS=${lib.getDev stdenv.cc.libc}/include";
env.NIX_CFLAGS_COMPILE = "-fpermissive";
setupHook = ./setup-hook.sh; setupHook = ./setup-hook.sh;

View File

@ -0,0 +1,19 @@
thisroot () {
# Workaround thisroot.sh dependency on man
if [ -z "${MANPATH-}" ]; then
MANPATH=:
fi
local oldOpts="-u"
shopt -qo nounset || oldOpts="+u"
set +u
source @out@/bin/thisroot.sh
set "$oldOpts"
}
postHooks+=(thisroot)
addRootIncludePath() {
addToSearchPath ROOT_INCLUDE_PATH $1/include
}
addEnvHooks "$targetOffset" addRootIncludePath

View File

@ -11,7 +11,7 @@ let
pythonVersion = with lib.versions; "${major python.version}${minor python.version}"; pythonVersion = with lib.versions; "${major python.version}${minor python.version}";
withPython = python != null; withPython = python != null;
# ensure that root is built with the same python interpreter, as it links against numpy # ensure that root is built with the same python interpreter, as it links against numpy
root_py = if withPython then root.override { inherit python; } else root; root_py = if withPython then root.override { python3 = python; } else root;
in in
stdenv.mkDerivation rec { stdenv.mkDerivation rec {

View File

@ -18234,15 +18234,6 @@ with pkgs;
ns-3 = callPackage ../development/libraries/science/networking/ns-3 { python = python3; }; ns-3 = callPackage ../development/libraries/science/networking/ns-3 { python = python3; };
root = callPackage ../applications/science/misc/root {
python = python3;
inherit (darwin.apple_sdk.frameworks) Cocoa CoreSymbolication OpenGL;
};
root5 = lowPrio (callPackage ../applications/science/misc/root/5.nix {
inherit (darwin.apple_sdk.frameworks) Cocoa OpenGL;
});
rink = callPackage ../applications/science/misc/rink { rink = callPackage ../applications/science/misc/rink {
inherit (darwin.apple_sdk.frameworks) Security; inherit (darwin.apple_sdk.frameworks) Security;
}; };