From 4d5d04a238c2e19db055378d0c833ddd7cc73cc8 Mon Sep 17 00:00:00 2001 From: Alyssa Ross Date: Fri, 17 Jul 2020 16:45:39 +0000 Subject: [PATCH 1/3] mysql80: 8.0.17 -> 8.0.21 Hopefully substituteInPlace will be less brittle than the patch. --- pkgs/servers/sql/mysql/8.0.x.nix | 12 ++++++++---- pkgs/servers/sql/mysql/libutils.patch | 5 ----- pkgs/top-level/all-packages.nix | 2 +- 3 files changed, 9 insertions(+), 10 deletions(-) delete mode 100644 pkgs/servers/sql/mysql/libutils.patch diff --git a/pkgs/servers/sql/mysql/8.0.x.nix b/pkgs/servers/sql/mysql/8.0.x.nix index 299302b27de0..eb5700ca8d30 100644 --- a/pkgs/servers/sql/mysql/8.0.x.nix +++ b/pkgs/servers/sql/mysql/8.0.x.nix @@ -1,27 +1,31 @@ { lib, stdenv, fetchurl, bison, cmake, pkgconfig -, boost, icu, libedit, libevent, lz4, ncurses, openssl, protobuf, re2, readline, zlib +, boost, icu, libedit, libevent, lz4, ncurses, openssl, protobuf, re2, readline, zlib, zstd , numactl, perl, cctools, CoreServices, developer_cmds, libtirpc, rpcsvc-proto }: let self = stdenv.mkDerivation rec { pname = "mysql"; - version = "8.0.17"; + version = "8.0.21"; src = fetchurl { url = "https://dev.mysql.com/get/Downloads/MySQL-${self.mysqlVersion}/${pname}-${version}.tar.gz"; - sha256 = "1mjrlxn8vigi69r0r674j2dibdnkaar01ji5965gsyx7k60z7qy6"; + sha256 = "0d00k55rkzdgn5wj32vxankjk5x3ywfqw62zxzg3m503xrg56mmd"; }; patches = [ ./abi-check.patch - ./libutils.patch ]; nativeBuildInputs = [ bison cmake pkgconfig rpcsvc-proto ]; + postPatch = '' + substituteInPlace cmake/libutils.cmake --replace /usr/bin/ "" + ''; + buildInputs = [ boost icu libedit libevent lz4 ncurses openssl protobuf re2 readline zlib + zstd ] ++ lib.optionals stdenv.isLinux [ numactl libtirpc ] ++ lib.optionals stdenv.isDarwin [ diff --git a/pkgs/servers/sql/mysql/libutils.patch b/pkgs/servers/sql/mysql/libutils.patch deleted file mode 100644 index fa1a35e12f23..000000000000 --- a/pkgs/servers/sql/mysql/libutils.patch +++ /dev/null @@ -1,5 +0,0 @@ ---- a/cmake/libutils.cmake -+++ b/cmake/libutils.cmake -@@ -345 +345 @@ MACRO(MERGE_CONVENIENCE_LIBRARIES) -- COMMAND /usr/bin/libtool -static -o $ -+ COMMAND libtool -static -o $ diff --git a/pkgs/top-level/all-packages.nix b/pkgs/top-level/all-packages.nix index 87a9cd51e7fd..a4c3b705e34f 100644 --- a/pkgs/top-level/all-packages.nix +++ b/pkgs/top-level/all-packages.nix @@ -17805,7 +17805,7 @@ in mysql80 = callPackage ../servers/sql/mysql/8.0.x.nix { inherit (darwin) cctools developer_cmds; inherit (darwin.apple_sdk.frameworks) CoreServices; - boost = boost169; # Configure checks for specific version. + boost = boost172; # Configure checks for specific version. protobuf = protobuf3_7; }; From 1dc5b4612f66dba9475e650528840b8ac66dc33f Mon Sep 17 00:00:00 2001 From: Tim Otten Date: Sun, 10 Jan 2021 22:49:18 -0800 Subject: [PATCH 2/3] mysql80: 8.0.21 -> 8.0.22 --- pkgs/servers/sql/mysql/8.0.x.nix | 4 ++-- pkgs/top-level/all-packages.nix | 2 +- 2 files changed, 3 insertions(+), 3 deletions(-) diff --git a/pkgs/servers/sql/mysql/8.0.x.nix b/pkgs/servers/sql/mysql/8.0.x.nix index eb5700ca8d30..a11f5fe1465b 100644 --- a/pkgs/servers/sql/mysql/8.0.x.nix +++ b/pkgs/servers/sql/mysql/8.0.x.nix @@ -6,11 +6,11 @@ let self = stdenv.mkDerivation rec { pname = "mysql"; - version = "8.0.21"; + version = "8.0.22"; src = fetchurl { url = "https://dev.mysql.com/get/Downloads/MySQL-${self.mysqlVersion}/${pname}-${version}.tar.gz"; - sha256 = "0d00k55rkzdgn5wj32vxankjk5x3ywfqw62zxzg3m503xrg56mmd"; + sha256 = "9fd85bb243940ef8234d21384ef421a0962fd4d13406fc1420efa902115ce17a"; }; patches = [ diff --git a/pkgs/top-level/all-packages.nix b/pkgs/top-level/all-packages.nix index a4c3b705e34f..329ab973d629 100644 --- a/pkgs/top-level/all-packages.nix +++ b/pkgs/top-level/all-packages.nix @@ -17805,7 +17805,7 @@ in mysql80 = callPackage ../servers/sql/mysql/8.0.x.nix { inherit (darwin) cctools developer_cmds; inherit (darwin.apple_sdk.frameworks) CoreServices; - boost = boost172; # Configure checks for specific version. + boost = boost173; # Configure checks for specific version. protobuf = protobuf3_7; }; From 0f387ba1841386c3a503bc1ddeb40658d7d907d5 Mon Sep 17 00:00:00 2001 From: Tim Otten Date: Sun, 10 Jan 2021 23:51:29 -0800 Subject: [PATCH 3/3] mysql80: Fix additional libtool reference in 8.0.22 --- pkgs/servers/sql/mysql/8.0.x.nix | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/pkgs/servers/sql/mysql/8.0.x.nix b/pkgs/servers/sql/mysql/8.0.x.nix index a11f5fe1465b..519ef64bca80 100644 --- a/pkgs/servers/sql/mysql/8.0.x.nix +++ b/pkgs/servers/sql/mysql/8.0.x.nix @@ -19,8 +19,10 @@ self = stdenv.mkDerivation rec { nativeBuildInputs = [ bison cmake pkgconfig rpcsvc-proto ]; + ## NOTE: MySQL upstream frequently twiddles the invocations of libtool. When updating, you might proactively grep for libtool references. postPatch = '' - substituteInPlace cmake/libutils.cmake --replace /usr/bin/ "" + substituteInPlace cmake/libutils.cmake --replace /usr/bin/libtool libtool + substituteInPlace cmake/os/Darwin.cmake --replace /usr/bin/libtool libtool ''; buildInputs = [