nordic-dev.net/nixpkgs
nordic-dev.net/nixpkgs
2
0
Fork 0
mirror of https://github.com/NixOS/nixpkgs.git synced 2025-02-17 01:24:47 +00:00
Code Issues Packages Projects Releases Wiki Activity

stdenv: fix SC2223

Browse Source 
In pkgs/stdenv/generic/setup.sh line 36:
    : ${outputs:=out}
      ^-------------^ SC2223 (info): This default assignment may cause DoS due to globbing. Quote it.
This commit is contained in:
Artturin 2023-01-16 00:36:31 +02:00
parent fe1c7a1945
commit 0e8263ce73
1 changed files with 10 additions and 10 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

20
pkgs/stdenv/generic/setup.sh
View File

@ -32,7 +32,7 @@ if [ -n "$__structuredAttrs" ]; then
export NIX_ATTRS_JSON_FILE="$NIX_BUILD_TOP/.attrs.json"
export NIX_ATTRS_SH_FILE="$NIX_BUILD_TOP/.attrs.sh"
else
: ${outputs:=out}
: "${outputs:=out}"
fi
getAllOutputNames() {
@ -393,7 +393,7 @@ fi
# implementation uses zip archive and zip does not support dates going back to
# 1970.
export SOURCE_DATE_EPOCH
: ${SOURCE_DATE_EPOCH:=315532800}
: "${SOURCE_DATE_EPOCH:=315532800}"
# Wildcard expansions that don't match should expand to an empty list.
@ -605,12 +605,12 @@ findInputs() {
# in each list must be store paths, and therefore space-free.
# Make sure all are at least defined as empty
: ${depsBuildBuild=} ${depsBuildBuildPropagated=}
: ${nativeBuildInputs=} ${propagatedNativeBuildInputs=} ${defaultNativeBuildInputs=}
: ${depsBuildTarget=} ${depsBuildTargetPropagated=}
: ${depsHostHost=} ${depsHostHostPropagated=}
: ${buildInputs=} ${propagatedBuildInputs=} ${defaultBuildInputs=}
: ${depsTargetTarget=} ${depsTargetTargetPropagated=}
: "${depsBuildBuild=}" "${depsBuildBuildPropagated=}"
: "${nativeBuildInputs=}" "${propagatedNativeBuildInputs=}" "${defaultNativeBuildInputs=}"
: "${depsBuildTarget=}" "${depsBuildTargetPropagated=}"
: "${depsHostHost=}" "${depsHostHostPropagated=}"
: "${buildInputs=}" "${propagatedBuildInputs=}" "${defaultBuildInputs=}"
: "${depsTargetTarget=}" "${depsTargetTargetPropagated=}"
for pkg in ${depsBuildBuild[@]} ${depsBuildBuildPropagated[@]}; do
findInputs "$pkg" -1 -1
@ -1070,7 +1070,7 @@ unpackPhase() {
# Find the source directory.
# set to empty if unset
: ${sourceRoot=}
: "${sourceRoot=}"
if [ -n "${setSourceRoot:-}" ]; then
runOneHook setSourceRoot
@ -1174,7 +1174,7 @@ configurePhase() {
runHook preConfigure
# set to empty if unset
: ${configureScript=}
: "${configureScript=}"
if [[ -z "$configureScript" && -x ./configure ]]; then
configureScript=./configure