diff --git a/pkgs/misc/emulators/cdemu/analyzer.nix b/pkgs/misc/emulators/cdemu/analyzer.nix index 21ec032f5cca..338c64a24b81 100644 --- a/pkgs/misc/emulators/cdemu/analyzer.nix +++ b/pkgs/misc/emulators/cdemu/analyzer.nix @@ -2,7 +2,7 @@ , python3Packages, gtk3, glib, libxml2, gnuplot, gnome, gdk-pixbuf, librsvg, intltool, libmirage }: let pkg = import ./base.nix { version = "3.2.5"; - pkgName = "image-analyzer"; + pname = "image-analyzer"; pkgSha256 = "00906lky0z1m0bdqnjmzxgcb19dzvljhddhh42lixyr53sjp94cc"; }; in callPackage pkg { diff --git a/pkgs/misc/emulators/cdemu/base.nix b/pkgs/misc/emulators/cdemu/base.nix index 1754f2ad4bbc..9464bde70bf7 100644 --- a/pkgs/misc/emulators/cdemu/base.nix +++ b/pkgs/misc/emulators/cdemu/base.nix @@ -1,10 +1,9 @@ -{ pkgName, version, pkgSha256 }: +{ pname, version, pkgSha256 }: { lib, stdenv, fetchurl, cmake, pkg-config, buildInputs, drvParams ? {} }: -let name = "${pkgName}-${version}"; -in stdenv.mkDerivation ({ - inherit name buildInputs; +stdenv.mkDerivation ( rec { + inherit pname version buildInputs; src = fetchurl { - url = "mirror://sourceforge/cdemu/${name}.tar.xz"; + url = "mirror://sourceforge/cdemu/${pname}-${version}.tar.xz"; sha256 = pkgSha256; }; nativeBuildInputs = [ pkg-config cmake ]; @@ -14,7 +13,7 @@ in stdenv.mkDerivation ({ sourceRoot="`pwd`" ''; configurePhase = '' - cmake ../${name} -DCMAKE_INSTALL_PREFIX=$out -DCMAKE_BUILD_TYPE=Release -DCMAKE_SKIP_RPATH=ON + cmake ../${pname}-${version} -DCMAKE_INSTALL_PREFIX=$out -DCMAKE_BUILD_TYPE=Release -DCMAKE_SKIP_RPATH=ON ''; meta = with lib; { description = "A suite of tools for emulating optical drives and discs"; diff --git a/pkgs/misc/emulators/cdemu/client.nix b/pkgs/misc/emulators/cdemu/client.nix index 0572dda59546..06604e3eae99 100644 --- a/pkgs/misc/emulators/cdemu/client.nix +++ b/pkgs/misc/emulators/cdemu/client.nix @@ -1,7 +1,7 @@ { callPackage, python3Packages, intltool, makeWrapper }: let pkg = import ./base.nix { version = "3.2.5"; - pkgName = "cdemu-client"; + pname = "cdemu-client"; pkgSha256 = "1prrdhv0ia0axc6b73crszqzh802wlkihz6d100yvg7wbgmqabd7"; }; in callPackage pkg { diff --git a/pkgs/misc/emulators/cdemu/daemon.nix b/pkgs/misc/emulators/cdemu/daemon.nix index 4fc3ea211993..3df9e4ad5437 100644 --- a/pkgs/misc/emulators/cdemu/daemon.nix +++ b/pkgs/misc/emulators/cdemu/daemon.nix @@ -1,7 +1,7 @@ { callPackage, glib, libao, intltool, libmirage }: let pkg = import ./base.nix { version = "3.2.5"; - pkgName = "cdemu-daemon"; + pname = "cdemu-daemon"; pkgSha256 = "16g6fv1lxkdmbsy6zh5sj54dvgwvm900fd18aq609yg8jnqm644d"; }; in callPackage pkg { diff --git a/pkgs/misc/emulators/cdemu/gui.nix b/pkgs/misc/emulators/cdemu/gui.nix index 6f5313c4cca7..15e595a61729 100644 --- a/pkgs/misc/emulators/cdemu/gui.nix +++ b/pkgs/misc/emulators/cdemu/gui.nix @@ -3,7 +3,7 @@ let pkg = import ./base.nix { version = "3.2.5"; - pkgName = "gcdemu"; + pname = "gcdemu"; pkgSha256 = "1nvpbq4mz8caw91q5ny9gf206g9bypavxws9nxyfcanfkc4zfkl4"; }; inherit (python3Packages) python pygobject3; diff --git a/pkgs/misc/emulators/cdemu/libmirage.nix b/pkgs/misc/emulators/cdemu/libmirage.nix index 0025226d2087..7016a42d247b 100644 --- a/pkgs/misc/emulators/cdemu/libmirage.nix +++ b/pkgs/misc/emulators/cdemu/libmirage.nix @@ -4,7 +4,7 @@ let pkg = import ./base.nix { version = "3.2.5"; - pkgName = "libmirage"; + pname = "libmirage"; pkgSha256 = "0f8i2ha44rykkk3ac2q8zsw3y1zckw6qnf6zvkyrj3qqbzhrf3fm"; }; in callPackage pkg { diff --git a/pkgs/misc/emulators/resim/default.nix b/pkgs/misc/emulators/resim/default.nix index 6e759bd75522..49d7721174f5 100644 --- a/pkgs/misc/emulators/resim/default.nix +++ b/pkgs/misc/emulators/resim/default.nix @@ -1,7 +1,8 @@ { fetchFromGitHub, lib, stdenv, cmake, qt4 }: stdenv.mkDerivation { - name = "resim"; + pname = "resim"; + version = "unstable-2016-11-11"; src = fetchFromGitHub { owner = "itszor"; repo = "resim"; diff --git a/pkgs/misc/emulators/wine/winetricks.nix b/pkgs/misc/emulators/wine/winetricks.nix index 26c141a71e74..61ca6515c448 100644 --- a/pkgs/misc/emulators/wine/winetricks.nix +++ b/pkgs/misc/emulators/wine/winetricks.nix @@ -2,7 +2,8 @@ , cabextract, unzip, p7zip, gnused, gnugrep, bash } : stdenv.mkDerivation rec { - name = "winetricks-${src.version}"; + pname = "winetricks"; + version = src.version; src = (callPackage ./sources.nix {}).winetricks; diff --git a/pkgs/misc/gnuk/generic.nix b/pkgs/misc/gnuk/generic.nix index 8d32e9f66d10..2556ff42308f 100644 --- a/pkgs/misc/gnuk/generic.nix +++ b/pkgs/misc/gnuk/generic.nix @@ -10,9 +10,9 @@ }: stdenv.mkDerivation { - name = "gnuk-${version}-${device}"; + pname = "gnuk-${device}"; - inherit src; + inherit version src; nativeBuildInputs = [ gcc-arm-embedded binutils-arm-embedded makeWrapper ]; buildInputs = with python3Packages; [ python pyusb colorama ]; diff --git a/pkgs/misc/screensavers/alock/default.nix b/pkgs/misc/screensavers/alock/default.nix index d10082a71e3e..5f0c5ad9e29e 100644 --- a/pkgs/misc/screensavers/alock/default.nix +++ b/pkgs/misc/screensavers/alock/default.nix @@ -2,8 +2,8 @@ , libX11, pam, libgcrypt, libXrender, imlib2 }: stdenv.mkDerivation rec { - date = "20170720"; - name = "alock-${date}"; + pname = "alock"; + version = "unstable-2017-07-20"; src = fetchgit { url = "https://github.com/Arkq/alock"; diff --git a/pkgs/misc/screensavers/xssproxy/default.nix b/pkgs/misc/screensavers/xssproxy/default.nix index 5e1c42084137..e9c7eebacc06 100644 --- a/pkgs/misc/screensavers/xssproxy/default.nix +++ b/pkgs/misc/screensavers/xssproxy/default.nix @@ -1,14 +1,13 @@ { lib, stdenv, fetchFromGitHub, glib, pkg-config, xorg, dbus }: -let rev = "1.0.0"; in - -stdenv.mkDerivation { - name = "xssproxy-${rev}"; +stdenv.mkDerivation rec { + pname = "xssproxy"; + version = "1.0.0"; src = fetchFromGitHub { owner = "timakro"; repo = "xssproxy"; - rev = "v${rev}"; + rev = "v${version}"; sha256 = "0c83wmipnsdnbihc5niyczs7jrkss2s8n6iwwjdia7hkjzbd0hl7"; }; diff --git a/pkgs/os-specific/linux/device-tree/raspberrypi.nix b/pkgs/os-specific/linux/device-tree/raspberrypi.nix index b4b40f8331f9..d9ccb70f1f03 100644 --- a/pkgs/os-specific/linux/device-tree/raspberrypi.nix +++ b/pkgs/os-specific/linux/device-tree/raspberrypi.nix @@ -1,7 +1,8 @@ { lib, stdenvNoCC, raspberrypifw }: stdenvNoCC.mkDerivation { - name = "raspberrypi-dtbs-${raspberrypifw.version}"; + pname = "raspberrypi-dtbs"; + version = raspberrypifw.version; nativeBuildInputs = [ raspberrypifw ]; # Rename DTBs so u-boot finds them, like linux-rpi.nix diff --git a/pkgs/os-specific/linux/firmware/rtl8723bs-firmware/default.nix b/pkgs/os-specific/linux/firmware/rtl8723bs-firmware/default.nix index c587994ccecb..f3ea80348b3b 100644 --- a/pkgs/os-specific/linux/firmware/rtl8723bs-firmware/default.nix +++ b/pkgs/os-specific/linux/firmware/rtl8723bs-firmware/default.nix @@ -1,7 +1,8 @@ { lib, stdenv, linuxPackages }: with lib; stdenv.mkDerivation { - name = "rtl8723bs-firmware-${linuxPackages.rtl8723bs.version}"; + pname = "rtl8723bs-firmware"; + version = linuxPackages.rtl8723bs.version; inherit (linuxPackages.rtl8723bs) src; dontBuild = true; diff --git a/pkgs/os-specific/linux/hdapsd/default.nix b/pkgs/os-specific/linux/hdapsd/default.nix index 39f69ef01441..959fa9ac6e8a 100644 --- a/pkgs/os-specific/linux/hdapsd/default.nix +++ b/pkgs/os-specific/linux/hdapsd/default.nix @@ -1,8 +1,8 @@ { lib, stdenv, fetchurl }: -let version = "20141203"; in -stdenv.mkDerivation { - name = "hdapsd-"+version; +stdenv.mkDerivation rec { + pname = "hdapsd"; + version = "20141203"; src = fetchurl { url = "https://github.com/evgeni/hdapsd/releases/download/${version}/hdapsd-${version}.tar.gz"; diff --git a/pkgs/os-specific/linux/jfbview/default.nix b/pkgs/os-specific/linux/jfbview/default.nix index da4135d8a806..eb61ff9d5130 100644 --- a/pkgs/os-specific/linux/jfbview/default.nix +++ b/pkgs/os-specific/linux/jfbview/default.nix @@ -14,7 +14,7 @@ let in stdenv.mkDerivation rec { - name = "${package}-${version}"; + pname = package; version = "0.5.7"; src = fetchFromGitHub { diff --git a/pkgs/os-specific/linux/jool/cli.nix b/pkgs/os-specific/linux/jool/cli.nix index b1bce496614a..4c18f478798e 100644 --- a/pkgs/os-specific/linux/jool/cli.nix +++ b/pkgs/os-specific/linux/jool/cli.nix @@ -5,7 +5,8 @@ let in stdenv.mkDerivation { - name = "jool-cli-${sourceAttrs.version}"; + pname = "jool-cli"; + version = sourceAttrs.version; src = sourceAttrs.src; diff --git a/pkgs/os-specific/linux/kernel/gpio-utils.nix b/pkgs/os-specific/linux/kernel/gpio-utils.nix index e28d838efb3f..9c7386f61c1d 100644 --- a/pkgs/os-specific/linux/kernel/gpio-utils.nix +++ b/pkgs/os-specific/linux/kernel/gpio-utils.nix @@ -5,7 +5,8 @@ with lib; assert versionAtLeast linux.version "4.6"; stdenv.mkDerivation { - name = "gpio-utils-${linux.version}"; + pname = "gpio-utils"; + version = linux.version; inherit (linux) src makeFlags; diff --git a/pkgs/os-specific/linux/microcode/amd.nix b/pkgs/os-specific/linux/microcode/amd.nix index cdb2912c4af6..0f3d0f18186a 100644 --- a/pkgs/os-specific/linux/microcode/amd.nix +++ b/pkgs/os-specific/linux/microcode/amd.nix @@ -1,7 +1,8 @@ { lib, stdenv, linux-firmware, libarchive }: stdenv.mkDerivation { - name = "amd-ucode-${linux-firmware.version}"; + pname = "amd-ucode"; + version = linux-firmware.version; src = linux-firmware;