2018-06-17 20:28:23 +00:00
|
|
|
{ stdenv, lib, fetchurl, fetchpatch, autoconf, automake, libtool, bison
|
dovecot, opensmtpd: add link to test in `meta.tests`
Rationale
---------
Currently, tests are hard to discover. For instance, someone updating
`dovecot` might not notice that the interaction of `dovecot` with
`opensmtpd` is handled in the `opensmtpd.nix` test.
And even for someone updating `opensmtpd`, it requires manual work to go
check in `nixos/tests` whether there is actually a test, especially
given not so many packages in `nixpkgs` have tests and this is thus most
of the time useless.
Finally, for the reviewer, it is much easier to check that the “Tested
via one or more NixOS test(s)” has been checked if the file modified
already includes the list of relevant tests.
Implementation
--------------
Currently, this commit only adds the metadata in the package. Each
element of the `meta.tests` attribute is a derivation that, when it
builds successfully, means the test has passed (ie. following the same
convention as NixOS tests).
Future Work
-----------
In the future, the tools could be made aware of this `meta.tests`
attribute, and for instance a `--with-tests` could be added to
`nix-build` so that it also builds all the tests. Or a `--without-tests`
to build without all the tests. @Profpatsch described in his NixCon talk
such systems.
Another thing that would help in the future would be the possibility to
reasonably easily have cross-derivation nix tests without the whole
NixOS VM stack. @7c6f434c already proposed such a system.
This RFC currently handles none of these concerns. Only the addition of
`meta.tests` as metadata to be used by maintainers to remember to run
relevant tests.
2018-08-04 03:18:28 +00:00
|
|
|
, libasr, libevent, zlib, libressl, db, pam, nixosTests
|
2015-04-22 22:37:51 +00:00
|
|
|
}:
|
2013-07-15 13:05:03 +00:00
|
|
|
|
2018-10-23 15:07:17 +00:00
|
|
|
stdenv.mkDerivation rec {
|
2013-07-15 13:05:03 +00:00
|
|
|
name = "opensmtpd-${version}";
|
2019-01-16 11:58:04 +00:00
|
|
|
version = "6.4.1p2";
|
2013-07-15 13:05:03 +00:00
|
|
|
|
2015-04-22 22:37:51 +00:00
|
|
|
nativeBuildInputs = [ autoconf automake libtool bison ];
|
2018-10-23 15:07:17 +00:00
|
|
|
buildInputs = [ libasr libevent zlib libressl db pam ];
|
2013-07-15 13:05:03 +00:00
|
|
|
|
|
|
|
|
src = fetchurl {
|
2016-09-15 15:19:51 +00:00
|
|
|
url = "https://www.opensmtpd.org/archives/${name}.tar.gz";
|
2019-01-16 11:58:04 +00:00
|
|
|
sha256 = "0cppqlx4fk6l8rbim5symh2fm1kzshf421256g596j6c9f9q96xn";
|
2015-02-13 00:24:05 +00:00
|
|
|
};
|
2013-07-15 13:05:03 +00:00
|
|
|
|
2018-06-17 20:28:23 +00:00
|
|
|
patches = [
|
2019-01-16 16:11:39 +00:00
|
|
|
./proc_path.diff # TODO: upstream to OpenSMTPD, see https://github.com/NixOS/nixpkgs/issues/54045
|
2018-06-17 20:28:23 +00:00
|
|
|
];
|
2015-09-26 07:40:44 +00:00
|
|
|
|
2018-10-23 15:07:17 +00:00
|
|
|
# See https://github.com/OpenSMTPD/OpenSMTPD/issues/885 for the `sh bootstrap`
|
|
|
|
|
# requirement
|
|
|
|
|
postPatch = ''
|
|
|
|
|
substituteInPlace smtpd/parse.y \
|
|
|
|
|
--replace "/usr/libexec/" "$out/libexec/opensmtpd/"
|
|
|
|
|
substituteInPlace mk/smtpctl/Makefile.am --replace "chgrp" "true"
|
|
|
|
|
substituteInPlace mk/smtpctl/Makefile.am --replace "chmod 2555" "chmod 0555"
|
|
|
|
|
sh bootstrap
|
|
|
|
|
'';
|
2016-05-23 21:07:05 +00:00
|
|
|
|
2015-02-13 00:24:05 +00:00
|
|
|
configureFlags = [
|
2015-04-22 22:37:51 +00:00
|
|
|
"--sysconfdir=/etc"
|
|
|
|
|
"--localstatedir=/var"
|
2013-07-15 13:05:03 +00:00
|
|
|
"--with-mantype=doc"
|
2016-05-27 12:36:42 +00:00
|
|
|
"--with-auth-pam"
|
|
|
|
|
"--without-auth-bsdauth"
|
|
|
|
|
"--with-path-socket=/run"
|
2016-05-22 20:22:39 +00:00
|
|
|
"--with-user-smtpd=smtpd"
|
|
|
|
|
"--with-user-queue=smtpq"
|
|
|
|
|
"--with-group-queue=smtpq"
|
2016-05-27 12:36:42 +00:00
|
|
|
"--with-path-CAfile=/etc/ssl/certs/ca-certificates.crt"
|
|
|
|
|
"--with-libevent=${libevent.dev}"
|
|
|
|
|
"--with-table-db"
|
2015-02-13 00:24:05 +00:00
|
|
|
];
|
2013-07-15 13:05:03 +00:00
|
|
|
|
2018-10-23 15:07:17 +00:00
|
|
|
# See https://github.com/OpenSMTPD/OpenSMTPD/pull/884
|
|
|
|
|
makeFlags = [ "CFLAGS=-ffunction-sections" "LDFLAGS=-Wl,--gc-sections" ];
|
|
|
|
|
|
2015-04-22 22:37:51 +00:00
|
|
|
installFlags = [
|
|
|
|
|
"sysconfdir=\${out}/etc"
|
|
|
|
|
"localstatedir=\${TMPDIR}"
|
|
|
|
|
];
|
|
|
|
|
|
2016-05-22 20:22:39 +00:00
|
|
|
meta = with stdenv.lib; {
|
2014-12-18 19:04:22 +00:00
|
|
|
homepage = https://www.opensmtpd.org/;
|
2013-07-15 13:05:03 +00:00
|
|
|
description = ''
|
|
|
|
|
A free implementation of the server-side SMTP protocol as defined by
|
2014-11-11 13:20:43 +00:00
|
|
|
RFC 5321, with some additional standard extensions
|
2013-07-15 13:05:03 +00:00
|
|
|
'';
|
2016-05-22 20:22:39 +00:00
|
|
|
license = licenses.isc;
|
|
|
|
|
platforms = platforms.linux;
|
2018-10-23 15:07:17 +00:00
|
|
|
maintainers = with maintainers; [ rickynils obadz ekleog ];
|
2018-11-11 13:55:23 +00:00
|
|
|
};
|
|
|
|
|
passthru.tests = {
|
|
|
|
|
basic-functionality-and-dovecot-interaction = nixosTests.opensmtpd;
|
2013-07-15 13:05:03 +00:00
|
|
|
};
|
|
|
|
|
}
|