2020-10-03 12:13:50 +00:00
|
|
|
# Upstream distributes HandBrake with bundle of according versions of libraries
|
|
|
|
# and patches to them. This derivation patches HandBrake to use Nix closure
|
|
|
|
# dependencies.
|
2014-05-03 23:55:36 +00:00
|
|
|
#
|
2019-07-19 17:16:11 +00:00
|
|
|
# NOTE: 2019-07-19: This derivation does not currently support the native macOS
|
|
|
|
# GUI--it produces the "HandbrakeCLI" CLI version only. In the future it would
|
|
|
|
# be nice to add the native GUI (and/or the GTK GUI) as an option too, but that
|
|
|
|
# requires invoking the Xcode build system, which is non-trivial for now.
|
2018-05-10 08:14:04 +00:00
|
|
|
|
2021-05-27 02:09:18 +00:00
|
|
|
{ stdenv, lib, fetchFromGitHub, fetchpatch,
|
2018-12-27 15:40:07 +00:00
|
|
|
# Main build tools
|
2021-03-14 18:12:53 +00:00
|
|
|
pkg-config, autoconf, automake, libtool, m4, xz, python3,
|
2019-12-20 19:47:58 +00:00
|
|
|
numactl,
|
2018-12-27 15:40:07 +00:00
|
|
|
# Processing, video codecs, containers
|
2019-12-20 19:47:58 +00:00
|
|
|
ffmpeg-full, nv-codec-headers, libogg, x264, x265, libvpx, libtheora, dav1d,
|
2018-12-27 15:40:07 +00:00
|
|
|
# Codecs, audio
|
|
|
|
libopus, lame, libvorbis, a52dec, speex, libsamplerate,
|
|
|
|
# Text processing
|
2019-03-26 13:58:29 +00:00
|
|
|
libiconv, fribidi, fontconfig, freetype, libass, jansson, libxml2, harfbuzz,
|
2018-12-27 15:40:07 +00:00
|
|
|
# Optical media
|
2018-12-27 15:05:57 +00:00
|
|
|
libdvdread, libdvdnav, libdvdcss, libbluray,
|
2019-07-19 17:16:11 +00:00
|
|
|
# Darwin-specific
|
|
|
|
AudioToolbox ? null,
|
|
|
|
Foundation ? null,
|
|
|
|
libobjc ? null,
|
|
|
|
VideoToolbox ? null,
|
|
|
|
# GTK
|
|
|
|
# NOTE: 2019-07-19: The gtk3 package has a transitive dependency on dbus,
|
|
|
|
# which in turn depends on systemd. systemd is not supported on Darwin, so
|
|
|
|
# for now we disable GTK GUI support on Darwin. (It may be possible to remove
|
|
|
|
# this restriction later.)
|
|
|
|
useGtk ? !stdenv.isDarwin, wrapGAppsHook ? null,
|
2020-05-19 04:19:13 +00:00
|
|
|
intltool ? null,
|
|
|
|
glib ? null,
|
|
|
|
gtk3 ? null,
|
|
|
|
libappindicator-gtk3 ? null,
|
|
|
|
libnotify ? null,
|
|
|
|
gst_all_1 ? null,
|
|
|
|
dbus-glib ? null,
|
|
|
|
udev ? null,
|
|
|
|
libgudev ? null,
|
|
|
|
hicolor-icon-theme ? null,
|
2019-07-19 17:16:11 +00:00
|
|
|
# FDK
|
2018-04-17 19:00:23 +00:00
|
|
|
useFdk ? false, fdk_aac ? null
|
2014-05-03 23:55:36 +00:00
|
|
|
}:
|
|
|
|
|
|
|
|
stdenv.mkDerivation rec {
|
2019-02-19 11:37:29 +00:00
|
|
|
pname = "handbrake";
|
2020-06-14 09:17:36 +00:00
|
|
|
version = "1.3.3";
|
2014-05-03 23:55:36 +00:00
|
|
|
|
2020-05-19 04:19:13 +00:00
|
|
|
src = fetchFromGitHub {
|
|
|
|
owner = "HandBrake";
|
|
|
|
repo = "HandBrake";
|
|
|
|
rev = version;
|
2020-06-14 09:17:36 +00:00
|
|
|
sha256 = "0bsmk37543zv3p32a7wxnh2w483am23ha2amj339q3nnb4142krn";
|
2020-05-19 04:19:13 +00:00
|
|
|
extraPostFetch = ''
|
|
|
|
echo "DATE=$(date +"%F %T %z" -r $out/NEWS.markdown)" > $out/version.txt
|
|
|
|
'';
|
2017-03-18 08:44:45 +00:00
|
|
|
};
|
|
|
|
|
2021-05-27 02:09:18 +00:00
|
|
|
# Remove with a release after 1.3.3
|
|
|
|
patches = [
|
|
|
|
(fetchpatch {
|
|
|
|
name = "audio-fix-ffmpeg-4_4";
|
|
|
|
url = "https://github.com/HandBrake/HandBrake/commit/f28289fb06ab461ea082b4be56d6d1504c0c31c2.patch";
|
|
|
|
sha256 = "sha256:1zcwa4h97d8wjspb8kbd8b1jg0a9vvmv9zaphzry4m9q0bj3h3kz";
|
|
|
|
})
|
|
|
|
];
|
|
|
|
|
2020-05-19 04:19:13 +00:00
|
|
|
# we put as little as possible in src.extraPostFetch as it's much easier to
|
|
|
|
# add to it here without having to fiddle with src.sha256
|
|
|
|
# only DATE and HASH are absolutely necessary
|
|
|
|
postPatch = ''
|
|
|
|
cat >> version.txt <<_EOF
|
|
|
|
HASH=${src.rev}
|
|
|
|
SHORTHASH=${src.rev}
|
|
|
|
TAG=${version}
|
|
|
|
URL=${src.meta.homepage}
|
|
|
|
_EOF
|
|
|
|
|
|
|
|
patchShebangs scripts
|
|
|
|
|
|
|
|
# Force using nixpkgs dependencies
|
|
|
|
sed -i '/MODULES += contrib/d' make/include/main.defs
|
|
|
|
sed -e 's/^[[:space:]]*\(meson\|ninja\|nasm\)[[:space:]]*= ToolProbe.*$//g' \
|
|
|
|
-e '/ ## Additional library and tool checks/,/ ## MinGW specific library and tool checks/d' \
|
|
|
|
-i make/configure.py
|
2020-10-03 12:13:50 +00:00
|
|
|
'' + (lib.optionalString stdenv.isDarwin ''
|
|
|
|
# Use the Nix-provided libxml2 instead of the patched version available on
|
|
|
|
# the Handbrake website.
|
|
|
|
substituteInPlace libhb/module.defs \
|
|
|
|
--replace '$(CONTRIB.build/)include/libxml2' ${libxml2.dev}/include/libxml2
|
|
|
|
|
|
|
|
# Prevent the configure script from failing if xcodebuild isn't available,
|
|
|
|
# which it isn't in the Nix context. (The actual build goes fine without
|
|
|
|
# xcodebuild.)
|
|
|
|
sed -e '/xcodebuild = ToolProbe/s/abort=.\+)/abort=False)/' -i make/configure.py
|
|
|
|
'') + (lib.optionalString stdenv.isLinux ''
|
|
|
|
# Use the Nix-provided libxml2 instead of the system-provided one.
|
|
|
|
substituteInPlace libhb/module.defs \
|
|
|
|
--replace /usr/include/libxml2 ${libxml2.dev}/include/libxml2
|
|
|
|
'');
|
2020-05-19 04:19:13 +00:00
|
|
|
|
2017-03-18 08:44:45 +00:00
|
|
|
nativeBuildInputs = [
|
2021-01-17 02:09:27 +00:00
|
|
|
pkg-config autoconf automake libtool m4 python3
|
2018-12-27 15:14:59 +00:00
|
|
|
] ++ lib.optionals useGtk [ intltool wrapGAppsHook ];
|
2014-05-03 23:55:36 +00:00
|
|
|
|
|
|
|
buildInputs = [
|
2019-12-20 19:47:58 +00:00
|
|
|
ffmpeg-full libogg libtheora x264 x265 libvpx dav1d
|
2018-12-27 15:40:07 +00:00
|
|
|
libopus lame libvorbis a52dec speex libsamplerate
|
2019-03-26 13:58:29 +00:00
|
|
|
libiconv fribidi fontconfig freetype libass jansson libxml2 harfbuzz
|
2021-03-14 18:12:53 +00:00
|
|
|
libdvdread libdvdnav libdvdcss libbluray xz
|
2020-10-03 12:13:50 +00:00
|
|
|
] ++ lib.optional (!stdenv.isDarwin) numactl
|
|
|
|
++ lib.optionals useGtk [
|
2017-03-18 08:44:45 +00:00
|
|
|
glib gtk3 libappindicator-gtk3 libnotify
|
2018-02-25 02:23:58 +00:00
|
|
|
gst_all_1.gstreamer gst_all_1.gst-plugins-base dbus-glib udev
|
Merge staging-next into master (#44009)
* substitute(): --subst-var was silently coercing to "" if the variable does not exist.
* libffi: simplify using `checkInputs`
* pythonPackges.hypothesis, pythonPackages.pytest: simpify dependency cycle fix
* utillinux: 2.32 -> 2.32.1
https://lkml.org/lkml/2018/7/16/532
* busybox: 1.29.0 -> 1.29.1
* bind: 9.12.1-P2 -> 9.12.2
https://ftp.isc.org/isc/bind9/9.12.2/RELEASE-NOTES-bind-9.12.2.html
* curl: 7.60.0 -> 7.61.0
* gvfs: make tests run, but disable
* ilmbase: disable tests on i686. Spooky!
* mdds: fix tests
* git: disable checks as tests are run in installcheck
* ruby: disable tests
* libcommuni: disable checks as tests are run in installcheck
* librdf: make tests run, but disable
* neon, neon_0_29: make tests run, but disable
* pciutils: 3.6.0 -> 3.6.1
Semi-automatic update generated by https://github.com/ryantm/nixpkgs-update tools. This update was made based on information from https://repology.org/metapackage/pciutils/versions.
* mesa: more include fixes
mostly from void-linux (thanks!)
* npth: 1.5 -> 1.6
minor bump
* boost167: Add lockfree next_prior patch
* stdenv: cleanup darwin bootstrapping
Also gets rid of the full python and some of it's dependencies in the
stdenv build closure.
* Revert "pciutils: use standardized equivalent for canonicalize_file_name"
This reverts commit f8db20fb3ae382eba1ba2b160fe24739f43c0bd7.
Patching should no longer be needed with 3.6.1.
* binutils-wrapper: Try to avoid adding unnecessary -L flags
(cherry picked from commit f3758258b8895508475caf83e92bfb236a27ceb9)
Signed-off-by: Domen Kožar <domen@dev.si>
* libffi: don't check on darwin
libffi usages in stdenv broken darwin. We need to disable doCheck for that case.
* "rm $out/share/icons/hicolor/icon-theme.cache" -> hicolor-icon-theme setup-hook
* python.pkgs.pytest: setupHook to prevent creation of .pytest-cache folder, fixes #40273
When `py.test` was run with a folder as argument, it would not only
search for tests in that folder, but also create a .pytest-cache folder.
Not only is this state we don't want, but it was also causing
collisions.
* parity-ui: fix after merge
* python.pkgs.pytest-flake8: disable test, fix build
* Revert "meson: 0.46.1 -> 0.47.0"
With meson 0.47.0 (or 0.47.1, or git)
things are very wrong re:rpath handling
resulting in at best missing libs but
even corrupt binaries :(.
When we run patchelf it masks the problem
by removing obviously busted paths.
Which is probably why this wasn't noticed immediately.
Unfortunately the binary already
has a long series of paths scribbled
in a space intended for a much smaller string;
in my testing it was something like
lengths were 67 with 300+ written to it.
I think we've reported the relevant issues upstream,
but unfortunately it appears our patches
are what introduces the overwrite/corruption
(by no longer being correct in what they assume)
This doesn't look so bad to fix but it's
not something I can spend more time on
at the moment.
--
Interestingly the overwritten string data
(because it is scribbled past the bounds)
remains in the binary and is why we're suddenly
seeing unexpected references in various builds
-- notably this is is the reason we're
seeing the "extra-utils" breakage
that entirely crippled NixOS on master
(and probably on staging before?).
Fixes #43650.
This reverts commit 305ac4dade5758c58e8ab1666ad0197fd305828d.
(cherry picked from commit 273d68eff8f7b6cd4ebed3718e5078a0f43cb55d)
Signed-off-by: Domen Kožar <domen@dev.si>
2018-07-24 14:04:48 +00:00
|
|
|
libgudev hicolor-icon-theme
|
2018-12-27 15:40:07 +00:00
|
|
|
] ++ lib.optional useFdk fdk_aac
|
2020-05-19 04:19:13 +00:00
|
|
|
++ lib.optionals stdenv.isDarwin [ AudioToolbox Foundation libobjc VideoToolbox ]
|
2018-12-27 15:40:07 +00:00
|
|
|
# NOTE: 2018-12-27: Handbrake supports nv-codec-headers for Linux only,
|
|
|
|
# look at ./make/configure.py search "enable_nvenc"
|
2020-05-19 04:19:13 +00:00
|
|
|
++ lib.optional stdenv.isLinux nv-codec-headers;
|
2014-05-03 23:55:36 +00:00
|
|
|
|
2016-08-29 06:03:41 +00:00
|
|
|
configureFlags = [
|
2017-03-18 08:44:45 +00:00
|
|
|
"--disable-df-fetch"
|
|
|
|
"--disable-df-verify"
|
2019-07-19 17:16:11 +00:00
|
|
|
(if useGtk then "--disable-gtk-update-checks" else "--disable-gtk")
|
|
|
|
(if useFdk then "--enable-fdk-aac" else "")
|
|
|
|
(if stdenv.isDarwin then "--disable-xcode" else "")
|
2020-05-20 04:27:57 +00:00
|
|
|
] ++ lib.optional (stdenv.isx86_32 || stdenv.isx86_64) "--harden";
|
2014-05-03 23:55:36 +00:00
|
|
|
|
2018-12-27 15:05:57 +00:00
|
|
|
# NOTE: 2018-12-27: Check NixOS HandBrake test if changing
|
2020-05-19 13:50:39 +00:00
|
|
|
NIX_LDFLAGS = [
|
2017-03-21 10:28:50 +00:00
|
|
|
"-lx265"
|
|
|
|
];
|
|
|
|
|
2014-05-03 23:55:36 +00:00
|
|
|
preBuild = ''
|
|
|
|
cd build
|
|
|
|
'';
|
|
|
|
|
2021-01-11 07:54:33 +00:00
|
|
|
meta = with lib; {
|
2020-04-01 01:11:51 +00:00
|
|
|
homepage = "http://handbrake.fr/";
|
2018-04-18 17:23:27 +00:00
|
|
|
description = "A tool for converting video files and ripping DVDs";
|
2014-05-03 23:55:36 +00:00
|
|
|
longDescription = ''
|
2018-04-18 17:23:27 +00:00
|
|
|
Tool for converting and remuxing video files
|
|
|
|
into selection of modern and widely supported codecs
|
|
|
|
and containers. Very versatile and customizable.
|
|
|
|
Package provides:
|
|
|
|
CLI - `HandbrakeCLI`
|
2019-09-03 22:49:40 +00:00
|
|
|
GTK GUI - `ghb`
|
2014-05-03 23:55:36 +00:00
|
|
|
'';
|
2017-03-18 08:44:45 +00:00
|
|
|
license = licenses.gpl2;
|
2018-04-18 17:23:27 +00:00
|
|
|
maintainers = with maintainers; [ Anton-Latukha wmertens ];
|
2018-05-15 14:43:25 +00:00
|
|
|
platforms = with platforms; unix;
|
2014-05-03 23:55:36 +00:00
|
|
|
};
|
|
|
|
}
|