nordic-dev.net/nixpkgs
nordic-dev.net/nixpkgs
2
0
Fork 0
mirror of https://github.com/NixOS/nixpkgs.git synced 2024-11-25 08:23:09 +00:00
Code Issues Packages Projects Releases Wiki Activity
455bf7ad57
nixpkgs/pkgs/build-support/make-darwin-bundle/write-darwin-bundle.nix

Ignoring revisions in .git-blame-ignore-revs. Click here to bypass and see the normal blame view.

48 lines
1.4 KiB
Nix
Raw Normal View History

writeDarwinBundle: use binary wrapper Previously `writeDarwinBundle` used a handcrafted shell wrapper, however this causes issues on Apple Silicon Macs as script-only application bundles are always run under Rosetta[0][1]. Replacing the handcrafted shell wrapper with a binary wrapper allows apps to run natively instead of requiring Rosetta. However, this means we can no longer use `$1` and `$@`. After checking nearly every current usage of `desktopToDarwinBundle`, there were no apps that used `%[fFuU]` before the last argument, meaning removing them naively is good enough for the current apps. [0]: https://developer.apple.com/documentation/apple-silicon/building-a-universal-macos-binary [1]: https://stackoverflow.com/a/68208374
2023-08-15 05:07:22 +00:00
{ writeScriptBin, lib, makeBinaryWrapper }:
build-support: make-darwin-bundle: new Add a new module that allows darwin-style application bundles to be created
2021-07-28 21:31:09 +00:00
let
pListText = lib.generators.toPlist { } {
CFBundleDevelopmentRegion = "English";
CFBundleExecutable = "$name";
desktopToDarwinBundle: fix squircle icons - Convert icons to a single .icns file; and - Provide an opt-out via X-macOS-Squircle in the desktop item to override the squircle behavior when the source icons look bad when converted automatically.
2022-02-20 04:30:16 +00:00
CFBundleIconFile = "$icon";
write-darwin-bundle: Invert squircle logic Older macOS cannot interpret the `CFBundleIconFiles` key so we cannot rewrite the `CFBundleIconFile` entry without special consideration. I opted to fix this by inverting the squircle logic. We always add both the `CFBundleIconFile` and `CFBundleIconFiles` keys. The former is necessary for at least macOS 10.13 and probably 10.12. The latter seems to be ignored on those versions and overrides the former on newer versions of macOS. Inverting the logic also allows us to rely on the `toPlist` generator to generate the XML syntax, which is a nice bonus.
2022-03-21 11:35:42 +00:00
CFBundleIconFiles = [ "$icon" ];
build-support: make-darwin-bundle: new Add a new module that allows darwin-style application bundles to be created
2021-07-28 21:31:09 +00:00
CFBundleIdentifier = "org.nixos.$name";
CFBundleInfoDictionaryVersion = "6.0";
CFBundleName = "$name";
CFBundlePackageType = "APPL";
CFBundleSignature = "???";
};
in writeScriptBin "write-darwin-bundle" ''
shopt -s nullglob
desktopToDarwinBundle: fix squircle icons - Convert icons to a single .icns file; and - Provide an opt-out via X-macOS-Squircle in the desktop item to override the squircle behavior when the source icons look bad when converted automatically.
2022-02-20 04:30:16 +00:00
readonly prefix=$1
readonly name=$2
writeDarwinBundle: use binary wrapper Previously `writeDarwinBundle` used a handcrafted shell wrapper, however this causes issues on Apple Silicon Macs as script-only application bundles are always run under Rosetta[0][1]. Replacing the handcrafted shell wrapper with a binary wrapper allows apps to run natively instead of requiring Rosetta. However, this means we can no longer use `$1` and `$@`. After checking nearly every current usage of `desktopToDarwinBundle`, there were no apps that used `%[fFuU]` before the last argument, meaning removing them naively is good enough for the current apps. [0]: https://developer.apple.com/documentation/apple-silicon/building-a-universal-macos-binary [1]: https://stackoverflow.com/a/68208374
2023-08-15 05:07:22 +00:00
# TODO: support executables with spaces in their names
readonly execName=''${3%% *} # Before the first space
[[ $3 =~ " " ]] && readonly execArgs=''${3#* } # Everything after the first space
desktopToDarwinBundle: fix squircle icons - Convert icons to a single .icns file; and - Provide an opt-out via X-macOS-Squircle in the desktop item to override the squircle behavior when the source icons look bad when converted automatically.
2022-02-20 04:30:16 +00:00
readonly icon=$4.icns
readonly squircle=''${5:-1}
readonly plist=$prefix/Applications/$name.app/Contents/Info.plist
writeDarwinBundle: use binary wrapper Previously `writeDarwinBundle` used a handcrafted shell wrapper, however this causes issues on Apple Silicon Macs as script-only application bundles are always run under Rosetta[0][1]. Replacing the handcrafted shell wrapper with a binary wrapper allows apps to run natively instead of requiring Rosetta. However, this means we can no longer use `$1` and `$@`. After checking nearly every current usage of `desktopToDarwinBundle`, there were no apps that used `%[fFuU]` before the last argument, meaning removing them naively is good enough for the current apps. [0]: https://developer.apple.com/documentation/apple-silicon/building-a-universal-macos-binary [1]: https://stackoverflow.com/a/68208374
2023-08-15 05:07:22 +00:00
readonly binary=$prefix/bin/$execName
readonly bundleExecutable=$prefix/Applications/$name.app/Contents/MacOS/$name
build-support: make-darwin-bundle: new Add a new module that allows darwin-style application bundles to be created
2021-07-28 21:31:09 +00:00
desktopToDarwinBundle: fix squircle icons - Convert icons to a single .icns file; and - Provide an opt-out via X-macOS-Squircle in the desktop item to override the squircle behavior when the source icons look bad when converted automatically.
2022-02-20 04:30:16 +00:00
cat > "$plist" <<EOF
build-support: make-darwin-bundle: new Add a new module that allows darwin-style application bundles to be created
2021-07-28 21:31:09 +00:00
${pListText}
EOF
writeDarwinBundle: use binary wrapper Previously `writeDarwinBundle` used a handcrafted shell wrapper, however this causes issues on Apple Silicon Macs as script-only application bundles are always run under Rosetta[0][1]. Replacing the handcrafted shell wrapper with a binary wrapper allows apps to run natively instead of requiring Rosetta. However, this means we can no longer use `$1` and `$@`. After checking nearly every current usage of `desktopToDarwinBundle`, there were no apps that used `%[fFuU]` before the last argument, meaning removing them naively is good enough for the current apps. [0]: https://developer.apple.com/documentation/apple-silicon/building-a-universal-macos-binary [1]: https://stackoverflow.com/a/68208374
2023-08-15 05:07:22 +00:00
if [[ $squircle == 0 || $squircle == "false" ]]; then
sed '/CFBundleIconFiles/,\|</array>|d' -i "$plist"
fi
desktopToDarwinBundle: fix squircle icons - Convert icons to a single .icns file; and - Provide an opt-out via X-macOS-Squircle in the desktop item to override the squircle behavior when the source icons look bad when converted automatically.
2022-02-20 04:30:16 +00:00
writeDarwinBundle: use binary wrapper Previously `writeDarwinBundle` used a handcrafted shell wrapper, however this causes issues on Apple Silicon Macs as script-only application bundles are always run under Rosetta[0][1]. Replacing the handcrafted shell wrapper with a binary wrapper allows apps to run natively instead of requiring Rosetta. However, this means we can no longer use `$1` and `$@`. After checking nearly every current usage of `desktopToDarwinBundle`, there were no apps that used `%[fFuU]` before the last argument, meaning removing them naively is good enough for the current apps. [0]: https://developer.apple.com/documentation/apple-silicon/building-a-universal-macos-binary [1]: https://stackoverflow.com/a/68208374
2023-08-15 05:07:22 +00:00
if [[ -n "$execArgs" ]]; then
(
source ${makeBinaryWrapper}/nix-support/setup-hook
# WORKAROUND: makeBinaryWrapper fails when -u is set
set +u
makeBinaryWrapper "$binary" "$bundleExecutable" --add-flags "$execArgs"
)
else
ln -s "$binary" "$bundleExecutable"
fi
build-support: make-darwin-bundle: new Add a new module that allows darwin-style application bundles to be created
2021-07-28 21:31:09 +00:00
''
Reference in New Issue Copy Permalink